[OpenSmalltalk/opensmalltalk-vm] sqFilePluginBasicPrims.c add sqFileDescriptorType() (#262)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] sqFilePluginBasicPrims.c add sqFileDescriptorType() (#262)

hjht
 

Add the Unix implementation of sqFileDescriptorType() to answer an
enumerated type indicating whether the supplied file descriptor is a
terminal, pipe or file.

The Windows implementation was added 15 May 2018 in commit 858bed2.


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/262

Commit Summary

  • sqFilePluginBasicPrims.c add sqFileDescriptorType()

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"sqFilePluginBasicPrims.c add sqFileDescriptorType() (#262)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/262"}}}</script> <script type="application/ld+json">{"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"sqFilePluginBasicPrims.c add sqFileDescriptorType() (#262)","sections":[{"text":"","activityTitle":"**akgrant43**","activityImage":"https://avatars1.githubusercontent.com/u/2062166?s=160\u0026v=4","activitySubtitle":"@akgrant43","facts":[]},{"title":"Commit Summary","facts":[{"name":"d997f35","value":"sqFilePluginBasicPrims.c add sqFileDescriptorType()"}]},{"title":"File Changes","facts":[{"name":"Modified","value":"[platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/262/files#diff-0) (15 changes)"}]}],"potentialAction":[{"name":"Add a comment","@type":"ActionCard","inputs":[{"isMultiLine":true,"@type":"TextInput","id":"IssueComment","isRequired":false}],"actions":[{"name":"Comment","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"IssueComment\",\"repositoryFullName\":\"OpenSmalltalk/opensmalltalk-vm\",\"issueId\":262,\"IssueComment\":\"{{IssueComment.value}}\"}"}]},{"name":"Close pull request","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"PullRequestClose\",\"repositoryFullName\":\"OpenSmalltalk/opensmalltalk-vm\",\"pullRequestId\":262}"},{"targets":[{"os":"default","uri":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/262"}],"@type":"OpenUri","name":"View on GitHub"},{"targets":[{"os":"default","uri":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/262.patch"}],"@type":"OpenUri","name":"View patch"},{"targets":[{"os":"default","uri":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/262.diff"}],"@type":"OpenUri","name":"View diff"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":335944405}"}],"themeColor":"26292E"}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqFilePluginBasicPrims.c add sqFileDescriptorType() (#262)

hjht
 

The Windows build error is in a third-party library. The changes are in a section of code that is #ifdef'd out of Windows.

The travis build passed the critical platforms and only failed in the sista builds - not related.

I'll merge the PR tomorrow if no one complains.

Cheers,
Alistair


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #262: The Windows build error is in a third-party library. The changes are in a section of code that is #ifdef'd out of Windows.\r\n\r\nThe travis build passed the critical platforms and only failed in the sista builds - not related.\r\n\r\nI'll merge the PR tomorrow if no one complains.\r\n\r\nCheers,\r\nAlistair\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/262#issuecomment-389590827"}}}</script> <script type="application/ld+json">{"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"Re: [OpenSmalltalk/opensmalltalk-vm] sqFilePluginBasicPrims.c add sqFileDescriptorType() (#262)","sections":[{"text":"","activityTitle":"**akgrant43**","activityImage":"https://avatars1.githubusercontent.com/u/2062166?s=160\u0026v=4","activitySubtitle":"@akgrant43","facts":[]}],"potentialAction":[{"name":"Add a comment","@type":"ActionCard","inputs":[{"isMultiLine":true,"@type":"TextInput","id":"IssueComment","isRequired":false}],"actions":[{"name":"Comment","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"IssueComment\",\"repositoryFullName\":\"OpenSmalltalk/opensmalltalk-vm\",\"issueId\":262,\"IssueComment\":\"{{IssueComment.value}}\"}"}]},{"name":"Close pull request","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"PullRequestClose\",\"repositoryFullName\":\"OpenSmalltalk/opensmalltalk-vm\",\"pullRequestId\":262}"},{"targets":[{"os":"default","uri":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/262#issuecomment-389590827"}],"@type":"OpenUri","name":"View on GitHub"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":335944405}"}],"themeColor":"26292E"}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] sqFilePluginBasicPrims.c add sqFileDescriptorType() (#262)

hjht
In reply to this post by hjht
 

Merged #262.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Merged #262."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/262#event-1631829181"}}}</script> <script type="application/ld+json">{"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"Re: [OpenSmalltalk/opensmalltalk-vm] sqFilePluginBasicPrims.c add sqFileDescriptorType() (#262)","sections":[{"text":"","activityTitle":"**akgrant43**","activityImage":"https://avatars1.githubusercontent.com/u/2062166?s=160\u0026v=4","activitySubtitle":"@akgrant43","facts":[]}],"potentialAction":[{"targets":[{"os":"default","uri":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/262#event-1631829181"}],"@type":"OpenUri","name":"View on GitHub"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":335944405}"}],"themeColor":"26292E"}</script>