OrderedIdentityDictionary in a more general package

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

OrderedIdentityDictionary in a more general package

Torsten Bergmann
Stef wrote:
>good idea.
>Do you know the test coverage of the class?
>Because it would be nice to run hapao on it and write some tests if there are none.

Actually there are no tests - at least not in the Pharo image.
Maybe Benjamin can comment if there are some tests in the Spec universe for it.

I opened an issue:  http://code.google.com/p/pharo/issues/detail?id=7374

@Benjamin: can you move "OrderedIdentityDictionary" it out of Spec up to a
          more general "Collection-Ordered" category/package for Pharo?
          I dont want to interfere with current Spec development and
          have no rights to commit to http://ss3.gemstone.com/ss/Spec

BTW: Is it really necessary to have an mzc per "Collection-***" category? Dont
know about the dependencies - but for Kernel we have only one package (and one
for the tests).

Thx
T.



Reply | Threaded
Open this post in threaded view
|

Re: OrderedIdentityDictionary in a more general package

EstebanLM
... and we need Spec as a project under team Pharo, in sthub :)

On Jan 31, 2013, at 8:28 AM, "Torsten Bergmann" <[hidden email]> wrote:

> Stef wrote:
>> good idea.
>> Do you know the test coverage of the class?
>> Because it would be nice to run hapao on it and write some tests if there are none.
>
> Actually there are no tests - at least not in the Pharo image.
> Maybe Benjamin can comment if there are some tests in the Spec universe for it.
>
> I opened an issue:  http://code.google.com/p/pharo/issues/detail?id=7374
>
> @Benjamin: can you move "OrderedIdentityDictionary" it out of Spec up to a
>          more general "Collection-Ordered" category/package for Pharo?
>          I dont want to interfere with current Spec development and
>          have no rights to commit to http://ss3.gemstone.com/ss/Spec
>
> BTW: Is it really necessary to have an mzc per "Collection-***" category? Dont
> know about the dependencies - but for Kernel we have only one package (and one
> for the tests).
>
> Thx
> T.
>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: OrderedIdentityDictionary in a more general package

Tudor Girba-2
Does anyone know the difference between:
- OrderedIdentityDictionary from Spec and
- OrderPreservingDictionary from http://www.squeaksource.com/OrderPreservingDict

?

we use the latter in XMLSupport and I think we could probably consolidate.

Doru


On Thu, Jan 31, 2013 at 9:38 AM, Esteban Lorenzano <[hidden email]> wrote:
... and we need Spec as a project under team Pharo, in sthub :)

On Jan 31, 2013, at 8:28 AM, "Torsten Bergmann" <[hidden email]> wrote:

> Stef wrote:
>> good idea.
>> Do you know the test coverage of the class?
>> Because it would be nice to run hapao on it and write some tests if there are none.
>
> Actually there are no tests - at least not in the Pharo image.
> Maybe Benjamin can comment if there are some tests in the Spec universe for it.
>
> I opened an issue:  http://code.google.com/p/pharo/issues/detail?id=7374
>
> @Benjamin: can you move "OrderedIdentityDictionary" it out of Spec up to a
>          more general "Collection-Ordered" category/package for Pharo?
>          I dont want to interfere with current Spec development and
>          have no rights to commit to http://ss3.gemstone.com/ss/Spec
>
> BTW: Is it really necessary to have an mzc per "Collection-***" category? Dont
> know about the dependencies - but for Kernel we have only one package (and one
> for the tests).
>
> Thx
> T.
>
>
>





--

"Every thing has its own flow"
Reply | Threaded
Open this post in threaded view
|

Re: OrderedIdentityDictionary in a more general package

Stéphane Ducasse
In reply to this post by EstebanLM
It will come :)

Stef

> ... and we need Spec as a project under team Pharo, in sthub :)
>
>
>> Stef wrote:
>>> good idea.
>>> Do you know the test coverage of the class?
>>> Because it would be nice to run hapao on it and write some tests if there are none.
>>
>> Actually there are no tests - at least not in the Pharo image.
>> Maybe Benjamin can comment if there are some tests in the Spec universe for it.
>>
>> I opened an issue:  http://code.google.com/p/pharo/issues/detail?id=7374
>>
>> @Benjamin: can you move "OrderedIdentityDictionary" it out of Spec up to a
>>         more general "Collection-Ordered" category/package for Pharo?
>>         I dont want to interfere with current Spec development and
>>         have no rights to commit to http://ss3.gemstone.com/ss/Spec
>>
>> BTW: Is it really necessary to have an mzc per "Collection-***" category? Dont
>> know about the dependencies - but for Kernel we have only one package (and one
>> for the tests).
>>
>> Thx
>> T.
>>
>>
>>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: OrderedIdentityDictionary in a more general package

Stéphane Ducasse
In reply to this post by Tudor Girba-2
I do not know
but indeed it would be good to have one good one instead of three half

Stef

On Jan 31, 2013, at 9:40 AM, Tudor Girba wrote:

> Does anyone know the difference between:
> - OrderedIdentityDictionary from Spec and
> - OrderPreservingDictionary from http://www.squeaksource.com/OrderPreservingDict
>
> ?
>
> we use the latter in XMLSupport and I think we could probably consolidate.
>
> Doru
>
>
> On Thu, Jan 31, 2013 at 9:38 AM, Esteban Lorenzano <[hidden email]> wrote:
> ... and we need Spec as a project under team Pharo, in sthub :)
>
> On Jan 31, 2013, at 8:28 AM, "Torsten Bergmann" <[hidden email]> wrote:
>
> > Stef wrote:
> >> good idea.
> >> Do you know the test coverage of the class?
> >> Because it would be nice to run hapao on it and write some tests if there are none.
> >
> > Actually there are no tests - at least not in the Pharo image.
> > Maybe Benjamin can comment if there are some tests in the Spec universe for it.
> >
> > I opened an issue:  http://code.google.com/p/pharo/issues/detail?id=7374
> >
> > @Benjamin: can you move "OrderedIdentityDictionary" it out of Spec up to a
> >          more general "Collection-Ordered" category/package for Pharo?
> >          I dont want to interfere with current Spec development and
> >          have no rights to commit to http://ss3.gemstone.com/ss/Spec
> >
> > BTW: Is it really necessary to have an mzc per "Collection-***" category? Dont
> > know about the dependencies - but for Kernel we have only one package (and one
> > for the tests).
> >
> > Thx
> > T.
> >
> >
> >
>
>
>
>
>
> --
> www.tudorgirba.com
>
> "Every thing has its own flow"


Reply | Threaded
Open this post in threaded view
|

Re: OrderedIdentityDictionary in a more general package

Tudor Girba-2
Ok, I created a bug entry:
http://code.google.com/p/pharo/issues/detail?id=7384

Cheers,
Doru


On Jan 31, 2013, at 10:18 PM, Stéphane Ducasse <[hidden email]> wrote:

> I do not know
> but indeed it would be good to have one good one instead of three half
>
> Stef
>
> On Jan 31, 2013, at 9:40 AM, Tudor Girba wrote:
>
>> Does anyone know the difference between:
>> - OrderedIdentityDictionary from Spec and
>> - OrderPreservingDictionary from http://www.squeaksource.com/OrderPreservingDict
>>
>> ?
>>
>> we use the latter in XMLSupport and I think we could probably consolidate.
>>
>> Doru
>>
>>
>> On Thu, Jan 31, 2013 at 9:38 AM, Esteban Lorenzano <[hidden email]> wrote:
>> ... and we need Spec as a project under team Pharo, in sthub :)
>>
>> On Jan 31, 2013, at 8:28 AM, "Torsten Bergmann" <[hidden email]> wrote:
>>
>>> Stef wrote:
>>>> good idea.
>>>> Do you know the test coverage of the class?
>>>> Because it would be nice to run hapao on it and write some tests if there are none.
>>>
>>> Actually there are no tests - at least not in the Pharo image.
>>> Maybe Benjamin can comment if there are some tests in the Spec universe for it.
>>>
>>> I opened an issue:  http://code.google.com/p/pharo/issues/detail?id=7374
>>>
>>> @Benjamin: can you move "OrderedIdentityDictionary" it out of Spec up to a
>>>         more general "Collection-Ordered" category/package for Pharo?
>>>         I dont want to interfere with current Spec development and
>>>         have no rights to commit to http://ss3.gemstone.com/ss/Spec
>>>
>>> BTW: Is it really necessary to have an mzc per "Collection-***" category? Dont
>>> know about the dependencies - but for Kernel we have only one package (and one
>>> for the tests).
>>>
>>> Thx
>>> T.
>>>
>>>
>>>
>>
>>
>>
>>
>>
>> --
>> www.tudorgirba.com
>>
>> "Every thing has its own flow"
>
>

--
www.tudorgirba.com

"No matter how many recipes we know, we still value a chef."