[PATCH 0/2] Misc lint/cosmetic changes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 0/2] Misc lint/cosmetic changes

Holger Freyther
Hi Paolo,

I still have these cosmetic changes in my tree.

cheers
        holger


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/2] lint: Add missing categories to classes in the kernel

Holger Freyther
From: Holger Hans Peter Freyther <[hidden email]>

Object allSubclasses select: [:each | each category isNil]
---
 ChangeLog           |    7 +++++++
 kernel/File.st      |    1 +
 kernel/PkgLoader.st |    4 ++++
 kernel/VFS.st       |    1 +
 4 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 7636c82..5ef795a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,8 +1,15 @@
+2011-09-25  Holger Hans Peter Freyther  <[hidden email]>
+
+ * kernel/File.st: Add a <category: 'text'> to the class.
+ * kernel/PkgLoader.st: Ditto.
+ * kernel/VFS.st: Ditto.
+
 2011-11-28  Paolo Bonzini  <[hidden email]>
 
  * scripts/Package.st: Use #symlinkFrom: to create absolute-path
  symlinks.
 
+
 2011-11-23  Paolo Bonzini  <[hidden email]>
 
  * kernel/AnsiDates.st: Improve #readFrom: to not read ahead too much
diff --git a/kernel/File.st b/kernel/File.st
index 3cc77eb..426a415 100644
--- a/kernel/File.st
+++ b/kernel/File.st
@@ -646,6 +646,7 @@ FilePath subclass: File [
 Namespace current: Kernel [
 
 Object subclass: Stat [
+    <category: 'Streams-Files'>
     
     | stMode stSize stAtime stMtime stCtime |
     stMode [ ^stMode ]
diff --git a/kernel/PkgLoader.st b/kernel/PkgLoader.st
index c3aac39..8a3a429 100644
--- a/kernel/PkgLoader.st
+++ b/kernel/PkgLoader.st
@@ -388,6 +388,8 @@ Namespace current: Kernel [
 PackageContainer subclass: PackageDirectory [
     | baseDirectories baseDirCache |
 
+    <category: 'Language-Packaging'>
+
     PackageContainer class >> on: aFile baseDirectories: aBlock [
  <category: 'accessing'>
  ^(super new)
@@ -1108,6 +1110,8 @@ Namespace current: Kernel [
 Object subclass: Version [
     | major minor patch |
 
+    <category: 'Language-Packaging'>
+
     Version class >> fromString: aString [
  <category: 'instance creation'>
 
diff --git a/kernel/VFS.st b/kernel/VFS.st
index 62b8d97..75e214d 100644
--- a/kernel/VFS.st
+++ b/kernel/VFS.st
@@ -347,6 +347,7 @@ virtual files that refer to a real file on disk.'>
 Namespace current: Kernel [
 
 VFS.FileWrapper subclass: RecursiveFileWrapper [
+    <category: 'Streams-Files'>
 
      do: aBlock [
  "Same as the wrapped #do:, but reuses the file object for efficiency."
--
1.7.8.2


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

[PATCH 2/2] [dbd-postgres] Put CObject based classes into the private category

Holger Freyther
In reply to this post by Holger Freyther
From: Holger Hans Peter Freyther <[hidden email]>

---
 packages/dbd-postgresql/ChangeLog     |    5 +++++
 packages/dbd-postgresql/Connection.st |    2 ++
 packages/dbd-postgresql/ResultSet.st  |    2 ++
 3 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/packages/dbd-postgresql/ChangeLog b/packages/dbd-postgresql/ChangeLog
index 864b25e..794c1cc 100644
--- a/packages/dbd-postgresql/ChangeLog
+++ b/packages/dbd-postgresql/ChangeLog
@@ -1,3 +1,8 @@
+2011-10-26  Holger Hans Peter Freyther  <[hidden email]>
+
+ * Connection.st: Put PQConnection into 'private'.
+ * ResultSet.st: Put PQResultSet into 'private'.
+
 2011-04-23  Paolo Bonzini  <[hidden email]>
 
  * Connection.st: Remove finalization after closing.
diff --git a/packages/dbd-postgresql/Connection.st b/packages/dbd-postgresql/Connection.st
index 5351be5..129ad57 100644
--- a/packages/dbd-postgresql/Connection.st
+++ b/packages/dbd-postgresql/Connection.st
@@ -167,6 +167,8 @@ Connection subclass: PGConnection [
 
 
 CObject subclass: PQConnection [
+    <category: 'private'>
+
     "Connections"
     PQConnection class >> connect: aString [
         <cCall: 'PQconnectdb' returning: #{PQConnection} args: #(#string)>
diff --git a/packages/dbd-postgresql/ResultSet.st b/packages/dbd-postgresql/ResultSet.st
index 827bec8..0f50f87 100644
--- a/packages/dbd-postgresql/ResultSet.st
+++ b/packages/dbd-postgresql/ResultSet.st
@@ -267,6 +267,8 @@ ResultSet subclass: PGResultSet [
 
 
 CObject subclass: PQResultSet [
+    <category: 'private'>
+
     "Results"
     status [
         <cCall: 'PQresultStatus' returning: #int args: #( #self)>
--
1.7.8.2


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk