[PATCH 1/3] lint: Add missing categories to classes in the kernel

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/3] lint: Add missing categories to classes in the kernel

Holger Hans Peter Freyther-3
Object allSubclasses select: [:each | each category isNil]
---
 ChangeLog           |    7 +++++++
 kernel/File.st      |    1 +
 kernel/PkgLoader.st |    4 ++++
 kernel/VFS.st       |    1 +
 4 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index fd50e12..1d1b40d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-09-25  Holger Hans Peter Freyther  <[hidden email]>
+
+ * kernel/File.st: Add a <category: 'text'> to the class.
+ * kernel/PkgLoader.st: Ditto.
+ * kernel/VFS.st: Ditto.
+
 2012-02-02  Paolo Bonzini  <[hidden email]>
             Gwenael Casaccio  <[hidden email]>
 
@@ -37,6 +43,7 @@
  * scripts/Package.st: Use #symlinkFrom: to create absolute-path
  symlinks.
 
+
 2011-11-23  Paolo Bonzini  <[hidden email]>
 
  * kernel/AnsiDates.st: Improve #readFrom: to not read ahead too much
diff --git a/kernel/File.st b/kernel/File.st
index 3cc77eb..426a415 100644
--- a/kernel/File.st
+++ b/kernel/File.st
@@ -646,6 +646,7 @@ FilePath subclass: File [
 Namespace current: Kernel [
 
 Object subclass: Stat [
+    <category: 'Streams-Files'>
     
     | stMode stSize stAtime stMtime stCtime |
     stMode [ ^stMode ]
diff --git a/kernel/PkgLoader.st b/kernel/PkgLoader.st
index c3aac39..8a3a429 100644
--- a/kernel/PkgLoader.st
+++ b/kernel/PkgLoader.st
@@ -388,6 +388,8 @@ Namespace current: Kernel [
 PackageContainer subclass: PackageDirectory [
     | baseDirectories baseDirCache |
 
+    <category: 'Language-Packaging'>
+
     PackageContainer class >> on: aFile baseDirectories: aBlock [
  <category: 'accessing'>
  ^(super new)
@@ -1108,6 +1110,8 @@ Namespace current: Kernel [
 Object subclass: Version [
     | major minor patch |
 
+    <category: 'Language-Packaging'>
+
     Version class >> fromString: aString [
  <category: 'instance creation'>
 
diff --git a/kernel/VFS.st b/kernel/VFS.st
index 62b8d97..75e214d 100644
--- a/kernel/VFS.st
+++ b/kernel/VFS.st
@@ -347,6 +347,7 @@ virtual files that refer to a real file on disk.'>
 Namespace current: Kernel [
 
 VFS.FileWrapper subclass: RecursiveFileWrapper [
+    <category: 'Streams-Files'>
 
      do: aBlock [
  "Same as the wrapped #do:, but reuses the file object for efficiency."
--
1.7.9.1


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

[PATCH 2/3] [dbd-postgres] Put CObject based classes into the private category

Holger Hans Peter Freyther-3
---
 packages/dbd-postgresql/ChangeLog     |    5 +++++
 packages/dbd-postgresql/Connection.st |    2 ++
 packages/dbd-postgresql/ResultSet.st  |    2 ++
 3 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/packages/dbd-postgresql/ChangeLog b/packages/dbd-postgresql/ChangeLog
index 864b25e..794c1cc 100644
--- a/packages/dbd-postgresql/ChangeLog
+++ b/packages/dbd-postgresql/ChangeLog
@@ -1,3 +1,8 @@
+2011-10-26  Holger Hans Peter Freyther  <[hidden email]>
+
+ * Connection.st: Put PQConnection into 'private'.
+ * ResultSet.st: Put PQResultSet into 'private'.
+
 2011-04-23  Paolo Bonzini  <[hidden email]>
 
  * Connection.st: Remove finalization after closing.
diff --git a/packages/dbd-postgresql/Connection.st b/packages/dbd-postgresql/Connection.st
index 5351be5..129ad57 100644
--- a/packages/dbd-postgresql/Connection.st
+++ b/packages/dbd-postgresql/Connection.st
@@ -167,6 +167,8 @@ Connection subclass: PGConnection [
 
 
 CObject subclass: PQConnection [
+    <category: 'private'>
+
     "Connections"
     PQConnection class >> connect: aString [
         <cCall: 'PQconnectdb' returning: #{PQConnection} args: #(#string)>
diff --git a/packages/dbd-postgresql/ResultSet.st b/packages/dbd-postgresql/ResultSet.st
index 827bec8..0f50f87 100644
--- a/packages/dbd-postgresql/ResultSet.st
+++ b/packages/dbd-postgresql/ResultSet.st
@@ -267,6 +267,8 @@ ResultSet subclass: PGResultSet [
 
 
 CObject subclass: PQResultSet [
+    <category: 'private'>
+
     "Results"
     status [
         <cCall: 'PQresultStatus' returning: #int args: #( #self)>
--
1.7.9.1


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

[PATCH 3/3] package: Scan for new star files after the installation

Holger Hans Peter Freyther-3
In reply to this post by Holger Hans Peter Freyther-3
When installing a new package and trying to run the tests
a PackageNotAvailable exception will be signaled. This is because
the PackageLoader not searchig for new star files. Use the
PackageLoader>>#flush to reset the loadedDate (and root) to force
a full rescan of available packages.
---
 ChangeLog          |    4 ++++
 scripts/Package.st |    3 +++
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 1d1b40d..2359417 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2012-02-02  Holger Hans Peter Freyther  <[hidden email]>
+
+ * scripts/Package.st: Scan for new *.star files.
+
 2011-09-25  Holger Hans Peter Freyther  <[hidden email]>
 
  * kernel/File.st: Add a <category: 'text'> to the class.
diff --git a/scripts/Package.st b/scripts/Package.st
index e5b8dff..10dd92a 100644
--- a/scripts/Package.st
+++ b/scripts/Package.st
@@ -689,6 +689,9 @@ PackageCommand subclass: PkgInstall [
  [ super run ] ensure: [
     tmpDir isNil ifFalse: [ tmpDir all remove ] ].
 
+ PackageLoader
+            flush;
+            refresh.
  (Command dryRun not and: [ self isOption: 'load' ])
     ifTrue: [ ^self loadPackages ].
 
--
1.7.9.1


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk