[PATCH] Bytecode handling and printing refactoring

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Bytecode handling and printing refactoring

Gwenaël Casaccio
Hi,

I've removed the bytecode decoding, dispatching and printing methods from
CompiledCode class. Instead they are moved to they related
BytecodeDispatcher and ByteodePrinter classes. It makes the bytecode
handling code nicer, smaller, reusable and extendable.

Cheers,
Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-Remove-the-bytecode-decoding-dispatching-and-printin.patch (35K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Bytecode handling and printing refactoring

Holger Freyther
On Fri, Dec 13, 2013 at 02:46:19PM +0100, Gwenaël Casaccio wrote:
> Hi,

Hi!

> I've removed the bytecode decoding, dispatching and printing methods from
> CompiledCode class. Instead they are moved to they related
> BytecodeDispatcher and ByteodePrinter classes. It makes the bytecode
> handling code nicer, smaller, reusable and extendable.

good idea. But you seem to create copies of specialSelectorsNumArgs,
bytecodeInfoTable and specialSelectors. Why can't you remove that from
the CompildCode class?



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Bytecode handling and printing refactoring

Gwenaël Casaccio
On 13/12/2013 16:08, Holger Hans Peter Freyther wrote:

> On Fri, Dec 13, 2013 at 02:46:19PM +0100, Gwenaël Casaccio wrote:
>> Hi,
> Hi!
>
>> I've removed the bytecode decoding, dispatching and printing methods from
>> CompiledCode class. Instead they are moved to they related
>> BytecodeDispatcher and ByteodePrinter classes. It makes the bytecode
>> handling code nicer, smaller, reusable and extendable.
> good idea. But you seem to create copies of specialSelectorsNumArgs,
> bytecodeInfoTable and specialSelectors. Why can't you remove that from
> the CompildCode class?
>
>
Done.

Gwen


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-Remove-the-bytecode-decoding-dispatching-and-printin.patch (35K) Download Attachment