[PATCH] Comment fix in kernel/Integer.st

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Comment fix in kernel/Integer.st

Holger Freyther
Hi All,

while implementing a Color class for the GRGstColorTest I was
looking at the Number and Integer class on how to create a string from a
given Number and while reading I saw that most comments refer to the
wrong base or parameter.

This patch attempts to correct it, I'm aware that this is mostly cosmetic so
thank you for taking the time to review.

z.

PS: I assume/plan to do more work on GST and I hopefully will touch the
kernel/ directory more often, shall I sent another mail to fsf-records to
request get the paperwork started?

--

From 78d5b1d2f3b402edafd0f5c9054c148c5b035605 Mon Sep 17 00:00:00 2001
From: Holger Hans Peter Freyther <[hidden email]>
Date: Thu, 25 Mar 2010 13:42:57 +0100
Subject: [PATCH] Refer to the right base or the right parameter in the selector

2010-03-25  Holger Hans Peter Freyther  <[hidden email]>

        * kernel/Integer.st: Refer to the right parameter of the selectors.
---
 ChangeLog         |    4 ++++
 kernel/Integer.st |   12 ++++++------
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 05c5de4..b9497be 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2010-03-25  Holger Hans Peter Freyther  <[hidden email]>
+
+ * kernel/Integer.st: Refer to the right parameter of the selectors.
+
 2010-03-03  Gwenael Casaccio  <[hidden email]>
 
  * kernel/ContextPart.st: Fix thinko in #debuggerClass.
diff --git a/kernel/Integer.st b/kernel/Integer.st
index 50cdfb3..f4ce17c 100644
--- a/kernel/Integer.st
+++ b/kernel/Integer.st
@@ -7,7 +7,7 @@
 
 "======================================================================
 |
-| Copyright 1988,92,94,95,99,2000,2001,2002,2003,2005,2006,2008,2009
+| Copyright 1988,92,94,95,99,2000,2001,2002,2003,2005,2006,2008,2009,2010
 | Free Software Foundation, Inc.
 | Written by Steve Byrne.
 |
@@ -482,7 +482,7 @@ efficiency.'>
     ]
 
     radix: baseInteger [
- "Return the base b representation of the receiver, with BBr in
+ "Return the base baseInteger representation of the receiver, with BBr in
  front of it.  This method is deprecated, use #printStringRadix:
  instead."
 
@@ -491,7 +491,7 @@ efficiency.'>
     ]
 
     printStringRadix: baseInteger [
- "Return the base b representation of the receiver, with BBr in
+ "Return the base baseInteger representation of the receiver, with BBr in
  front of it"
 
  <category: 'printing'>
@@ -522,7 +522,7 @@ efficiency.'>
     ]
 
     printPaddedWith: padding to: size base: baseInteger [
- "Return the base 10 representation of the receiver, padded if
+ "Return the base baseInteger representation of the receiver, padded if
  necessary to size characters with copies of padding."
 
  <category: 'printing'>
@@ -548,7 +548,7 @@ efficiency.'>
     ]
 
     printPaddedWith: padding to: size base: baseInteger [
- "Return the base b representation of the receiver, padded if
+ "Return the base baseInteger representation of the receiver, padded if
  necessary to size characters with copies of padding."
 
  <category: 'printing'>
@@ -570,7 +570,7 @@ efficiency.'>
     ]
 
     printString: baseInteger [
- "Return the base b representation of the receiver"
+ "Return the base baseInteger representation of the receiver"
 
  <category: 'printing'>
  | num string |
--
1.7.0



_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Comment fix in kernel/Integer.st

Paolo Bonzini-2
On 03/26/2010 01:09 PM, Holger Hans Peter Freyther wrote:
> Hi All,
>
> while implementing a Color class for the GRGstColorTest I was
> looking at the Number and Integer class on how to create a string from a
> given Number and while reading I saw that most comments refer to the
> wrong base or parameter.
>
> This patch attempts to correct it, I'm aware that this is mostly cosmetic so
> thank you for taking the time to review.

Applied, thanks.

> PS: I assume/plan to do more work on GST and I hopefully will touch the
> kernel/ directory more often, shall I sent another mail to fsf-records to
> request get the paperwork started?

I'll send you the info offlist.

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk