Smalltalk › Gnu

[PATCH] Make Process>>queueInterrupt: thread safe

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Gwenaël Casaccio

[PATCH] Make Process>>queueInterrupt: thread safe

Hi,

The current implementation is not thread safe, when I'm
inside Process>>queueInterrupt: the state of the process
can change. I've added a simple guard to make it safer.

Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-kernel-Make-Process-queueInterrupt-atomic.patch (2K) Download Attachment

Paolo Bonzini-2

Re: [PATCH] Make Process>>queueInterrupt: thread safe

Il 30/03/2014 23:28, Gwenaël Casaccio ha scritto:

> Hi,
>
> The current implementation is not thread safe, when I'm
> inside Process>>queueInterrupt: the state of the process
> can change. I've added a simple guard to make it safer.
>
> Gwen
>
>
>
> _______________________________________________
> help-smalltalk mailing list
> [hidden email]
> https://lists.gnu.org/mailman/listinfo/help-smalltalk
>

Ok!

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

Holger Freyther

Re: [PATCH] Make Process>>queueInterrupt: thread safe

In reply to this post by Gwenaël Casaccio

On Sun, Mar 30, 2014 at 11:28:52PM +0200, Gwenaël Casaccio wrote:

Dear Gwenaël,

> The current implementation is not thread safe, when I'm
> inside Process>>queueInterrupt: the state of the process
> can change. I've added a simple guard to make it safer.

please put this and other context into the commit message. E.g.
how did you find the issue? Was it through review? Did something
fail?

The formatting before and after is quite odd in this method. It
is mixing tabs/spaces beyond the usual.

cheers
holger

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk