[PATCH] Print the filename of the to be loaded .star file

Hi,

while doing the SUnit changes. I have used gst-package --test
packages.xml inside the SUnit subdirectory. One thing that cost me
sometime was that some other SUnit.star was used. So this patch right
now is just printing the .star file that is going to be used, I'm also
working on a patch to inject the right directory into the baseDirectories.

regards
  holger

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

On Sat, Apr 24, 2010 at 09:23, Holger Hans Peter Freyther
<[hidden email]> wrote:
> Hi,
>
> while doing the SUnit changes. I have used gst-package --test
> packages.xml inside the SUnit subdirectory. One thing that cost me
> sometime was that some other SUnit.star was used. So this patch right
> now is just printing the .star file that is going to be used

Does it work for "fake" packages that are declared in packages.xml
(iirc two of these are Regex or MD5)?

> I'm also
> working on a patch to inject the right directory into the baseDirectories.

Makes sense, thanks!

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

On 04/24/2010 09:02 PM, Paolo Bonzini wrote:
No. it does not. Let me try address that. I ran make check before
posting the patch, this means we have no tests for Regexp and MD5
packages, do we care to fix that?

holger


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

Regexp is tested in strings.st, MD5 is just a synonym for Digest which
is tested.

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

On 04/24/2010 09:02 PM, Paolo Bonzini wrote:

> Does it work for "fake" packages that are declared in packages.xml
> (iirc two of these are Regex or MD5)?

I tried various ways. E.g. using (PackageLoader packageAt: package)
fullPathOf: 'package.xml' but that didn't really work for the MD5
package either (it did some times). I have opted for adding a #describe
to Package and one to the StartPackage too. Is that any good?


>
>> I'm also
>> working on a patch to inject the right directory into the baseDirectories.
>
> Makes sense, thanks!

I still have some problems with the scripts/Package.st to fully
understand how it is handling the --test... so this takes some more time.




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

On 04/27/2010 07:49 AM, Holger Hans Peter Freyther wrote:
> On 04/24/2010 09:02 PM, Paolo Bonzini wrote:
>
>> Does it work for "fake" packages that are declared in packages.xml
>> (iirc two of these are Regex or MD5)?
>
> I tried various ways. E.g. using (PackageLoader packageAt: package)
> fullPathOf: 'package.xml' but that didn't really work for the MD5
> package either (it did some times). I have opted for adding a #describe
> to Package and one to the StartPackage too. Is that any good?

Definitely better.  I'll apply it and then think about refactoring it a bit.

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk