Smalltalk › Gnu

[PATCH] Process>>priority:

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 4 messages Options
Gwenaël Casaccio
Reply | Threaded
Open this post in threaded view
♦
♦
|

[PATCH] Process>>priority:

Gwenaël Casaccio
Hi,

I've fixed Process>>#priority: it checks if the process is ready (with
the new priority)
but it must used the old priority.

Gwen


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0003-Fix-Process-priority-checks-if-myList-is-the-process.patch (1K) Download Attachment
Paolo Bonzini-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [PATCH] Process>>priority:

Paolo Bonzini-2
Il 24/03/2014 15:25, Gwenaël Casaccio ha scritto:
> Hi,
>
> I've fixed Process>>#priority: it checks if the process is ready (with
> the new priority) but it must used the old priority.

The patch is correct.  Is there a testcase?  It should cover both
running and ready-to-run processes.  Thanks!

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Gwenaël Casaccio
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [PATCH] Process>>priority:

Gwenaël Casaccio
On 25/03/2014 16:19, Paolo Bonzini wrote:

> Il 24/03/2014 15:25, Gwenaël Casaccio ha scritto:
>> Hi,
>>
>> I've fixed Process>>#priority: it checks if the process is ready (with
>> the new priority) but it must used the old priority.
>
> The patch is correct.  Is there a testcase?  It should cover both
> running and ready-to-run processes.  Thanks!
>
> Paolo

Yes in the big patch there are test cases

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Paolo Bonzini-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [PATCH] Process>>priority:

Paolo Bonzini-2
Il 25/03/2014 16:22, Gwenaël Casaccio ha scritto:

>>>
>>> I've fixed Process>>#priority: it checks if the process is ready (with
>>> the new priority) but it must used the old priority.
>>
>> The patch is correct.  Is there a testcase?  It should cover both
>> running and ready-to-run processes.  Thanks!
>>
>> Paolo
>
> Yes in the big patch there are test cases

And what about the small patch? :)

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Free forum by Nabble Edit this page