[PATCH] Reenable generational GC :-(

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Reenable generational GC :-(

Paolo Bonzini-2
I found out that I disabled generational GC by mistake while preparing
3.0 (and debugging a failure on ia64).  Here is a patch that reenables
it.  Thomas, could you please test it on ia64?

On some testcases, it speeds up by a factor of 3-4.  In fact, the bad
performance on the shootout and on some stuff I have at work, was what
made me curious.

Thanks!

Paolo

diff --git a/libgst/gstpriv.h b/libgst/gstpriv.h
index 75120d2..9133277 100644
--- a/libgst/gstpriv.h
+++ b/libgst/gstpriv.h
@@ -106,6 +106,10 @@
  #include <inttypes.h>
  #endif

+#ifdef HAVE_SIGSEGV_H
+#include "sigsegv.h"
+#endif
+
  #include "gst.h"

  /* Convenience macros to test the versions of GCC.  Note - they won't
diff --git a/libgst/oop.c b/libgst/oop.c
index fedf427..3eb1fb7 100644
--- a/libgst/oop.c
+++ b/libgst/oop.c
@@ -54,10 +54,6 @@

  #include "gstpriv.h"

-#ifdef HAVE_SIGSEGV_H
-#include "sigsegv.h"
-#endif
-
  #define        K               1024
  #define INIT_NUM_INCUBATOR_OOPS   50
  #define INCUBATOR_CHUNK_SIZE     20


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Reenable generational GC :-(

Thomas Girard
Hello Paolo,

On Mon, Feb 11, 2008 at 12:06:00PM +0100, Paolo Bonzini wrote:
> I found out that I disabled generational GC by mistake while preparing
> 3.0 (and debugging a failure on ia64).  Here is a patch that reenables
> it.  Thomas, could you please test it on ia64?

Yes, I'll try this ASAP (hopefully tonight) and report on this list.

Regards,

Thomas


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Reenable generational GC :-(

Thomas Girard
Hello,

> On Mon, Feb 11, 2008 at 12:06:00PM +0100, Paolo Bonzini wrote:
> > I found out that I disabled generational GC by mistake while preparing
> > 3.0 (and debugging a failure on ia64).  Here is a patch that reenables
> > it.  Thomas, could you please test it on ia64?

I've just tested your patch on top of vanilla GNU Smalltalk 3.0.1.

All ANSI unit tests fail, from 64 to 107. It reminds me of the previous
ia64 problem, where gst was not able to cope with the image generated
for the ANSI tests.

Shouldn't generational gc on ia64 be disabled? (i.e. revert the commit
5e8e83837e44cb84d7ba0a7e5e2f2632746e1159). Do you want me to test on a
fresh git version?

I've uploaded the testuite.dir and config.log to:
  http://thomas.g.girard.free.fr/gst/ia64_testsuite.tar.bz2

Regards,

Thomas






_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Reenable generational GC :-(

Paolo Bonzini-2

> Shouldn't generational gc on ia64 be disabled? (i.e. revert the commit
> 5e8e83837e44cb84d7ba0a7e5e2f2632746e1159). Do you want me to test on a
> fresh git version?

No, that should be good enough.  Thanks!

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk