Smalltalk › Gnu

[PATCH] VisualGST: Migrate to new UI framework

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Gwenaël Casaccio

[PATCH] VisualGST: Migrate to new UI framework

Hi,

Here is the new patch that migrate to new UI framework:
- introduce new UI;
- remove most of the mainWidget calls;
- more rationale in widget initialization;
- less Gtk dependant

Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-Migrate-to-new-UI-framework-first-step-done.patch (341K) Download Attachment

Gwenaël Casaccio

Re: [PATCH] VisualGST: Migrate to new UI framework

On 02/12/2013 11:31, Gwenaël Casaccio wrote:

> Hi,
>
> Here is the new patch that migrate to new UI framework:
> - introduce new UI;
> - remove most of the mainWidget calls;
> - more rationale in widget initialization;
> - less Gtk dependant
>
> Gwen
>

Here is the new version that fixes the DNU.

cheers,
Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-Migrate-to-new-UI-framework-first-step-done.patch (249K) Download Attachment

Holger Freyther

Re: [PATCH] VisualGST: Migrate to new UI framework

On Wed, Dec 04, 2013 at 09:25:58AM +0100, Gwenaël Casaccio wrote:

Dear Gwenaël,

this patch does not apply cleanly against master. Could you please
either send one patch _series_ with all the UI changes or publish
your branch with that?

thanks a lot

> + * Debugger/Extensions.st: Disable the debugger.

why is that necessary?

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

Gwenaël Casaccio

Re: [PATCH] VisualGST: Migrate to new UI framework

On 05/12/2013 10:00, Holger Hans Peter Freyther wrote:

> On Wed, Dec 04, 2013 at 09:25:58AM +0100, Gwenaël Casaccio wrote:
>
> Dear Gwenaël,
>
> this patch does not apply cleanly against master. Could you please
> either send one patch _series_ with all the UI changes or publish
> your branch with that?
>
> thanks a lot
>
>> + * Debugger/Extensions.st: Disable the debugger.
> why is that necessary?

Ok here is the patch with the missing files

The order is the remove_gtk_abstract, migrate_to_new_ui,
migrate_to_new_ui_events, removes_post_initialize

Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-Migrate-the-widgets-to-the-new-events-that-uses-the-.patch (29K) Download Attachment

0001-Migrate-to-new-UI-framework-first-step-done.patch (342K) Download Attachment

0001-Remove-GtkAbstractConcreteWidget-the-class-name-is-u.patch (6K) Download Attachment

0001-Removes-postInitialize-calls-and-makes-widget-initia.patch (20K) Download Attachment

Gwenaël Casaccio

Re: [PATCH] VisualGST: Migrate to new UI framework

On 05/12/2013 10:28, Gwenaël Casaccio wrote:

> On 05/12/2013 10:00, Holger Hans Peter Freyther wrote:
>> On Wed, Dec 04, 2013 at 09:25:58AM +0100, Gwenaël Casaccio wrote:
>>
>> Dear Gwenaël,
>>
>> this patch does not apply cleanly against master. Could you please
>> either send one patch _series_ with all the UI changes or publish
>> your branch with that?
>>
>> thanks a lot
>>
>>> + * Debugger/Extensions.st: Disable the debugger.
>> why is that necessary?
>
> Ok here is the patch with the missing files
>
> The order is the remove_gtk_abstract, migrate_to_new_ui,
> migrate_to_new_ui_events, removes_post_initialize
>
> Gwen
>

Here is another version with the debugger and the transcript
enabled.

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-Remove-GtkAbstractConcreteWidget-the-class-name-is-u.patch (6K) Download Attachment

0002-Migrate-to-new-UI-framework-first-step-done-introduc.patch (341K) Download Attachment

0003-Migrate-the-widgets-to-the-new-events-that-uses-the-.patch (22K) Download Attachment

0004-Removes-postInitialize-calls-and-makes-widget-initia.patch (25K) Download Attachment

Holger Freyther

Re: [PATCH] VisualGST: Migrate to new UI framework

On Thu, Dec 05, 2013 at 03:07:48PM +0100, Gwenaël Casaccio wrote:

Dear Gwenaël,

> Here is another version with the debugger and the transcript
> enabled.

thanks for sending a patchset that is easy to apply. The debugger
still doesn't work though. E.g. the context menu has all items disabled.
E.g. "Inspect Variable" can not be clicked.

My proposal is:

* Merge Widget/Window
* We migrate widgets one by one. This allows you and me to actually
test/use this specific widget that has been converted.

Reasoning:

You had 4-6 tries to get your monster patch right and it has failed. It
is not because you did something bad, but because the complexity for such
a big change is not easy to understand.

have a nice weekend

holger

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

Gwenaël Casaccio

Re: [PATCH] VisualGST: Migrate to new UI framework

On 07/12/2013 16:19, Holger Hans Peter Freyther wrote:

> On Thu, Dec 05, 2013 at 03:07:48PM +0100, Gwenaël Casaccio wrote:
>
> Dear Gwenaël,
>
>
>> Here is another version with the debugger and the transcript
>> enabled.
> thanks for sending a patchset that is easy to apply. The debugger
> still doesn't work though. E.g. the context menu has all items disabled.
> E.g. "Inspect Variable" can not be clicked.
>
> My proposal is:
>
> * Merge Widget/Window
> * We migrate widgets one by one. This allows you and me to actually
> test/use this specific widget that has been converted.
>
>
> Reasoning:
>
> You had 4-6 tries to get your monster patch right and it has failed. It
> is not because you did something bad, but because the complexity for such
> a big change is not easy to understand.
>
>
> have a nice weekend
>
> holger

Hi,

Yes, I'm working on a UI branch and will merge the changes from
master to it. Currently I'm workin on the menu refactoring
mostly done (need to refactor the command pattern a bit).

Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk