[PATCH] build: drop useless AC_SUBST of 'INCLUDES'

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] build: drop useless AC_SUBST of 'INCLUDES'

Stefano Lattarini
* snprintfv/configure.ac: Here.  Not only that substitution was useless,
but it was causing runtime warnings with Automake 1.13, and, since
support for $(INCLUDES) is bound to disappear in Automake 1.14 (in favour
of $(AM_CPPFLAGS)), it will start causing runtime errors with that new
Automake version.

Copyright-paperwork-exempt: yes
Signed-off-by: Stefano Lattarini <[hidden email]>
---
 snprintfv/ChangeLog    | 9 +++++++++
 snprintfv/configure.ac | 1 -
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/snprintfv/ChangeLog b/snprintfv/ChangeLog
index 79716b8..c9bd2ba 100644
--- a/snprintfv/ChangeLog
+++ b/snprintfv/ChangeLog
@@ -1,3 +1,12 @@
+2013-01-11  Stefano Lattarini  <[hidden email]> (tiny change)
+
+ build: drop useless AC_SUBST of 'INCLUDES'
+
+ * configure.ac: Here.  Not only that substitution was useless, but
+ it was causing runtime warnings with Automake 1.13, and, since
+ support for $(INCLUDES) is bound to disappear in Automake 1.14, it
+ will start causing runtime errors with that new Automake version.
+
 2010-09-13  Paolo Bonzini  <[hidden email]>
 
  * configure.ac: Fix cut-and-paste mistake.
diff --git a/snprintfv/configure.ac b/snprintfv/configure.ac
index dbfd4f3..61eaa5c 100644
--- a/snprintfv/configure.ac
+++ b/snprintfv/configure.ac
@@ -343,7 +343,6 @@ LTLIBOBJS=`echo "$LIB@&t@OBJS"|sed 's,\.o ,.lo,g;s,\.o$,.lo,'`
 AC_SUBST(LTLIBOBJS)
 
 AC_SUBST(LIBS)
-AC_SUBST(INCLUDES)
 AC_SUBST(ac_aux_dir)
 
 AC_CONFIG_FILES(Makefile snprintfv/Makefile)
--
1.8.1.rc3.192.g2d0029e


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] build: drop useless AC_SUBST of 'INCLUDES'

Paolo Bonzini-2
Il 11/01/2013 11:28, Stefano Lattarini ha scritto:
> * snprintfv/configure.ac: Here.  Not only that substitution was useless,
> but it was causing runtime warnings with Automake 1.13, and, since
> support for $(INCLUDES) is bound to disappear in Automake 1.14 (in favour
> of $(AM_CPPFLAGS)), it will start causing runtime errors with that new
> Automake version.

I'm sick of these backwards-incompatible changes.  There's tons of
non-GNU packages that you won't be able to update, not to mention
blocking enterprise distributions from shipping newer versions of the
autotools.

Do you really want to reopen the wounds of Autoconf 2.50?

Paolo

> Copyright-paperwork-exempt: yes
> Signed-off-by: Stefano Lattarini <[hidden email]>


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk