Quantcast

[PATCH] dbd-mysql: Fix breakage from Behavior>>#new changes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] dbd-mysql: Fix breakage from Behavior>>#new changes

Holger Freyther
In ac2ada57d5a23eaaf7c8b913ca2a710bd7c53782 I had changed
>>#new to always call >>#initialize. When converting the
code I did not update the MySQLPacket class that assumes
that a stream has been set before initialize is being called.
Use >>#basicNew to avoid the early call to >>#initialize.
This has been found and analyzed by Mark Bratcher.

2015-09-08  Holger Hans Peter Freyther  <[hidden email]>

        * Connection.st: Use >>#basicNew in MySQLPacket class >> #on:.
---
 packages/dbd-mysql/ChangeLog     | 4 ++++
 packages/dbd-mysql/Connection.st | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/packages/dbd-mysql/ChangeLog b/packages/dbd-mysql/ChangeLog
index e720304..bf0ab38 100644
--- a/packages/dbd-mysql/ChangeLog
+++ b/packages/dbd-mysql/ChangeLog
@@ -1,3 +1,7 @@
+2015-09-08  Holger Hans Peter Freyther  <[hidden email]>
+
+ * Connection.st: Use >>#basicNew in MySQLPacket class >> #on:.
+
 2013-08-25  Holger Hans Peter Freyther  <[hidden email]>
 
  * Connection.st: Remove >>#commitTransaction and
diff --git a/packages/dbd-mysql/Connection.st b/packages/dbd-mysql/Connection.st
index b97dc89..ef5ac65 100644
--- a/packages/dbd-mysql/Connection.st
+++ b/packages/dbd-mysql/Connection.st
@@ -237,7 +237,7 @@ Object subclass: MySQLPacket [
 
     MySQLPacket class >> on: aStream [
  <category: 'instance creation'>
- ^(self new)
+ ^(self basicNew)
     stream: aStream;
     initialize
     ]
--
2.3.5


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Loading...