[PATCH] fix compatibility issue with emacs-24.2

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] fix compatibility issue with emacs-24.2

Jochen Schmitt
Hello,

I have got an bug report that the variable inhibit-first-line-modes-regexps
was renamed into inhibit-local-variables-regexps since emacs-24.2.

Therefore I have create a patch which is attached on thiw mail.

Best Regards:

Jochen Schmitt


diff -up smalltalk-3.2.5/smalltalk-mode-init.el.in.emx smalltalk-3.2.5/smalltalk-mode-init.el.in
--- smalltalk-3.2.5/smalltalk-mode-init.el.in.emx 2013-05-29 17:27:14.684817180 +0200
+++ smalltalk-3.2.5/smalltalk-mode-init.el.in 2013-05-29 17:31:02.714077525 +0200
@@ -13,7 +13,7 @@
 
 (push '("\\.st\\'" . smalltalk-mode) auto-mode-alist)
 
-(push "\\.star\\'" inhibit-first-line-modes-regexps)
+(push "\\.star\\'" inhibit-local-variables-regexps)
 
 (autoload 'smalltalk-mode "@lispdir@/smalltalk-mode.elc" "" t)
 @WITH_EMACS_COMINT_TRUE@(autoload 'gst "@lispdir@/gst-mode.elc" "" t)

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] fix compatibility issue with emacs-24.2

Paolo Bonzini-2
Il 29/05/2013 19:05, Jochen Schmitt ha scritto:
> Hello,
>
> I have got an bug report that the variable inhibit-first-line-modes-regexps
> was renamed into inhibit-local-variables-regexps since emacs-24.2.

Can you give a pointer to the bug report?

> Therefore I have create a patch which is attached on thiw mail.
>
> Best Regards:
>
> Jochen Schmitt
>
>
> diff -up smalltalk-3.2.5/smalltalk-mode-init.el.in.emx smalltalk-3.2.5/smalltalk-mode-init.el.in
> --- smalltalk-3.2.5/smalltalk-mode-init.el.in.emx 2013-05-29 17:27:14.684817180 +0200
> +++ smalltalk-3.2.5/smalltalk-mode-init.el.in 2013-05-29 17:31:02.714077525 +0200
> @@ -13,7 +13,7 @@
>  
>  (push '("\\.st\\'" . smalltalk-mode) auto-mode-alist)
>  
> -(push "\\.star\\'" inhibit-first-line-modes-regexps)
> +(push "\\.star\\'" inhibit-local-variables-regexps)

We should check which is available and try the right one.

>  (autoload 'smalltalk-mode "@lispdir@/smalltalk-mode.elc" "" t)
>  @WITH_EMACS_COMINT_TRUE@(autoload 'gst "@lispdir@/gst-mode.elc" "" t)
>
> _______________________________________________
> help-smalltalk mailing list
> [hidden email]
> https://lists.gnu.org/mailman/listinfo/help-smalltalk
>


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] fix compatibility issue with emacs-24.2

Jochen Schmitt
On Wed, May 29, 2013 at 11:21:49PM +0200, Paolo Bonzini wrote:

> We should check which is available and try the right one.

Ok, here a more enhanced version of the patch attached on this mail.

Best Regards:

Jochen Schmitt

diff -up smalltalk-3.2.5/smalltalk-mode-init.el.in.emx smalltalk-3.2.5/smalltalk-mode-init.el.in
--- smalltalk-3.2.5/smalltalk-mode-init.el.in.emx 2013-03-23 20:56:26.000000000 +0100
+++ smalltalk-3.2.5/smalltalk-mode-init.el.in 2013-05-31 15:32:37.416661184 +0200
@@ -13,7 +13,9 @@
 
 (push '("\\.st\\'" . smalltalk-mode) auto-mode-alist)
 
-(push "\\.star\\'" inhibit-first-line-modes-regexps)
+(if (boundp 'inhibit-local-variables-regexps)
+    (push "\\.star\\'" inhibit-local-variables-regexps)
+    (push "\\.star\\'" inhibit-first-line-modes-regexp))
 
 (autoload 'smalltalk-mode "@lispdir@/smalltalk-mode.elc" "" t)
 @WITH_EMACS_COMINT_TRUE@(autoload 'gst "@lispdir@/gst-mode.elc" "" t)

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] fix compatibility issue with emacs-24.2

Holger Freyther
On Fri, May 31, 2013 at 03:42:47PM +0200, Jochen Schmitt wrote:
> On Wed, May 29, 2013 at 11:21:49PM +0200, Paolo Bonzini wrote:
>
> > We should check which is available and try the right one.
>
> Ok, here a more enhanced version of the patch attached on this mail.

I have staged this change and sending it through travis-ci right
now. So it will show up in master soon.

thanks
        holger

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk