Smalltalk › Gnu

[PATCH] update cygwin path conversion api

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

In-Ho Yi

[PATCH] update cygwin path conversion api

Hi,

There was reference to old cygwin api that was failing the build.

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-update-cygwin-path-conversion-api.patch (1K) Download Attachment

Holger Freyther

Re: [PATCH] update cygwin path conversion api

On Wed, Apr 09, 2014 at 02:27:05AM -0700, In-Ho Yi wrote:
> Hi,
>
> There was reference to old cygwin api that was failing the build.

Hi!

thanks for the patch. Could you use git config to set your email
address to your gmail address for future commits?

Could you please create a patch to update the comment around the
code. E.g. it refers to the old method and now the new one actually
offers a return code we could check?

Would you be interested in updating that as well?

thanks
holger

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

In-Ho Yi

Re: [PATCH] update cygwin path conversion api

Hi,

Thanks for the response. I have amended patch to include proper email.
Also, I found that with new api, extra error check is unnecessary,
hence made the further change.

On 10 April 2014 07:19, Holger Hans Peter Freyther <[hidden email]> wrote:

> On Wed, Apr 09, 2014 at 02:27:05AM -0700, In-Ho Yi wrote:
>> Hi,
>>
>> There was reference to old cygwin api that was failing the build.
>
> Hi!
>
> thanks for the patch. Could you use git config to set your email
> address to your gmail address for future commits?
>
> Could you please create a patch to update the comment around the
> code. E.g. it refers to the old method and now the new one actually
> offers a return code we could check?
>
> Would you be interested in updating that as well?
>
> thanks
> holger

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-update-cygwin-path-conversion-api-which-now-gives-er.patch (1K) Download Attachment

Holger Freyther

Re: [PATCH] update cygwin path conversion api

On Fri, Apr 11, 2014 at 01:04:11AM -0700, In-Ho Yi wrote:
> Hi,
>
> Thanks for the response. I have amended patch to include proper email.
> Also, I found that with new api, extra error check is unnecessary,
> hence made the further change.

hi, it looks like you sent the old patch? I have included the old
one already so please rebase against master.

holger

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

In-Ho Yi

Re: [PATCH] update cygwin path conversion api

Hi, sorry didn't realize the patch was already in! I have updated my
new patch accordingly.

On 11 April 2014 07:37, Holger Hans Peter Freyther <[hidden email]> wrote:

> On Fri, Apr 11, 2014 at 01:04:11AM -0700, In-Ho Yi wrote:
>> Hi,
>>
>> Thanks for the response. I have amended patch to include proper email.
>> Also, I found that with new api, extra error check is unnecessary,
>> hence made the further change.
>
> hi, it looks like you sent the old patch? I have included the old
> one already so please rebase against master.
>
> holger
>

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-remove-unnecessary-length-check.-cygwin-path-convers.patch (2K) Download Attachment

Holger Freyther

Re: [PATCH] update cygwin path conversion api

On Sat, Apr 12, 2014 at 08:34:49AM -0700, In-Ho Yi wrote:
> Hi, sorry didn't realize the patch was already in! I have updated my
> new patch accordingly.

thanks. applied and pushed.

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk