[PATCH] visualgst: Fix inspecting variables of the current method context

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] visualgst: Fix inspecting variables of the current method context

Holger Freyther
In the debugger when using the context menu to inspect a local variable
lead to inspecting a string. Change this by changing the returned value
in >>#selectedValue: to be the object and not the display string. This
has been manually tested for the GtkStackInspectorView but not for the
GtkContextInspectorView.

2013-12-20  Holger Hans Peter Freyther  <[hidden email]>

        * Debugger/GtkStackInspectorView.st: Return the object and not a string.
        * Inspector/GtkContextInspectorView.st: Return the object and not a string.
---
 packages/visualgst/ChangeLog                            | 5 +++++
 packages/visualgst/Debugger/GtkStackInspectorView.st    | 4 ++--
 packages/visualgst/Inspector/GtkContextInspectorView.st | 4 ++--
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/packages/visualgst/ChangeLog b/packages/visualgst/ChangeLog
index 61af180..e9ffe40 100644
--- a/packages/visualgst/ChangeLog
+++ b/packages/visualgst/ChangeLog
@@ -1,3 +1,8 @@
+2013-12-20  Holger Hans Peter Freyther  <[hidden email]>
+
+ * Debugger/GtkStackInspectorView.st: Return the object and not a string.
+ * Inspector/GtkContextInspectorView.st: Return the object and not a string.
+
 2013-12-02  Gwenael Casaccio  <[hidden email]>
 
  * GtkConcreteWidget.st: Object is the superclass.
diff --git a/packages/visualgst/Debugger/GtkStackInspectorView.st b/packages/visualgst/Debugger/GtkStackInspectorView.st
index 19355ab..f27255e 100644
--- a/packages/visualgst/Debugger/GtkStackInspectorView.st
+++ b/packages/visualgst/Debugger/GtkStackInspectorView.st
@@ -72,8 +72,8 @@ GtkConcreteWidget subclass: GtkStackInspectorView [
  <category: 'item selection'>
 
         aString = 'thisContext' ifTrue: [ ^ self object ].
-        (args includes: aString) ifTrue: [ ^ (self object at: (self object method arguments indexOf: aString asSymbol)) displayString ].
-        ^ (self object at: self object numArgs + (self object method temporaries indexOf: aString asSymbol)) displayString
+        (args includes: aString) ifTrue: [ ^ self object at: (self object method arguments indexOf: aString asSymbol) ].
+        ^ self object at: self object numArgs + (self object method temporaries indexOf: aString asSymbol)
     ]
 
     canDive [
diff --git a/packages/visualgst/Inspector/GtkContextInspectorView.st b/packages/visualgst/Inspector/GtkContextInspectorView.st
index 46ab341..3ba3f35 100644
--- a/packages/visualgst/Inspector/GtkContextInspectorView.st
+++ b/packages/visualgst/Inspector/GtkContextInspectorView.st
@@ -51,8 +51,8 @@ GtkObjectInspectorView subclass: GtkContextInspectorView [
         <category: 'events'>
 
         ((args includes: aString) not and: [ (temps includes: aString) not ]) ifTrue: [ ^ super selectedValue: aString ].
-        (args includes: aString) ifTrue: [ ^ (self object at: (self object method arguments indexOf: aString asSymbol)) displayString ].
-        ^ (self object at: self object numArgs + (self object method temporaries indexOf: aString asSymbol)) displayString.
+        (args includes: aString) ifTrue: [ ^ self object at: (self object method arguments indexOf: aString asSymbol) ].
+        ^ self object at: self object numArgs + (self object method temporaries indexOf: aString asSymbol).
     ]
 ]
 
--
1.8.5.1


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk