Smalltalk › Pharo › Pharo Smalltalk Developers

PLZ fix it for Pharo8...

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

CdAB63

PLZ fix it for Pharo8...

In the last builds of Pharo8, CatalogBrowser comes with an easily fixable glitch... Please could someone take a look? My humble suggestion is:

===============================================================

createRepositoryURLtoNameMappings
    "Return a mapping between repositories URLs and their user names"

    <script: 'self createRepositoryURLtoNameMappings inspect'>
    |repos|
    repos := Dictionary new.
    3 to: SystemVersion current major do: [:v |
        repos
            at: ('http://smalltalkhub.com/mc/Pharo/MetaRepoForPharo{1}0/main' format: (Array with: v))
            put: ('Pharo{1}.0' format: (Array with: v)].
    repos at: 'http://www.squeaksource.com/MetacelloRepository' put: 'Unsorted'.
    ^repos

================================================================

Best wishes,

Casimiro Barreto

signature.asc (673 bytes) Download Attachment

ducasse

Re: PLZ fix it for Pharo8...

Thanks Casimiro

Why don’t you open a bug entry on github.com?

On 16 Oct 2019, at 14:53, Casimiro de Almeida Barreto <[hidden email]> wrote:

In the last builds of Pharo8, CatalogBrowser comes with an easily fixable glitch... Please could someone take a look? My humble suggestion is:
===============================================================

createRepositoryURLtoNameMappings
    "Return a mapping between repositories URLs and their user names"

    <script: 'self createRepositoryURLtoNameMappings inspect'>
    |repos|
    repos := Dictionary new.
    3 to: SystemVersion current major do: [:v |
        repos
            at: ('http://smalltalkhub.com/mc/Pharo/MetaRepoForPharo{1}0/main' format: (Array with: v))
            put: ('Pharo{1}.0' format: (Array with: v)].
    repos at: 'http://www.squeaksource.com/MetacelloRepository' put: 'Unsorted'.
    ^repos
================================================================

Best wishes,

Casimiro Barreto

Ben Coman

Re: PLZ fix it for Pharo8...

Casimiro,

I tested your change and it works well.

btw, for such a simple change, you don't even need to connect your Pharo image to github.

Just fork the repo and make your edit directly with github's text editor at your equal location location to this...

https://github.com/pharo-project/pharo/blob/39a50d3d/src/Tool-Catalog/CatalogProject.class.st#L40-L54

Then submit that as a PR to leave your mark on Pharo (with a good PR description a bug entry not required).

Could you give it a go? :) :)

cheers -ben

On Wed, 16 Oct 2019 at 22:47, ducasse <[hidden email]> wrote:

Thanks Casimiro

Why don’t you open a bug entry on github.com?

On 16 Oct 2019, at 14:53, Casimiro de Almeida Barreto <[hidden email]> wrote:

In the last builds of Pharo8, CatalogBrowser comes with an easily fixable glitch... Please could someone take a look? My humble suggestion is:
===============================================================

createRepositoryURLtoNameMappings
    "Return a mapping between repositories URLs and their user names"

    <script: 'self createRepositoryURLtoNameMappings inspect'>
    |repos|
    repos := Dictionary new.
    3 to: SystemVersion current major do: [:v |
        repos
            at: ('http://smalltalkhub.com/mc/Pharo/MetaRepoForPharo{1}0/main' format: (Array with: v))
            put: ('Pharo{1}.0' format: (Array with: v)].
    repos at: 'http://www.squeaksource.com/MetacelloRepository' put: 'Unsorted'.
    ^repos
================================================================

Best wishes,

Casimiro Barreto