Here's the proposal: take the current scheme:
SiteIdentifier class>>#ip:port:host:
SiteIdentifier>>#setIp:port:host:
and rename/reorder these things to:
SiteIdentifier class>>#hostname:address:port:
SiteIdentifier>>#setHostname:address:port:
Then, we rename the instance vars to match the new protocol (ip becomes
address, host becomes hostname). We also remove the
Site>>#host:ip:port: message, since it's not sent by anybody and its
behavior is redundant.
Benefits: clarity. I also like the use of the setFoo:bar:baz: pattern
for an initialization method. This follows the pattern described in
Beck's "Best Practice Patterns" book.
The following tests will have to change:
HTTPRequestTest>>#testURIStream
SiteIdentifierTest (all methods)
SiteTest>>#setUp
The changes to the tests should be obvious. We would also probably want
to change the sites.cnf file in our distribution.
Thoughts?
Ken Treis
[hidden email]
Locked
