PRPath>>isValidName: and extended characters

> I like to use unicode characters in pier url paths. Nowadays encodeForHTTP changed in pharo and squeak to do utf-8 url-safe-encoding by default. I updated the implementation in the gemstone squeak package to do the same. So principal there is no need to be very restrictive in pier names.
>
> I did some tests with changing the implementation to
>
> PRPath>>isValidName: aString
>        ^ aString isNil not
>                and: [ aString isEmpty not
>                and: [ aString ~= self parentStructure
>                and: [ aString ~= self currentStructure
>                and: [ aString allSatisfy: [ :char | char isAlphaNumeric or: [self validCharacters includes: char] ] ] ] ] ]
>
> and it works well. PRPath>>validCharacters: could be reduced to just contain '-._'. Ok, the naming needs probably to be adjusted. But I think it is worth the change.
>
> What do you think?
>
> Norbert
>
>
> _______________________________________________
> Magritte, Pier and Related Tools ...
> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>

> Thanks Lukas,
>
> but now the suggestName: is reduced. Probably it is better to implement it like in the attached changeset.
>
> thanks,
>
> Norbert
>
>
>
>
> On 09.10.2010, at 11:35, Lukas Renggli wrote:
>
>> I integrated this with
>>
>> Name: Pier-Model-lr.393
>> Author: lr
>> Time: 9 October 2010, 11:34:48 am
>> UUID: e26211c8-e382-44d8-bb18-7222fd290a32
>> Ancestors: Pier-Model-lr.392
>>
>> On 8 October 2010 22:50, Norbert Hartl <[hidden email]> wrote:
>>> I like to use unicode characters in pier url paths. Nowadays encodeForHTTP changed in pharo and squeak to do utf-8 url-safe-encoding by default. I updated the implementation in the gemstone squeak package to do the same. So principal there is no need to be very restrictive in pier names.
>>>
>>> I did some tests with changing the implementation to
>>>
>>> PRPath>>isValidName: aString
>>>        ^ aString isNil not
>>>                and: [ aString isEmpty not
>>>                and: [ aString ~= self parentStructure
>>>                and: [ aString ~= self currentStructure
>>>                and: [ aString allSatisfy: [ :char | char isAlphaNumeric or: [self validCharacters includes: char] ] ] ] ] ]
>>>
>>> and it works well. PRPath>>validCharacters: could be reduced to just contain '-._'. Ok, the naming needs probably to be adjusted. But I think it is worth the change.
>>>
>>> What do you think?
>>>
>>> Norbert
>>>
>>>
>>> _______________________________________________
>>> Magritte, Pier and Related Tools ...
>>> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>>>
>>
>>
>>
>> --
>> Lukas Renggli
>> www.lukas-renggli.ch
>>
>> _______________________________________________
>> Magritte, Pier and Related Tools ...
>> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>
>
> _______________________________________________
> Magritte, Pier and Related Tools ...
> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>