Package browser bug?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Package browser bug?

Bill Schwab-2
Blair,

This is one of those "it's worse to say nothing" kinds of reports.

I've had a couple of problems with the package browser giving a walkback
when trying to install a package, and it seemed to occur only when no
package was selected.  Does that sound familar?  I just tied it again on a
different machine wihout incident.

Based on the walkback below, one could simply lazily initialize the
collection, or add a nil test, though might be simply treating the symptom.

Have a good one,

Bill


===============
Unhandled exception - a MessageNotUnderstood('UndefinedObject does not
understand #isEmpty')

UndefinedObject(Object)>>doesNotUnderstand:
PackagePrerequisites>>onPrerequisitesReset
PackagePrerequisites>>onPrerequisitesReset:
EventMessageSend>>forwardTo:withArguments:
EventMessageSend(MessageSendAbstract)>>valueWithArguments:
[] in EventMessageSequence(MessageSequenceAbstract)>>valueWithArguments:
EventMessageSequence>>messagesDo:
EventMessageSequence(MessageSequenceAbstract)>>valueWithArguments:
EventsCollection>>triggerEvent:with:
PackageManager(Object)>>trigger:with:
PackageManager>>onPrerequisitesReset:
EventMessageSend>>forwardTo:withArguments:
EventMessageSend>>value
[] in EventMessageSequence(MessageSequenceAbstract)>>value
EventMessageSequence>>messagesDo:
EventMessageSequence(MessageSequenceAbstract)>>value
EventsCollection>>triggerEvent:
Package(Object)>>trigger:
Package>>resetPrerequisites
[] in PackageManager>>resetPrerequisites

--
Wilhelm K. Schwab, Ph.D.
[hidden email]


Reply | Threaded
Open this post in threaded view
|

Re: Package browser bug?

Udo Schneider
Bill,

I saw this behaviour as well. As you mentioned adding #isEmpty to
UndefinedObject helped here (it's in my default "patches" for a new
image now).

But I never found out, that it's related to the fact whether a package
is selected or not. I have to try it.

CU,

Udo


Bill Schwab wrote:

> Blair,
>
> This is one of those "it's worse to say nothing" kinds of reports.
>
> I've had a couple of problems with the package browser giving a walkback
> when trying to install a package, and it seemed to occur only when no
> package was selected.  Does that sound familar?  I just tied it again on a
> different machine wihout incident.
>
> Based on the walkback below, one could simply lazily initialize the
> collection, or add a nil test, though might be simply treating the symptom.
>
> Have a good one,
>
> Bill
>
>
> ===============
> Unhandled exception - a MessageNotUnderstood('UndefinedObject does not
> understand #isEmpty')
>
> UndefinedObject(Object)>>doesNotUnderstand:
> PackagePrerequisites>>onPrerequisitesReset
> PackagePrerequisites>>onPrerequisitesReset:
> EventMessageSend>>forwardTo:withArguments:
> EventMessageSend(MessageSendAbstract)>>valueWithArguments:
> [] in EventMessageSequence(MessageSequenceAbstract)>>valueWithArguments:
> EventMessageSequence>>messagesDo:
> EventMessageSequence(MessageSequenceAbstract)>>valueWithArguments:
> EventsCollection>>triggerEvent:with:
> PackageManager(Object)>>trigger:with:
> PackageManager>>onPrerequisitesReset:
> EventMessageSend>>forwardTo:withArguments:
> EventMessageSend>>value
> [] in EventMessageSequence(MessageSequenceAbstract)>>value
> EventMessageSequence>>messagesDo:
> EventMessageSequence(MessageSequenceAbstract)>>value
> EventsCollection>>triggerEvent:
> Package(Object)>>trigger:
> Package>>resetPrerequisites
> [] in PackageManager>>resetPrerequisites
>
> --
> Wilhelm K. Schwab, Ph.D.
> [hidden email]
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Package browser bug?

Christopher J. Demers
In reply to this post by Bill Schwab-2
"Bill Schwab" <[hidden email]> wrote in message
news:bn17od$s4v8d$[hidden email]...
> Blair,
>
> This is one of those "it's worse to say nothing" kinds of reports.
>
> I've had a couple of problems with the package browser giving a walkback
> when trying to install a package, and it seemed to occur only when no
> package was selected.  Does that sound familar?  I just tied it again on a
> different machine wihout incident.

I have experienced this too.  I have done some "exotic" things with
packages, so I just assumed the error was caused by something I did.  I just
worked around it.  I figured that if it was a Dolphin bug someone else would
have reported it by now. ;)

Chris


Reply | Threaded
Open this post in threaded view
|

Re: Package browser bug?

Blair McGlashan
In reply to this post by Bill Schwab-2
Bill

You wrote in message news:bn17od$s4v8d$[hidden email]...
> ...
> I've had a couple of problems with the package browser giving a walkback
> when trying to install a package, and it seemed to occur only when no
> package was selected.  Does that sound familar?  ...
> ...

Thanks. I think this can only occur in a newly opened PB in which there has
never been a selection. Until recently this couldn't happen because of an
issue with the Windows TreeView control to which we applied workaround
patches in 5.1.1 (defect numbers 1255 and 1256 if you want to refer to the
release notes). Essentially the bug mean't that the TreeView was very
reluctant to have no selection, and would always have a selection when
initially opened even when the application did not explicitly set any
selection. With the patches in place it is possible for a PB to be opened
without any package selection occurring, and this means that the
PackagePrerequisites presenter is not properly initialised.

>...I just tied it again on a
> different machine wihout incident.

To reproduce it reliably you have to ensure that pre-requisites have been
recalculated (e.g. by viewing them in a package browser), since the event is
not sent if the pre-reqs have already been cleared. You must then open a
fresh PB and, without doing anything else, install a new package.

> ...Based on the walkback below, one could simply lazily initialize the
> collection, or add a nil test, though might be simply treating the
symptom.

The correct fix in this case is to add an initialize method to the presenter
to ensure that it is always correctly initialized. The patch below will be
included in PL2, which should be released this week via LiveUpdate, assuming
satisfactory completion of testing.

Thanks again

Regards

Blair

-------------- #1351--------------------

!PackagePrerequisites methodsFor!

initialize
 super initialize.
 packages := #()! !
!PackagePrerequisites categoriesFor: #initialize!initializing!private! !


Reply | Threaded
Open this post in threaded view
|

Re: Package browser bug?

Jochen Riekhof-3
>The patch below will be included in PL2, which should be released this week
via LiveUpdate

BTW: Will the DBConnection>>views method be in there?

Ciao

...Jochen


Reply | Threaded
Open this post in threaded view
|

Re: Package browser bug?

Blair McGlashan
"Jochen Riekhof" <[hidden email]> wrote in message
news:3f950be9$[hidden email]...
> >The patch below will be included in PL2, which should be released this
week
> via LiveUpdate
>
> BTW: Will the DBConnection>>views method be in there?

Just as well you reminded me, since I forgot to add that to our change
tracking system.

It already includes the patch for your other DB issue, #1260 "Prepared
statements give Error 3700 using SQL Server 2000". A complete list of the
patches can be found by following this link:

http://www.object-arts.com/Lib/Update/Dolphin/5.1/51PL2List.htm

The individual patches listed in those release notes can be downloaded from
that directory by using the issue number, e.g.

http://www.object-arts.com/Lib/Update/Dolphin/5.1/1260.st

N.B. Some of these patches have not been fully tested on all platforms.

A list of issues that might still be addressed in PL2 is at:

http://www.object-arts.com/Lib/Update/Dolphin/5.1/51PL2ToDo.htm

Finally a complete list of recorded issues (mainly enhancement requests) is
at:

http://www.object-arts.com/Lib/Update/Dolphin/5.1/AllOutstanding.htm

Regards

Blair


Reply | Threaded
Open this post in threaded view
|

Re: Package browser bug?

Bill Schwab-2
In reply to this post by Blair McGlashan
Blair,

> Thanks again

Thanks for fixing it :)

Bill

--
Wilhelm K. Schwab, Ph.D.
[hidden email]