PackageBrowser Prerequisites

The PackageBrowser's prerequisites tree view is not being drawn correctly,
compared to other tree views the box that the + and - is shown in is too
small - see attachment.

It appears to be caused by a partial attempt to add icons that display the
state of the package.  If you edit PackagePrerequisites.Default view and set
the #getImageBlock back to it's default state of IconicListAbstract and the
tree's viewMode aspect to #smallIcons then it displays correctly.

Ian




begin 666 prereq.JPG
M_]C_X `02D9)1@`!`0$`8 !@``#_VP!#``@&!@<&!0@'!P<)"0@*#!0-# L+
M#!D2$P\4'1H?'AT:'!P@)"XG("(L(QP<*#<I+# Q-#0T'R<Y/3@R/"XS-#+_
MVP!#`0D)"0P+#!@-#1@R(1PA,C(R,C(R,C(R,C(R,C(R,C(R,C(R,C(R,C(R
M,C(R,C(R,C(R,C(R,C(R,C(R,C(R,C+_P `1" "#`$4#`2(``A$!`Q$!_\0`
M'P```04!`0$!`0$```````````$"`P0%!@<("0H+_\0`M1 ``@$#`P($`P4%
M! 0```%]`0(#``01!1(A,4$&$U%A!R)Q%#*!D:$((T*QP152T? D,V)R@@D*
M%A<8&1HE)B<H*2HT-38W.#DZ0T1%1D=(24I35%565UA96F-D969G:&EJ<W1U
M=G=X>7J#A(6&AXB)BI*3E)66EYB9FJ*CI*6FIZBIJK*SM+6VM[BYNL+#Q,7&
MQ\C)RM+3U-76U]C9VN'BX^3EYN?HZ>KQ\O/T]?;W^/GZ_\0`'P$``P$!`0$!
M`0$!`0````````$"`P0%!@<("0H+_\0`M1$``@$"! 0#! <%! 0``0)W``$"
M`Q$$!2$Q!A)!40=A<1,B,H$(%$*1H;'!"2,S4O 58G+1"A8D-.$E\1<8&1HF
M)R@I*[hidden email]-$149'2$E*4U155E=865IC9&5F9VAI:G-T=79W>'EZ@H.$
MA8:'B(F*DI.4E9:7F)F:HJ.DI::GJ*FJLK.TM;:WN+FZPL/$Q<;'R,G*TM/4
MU=;7V-G:XN/DY>;GZ.GJ\O/T]?;W^/GZ_]H`# ,!``(1`Q$`/P#W\=*S(-92
M>:WB6UF!N$\V+=)$"T8*Y<+OW8&]<\<;AZUICI7(+X*A/B?3]2.HWGF6%L(S
M$MS,J/DQX.T2X5?W/*[=K[LG)6F(Y#XE6C7_`(^L;:-D$ALH\,[<1#S78N?F
M.U1L#%MH^YG+;?EY*;0P-1\K3HU-L46>WED94"Q?)M+.<*"I2-#S@.@4<@5U
M_P`1+^+1/%XEBCA1_P"RU2,MMV1DM)N)0DJ08D=>5' )RVW"\NWB6)X6BU""
M)E\IX)C"R6Y$0?S J@+M4J\4I)VG/S@XVY'K8/D]C%M+KO;NSAQ'-[1VOT[]
MAJ>&Y(+..X:%2RO,GDHZ*5$4,<BR*>=RX5#\HQB-,'E:JIH-XL\L*6BJ]K.(
M),,H$;@9'.<``0`[N@$8.1@5:3Q!;6L3PK:K'%%]H$8,_*"2%HGWDCDCRBW&
MT923@#[KH_%,MM-8R,VPV<4D;E9 C$E&C9@<?(PCBVCK@PEB"=U=5Z?:/X&-
MI>?XD0\/E8HX8DB%ZC;PHEC\MH1L"O&X.TA3%\QS\H13_ Q5MKINGS:N(+=F
M-M! 92Z@*6,40=@A(^4$PJ%)&0%0D97%3ZEXG:95\J6Y@FB8^9<SWAEF94)9
M5+'&`K1RGY0!\O(RF:BMM4LDUF2XE$5I&]O+#)@_*CM#)&SD`?*NY9&(`^4*
MP ^7%"]ERMOEV?;^O0/?NK7_`!#4-,\-6WV>VNM)N;EEMX9<_:(U4%X8R=JF
M(X &U>O11Z458:]TW4I%,FEW\MQ%!%%)Y%XH'R+Y6=OE$CF-AUZ@CM10I8=*
MSM?U7^8-56]/R?\`D?0(Z5F6M_)<SK/'IUSY$Z)ME+18QDG)&[=C!SW^@[Z8
MZ"N;A\+6ZZA!*U]?F:V6%MJ7\Z1-MX'[I9=F#LY!7!R>O-?/'J&QJNI0Z1I=
MQ?SK(Z0ID1Q %Y6Z*B D;G9B%4=R0.]9=CXFBCT..XU<^7?Q2FSN;>VA>1FN
M%SN$<2AI&5@#(O&?+(<@#-6=8T"#6+6WLV<P6:W"33Q0YC:4(#L`="&0JXB<
M,IS^[ Z$UE'P6;2Z-SI6I20NEPEY"M[YEV!<"*2%WD9Y/,<-$Z*%WJ%,2D9R
M009(?&=E/JCV4$OEQB*TF6Y>WD=29KEH#"R@#RY-R;<,00S'*XC85H-XIT9;
M.SNC>?N;VT^V6Q$3DRQ9C VKC)8F:,!,;B7 `)K/N/"=Q=W"W-QJOF7$GV,W
M+&W #&VNOM"!`"-B_-(F#N."A))5B\=UX#L;FUUJ`M&1J-Q'.BRQ>8B!)?/$
M;J3^\0SM,[#Y21*4! 5<`%@>+(%N'N9!(-)*+$K_`&659X;D$DQ2Q$!U+JT7
MEC;EB<=7C#7#JUQIWAR;5-8MO+F3>XM8,-(07/DQ`;B&F(*)@$@N<*2"*R]%
M\#VVGO-]M73;BVD0[+&VTU+:UB=E9)'$8)W%X]BDN6(&\ A7*BY<>&GOM'M-
M+O=2GGM8;LS2'++)+$K,T,?F!MX:-O)/F;MS&+G[QH N:!J4VI:6IO%CCU"W
M<V]['&"%69.&*@G(1N'3/)1T/>BH]&\/Q:'>7SVEQ.UK=^7(T4\KS/YP!5I#
M+(S,VY!$NTG \OCJ:* -@=!42C_3)#CK&@SCW;OC^I^@[RCH*B4?Z9(<=8T&
M<>[=\?U/T'<`EJ*$8EN#C&9 >F,_*OL,_K]>PEJND,;S3,\2DB0$$I[*>N!W
M4>O0<\8`!E^(K_4K671[32Y;2&?4+TV[2W4#3*BB":7(570DYB Z]S4=OXFB
MM[6[35CMN[*[%E(+6%Y/M$AB64&*-0SG,;ABH!*X?EE7>9]<T:ZOQI<FFW=O
M93Z==?:(C-;&:,@PR1;2JNAZ2DC![54D\+S>3#<PW\8UA+W^T'NI;<M%),83
M`<Q!P0@B;:H#@C:I9F.XL 5SXZT^/6989'D>S>WMS;?9[2:6=YG:Z#HT:*6!
M46QR"H*E6#<\`7QWIBZ]/:S74:V8LH+F-Q#(70M).DIE&,QI&8E#%PH0DAR"
M0*RY_!&J6.L:;J&E7\#W7VOS;F6>VW1Q$K?N[A!(I*L]YM50V5&"2W)K03P+
MMTS7K4ZCF36=/>UED$&!'(\ES([JN[[NZZ;"DY 4`L2<T 7%\;^'+::2UU#Q
M#IL%PCR'$[?9@5$TL6!YA^8JT3*2#R5S@!E%%2:!X8_L/5-1O?MGG_;,_)Y6
MW9FYN9^N3G_CYV_\`SWP"@#H!T%1*/\`3)#CK&@SCW;OC^I^@[RCH*B4?Z9(
M<=8T&<>[=\?U/T'<`6XG2UMI;B3.R)"[8'. ,FJEK<3M<R!].N(5D?=O9HB!
M\H'.UL]L=^W..!8O;?[78W%MNV>=$T>[&<9&,XK*@\,6T6K'4&NKZ1F9V:&2
M^N'B.X$$>4TA3'/ VX';&!3Z"ZDFO:A>6C:9:6!@CNM1NS;)-/&9$BQ%)*6*
M!E+9$17&X8W9YQ@Y=MXBU)-3MM+NQ:2SKK!TZXGBB:-9%^Q-=!D0LQ0@E%.6
M;.">,@#7UC2)+]+*6RN(K6[L;DW-N\D/F1[V1XVWH&4L"LK]&'S8/."#D2>%
M-2)AO8M6M%U8:G_:,LS6+- S?9C;;5B\T,HV;3RY^8$]#@(9'K'B*\A\9'0X
M-<T/2\VEO+ FH0&22YDDDE0J@$T><>6O`!.6^E;&O:A>6C:9:6!@CNM1NS;)
M-/&9$BQ%)*6*!E+9$17&X8W9YQ@Y_P#8?B2/5I-3AUO2ENI[2*VN`^E2,C>7
M)*RLH%P"O$V""6^[GC.*U-:TJ;4A936ES';WEC<?:+=Y8C+'N,;QD.@92PVR
M/C##G!Y ((!P_COXF:E\-[?34U32[359[UY@LMK,ULNU!&<E&$A4YD(QN/W0
M<_-M4K0\4?#&V\<V]E_PD^K7<MQ:/*R-I\:6\8#A`5"L'./W8/+$Y9N<852@
M#NQT%1J/],D..L:#./=N^/ZGZ#O(.@J-1_IDAQUC09Q[MWQ_4_0=P"6BBB@`
MJ*V&V)AC'[QSTQ_$?8?Y[GJ9:JQ6T+QL9((V)=P=R#D;F]AV8_F>3G) ,G6;
MW6/^$ATW2=)N;&V^T6ES<R2W=J\_^K>%0H"R)C/G$Y)/040>+;+^S(;F[CGC
MN'EG@:VM8)+I]\,ABE*K&I8QAU^^5'WDR%+ 5)K&CZE=:S8ZII>HVEI/:V\]
MNRW5FTZNLK1-D;9$((,([GJ:KMX7FLS8SZ-?QP7EJEPC2WMN9UF\^199694>
M/#F1`W!"C+ +C&T`R[KXH>'=&N;W^V]4@@M3=B*PEABDE$\?V:WE+90,#S/P
M> 1CKR:*\[^)OPCURZM-)M/#%O)J,$#N6\R6*-HE6WM8$!+,H8D6Y;(`ZXQZ
ME 'O8^Z/I4:C_3)#CK&@SCW;OC^I^@[R#[H^E1J/],D..L:#./=N^/ZGZ#N
M2T444 0W5RMI`965G^95"IC)+$*!R0.I%5--O?M$D\'V9XFAD829DB;8QPX4
MA&)#%75L$="#DYR;-Y;&[MQ$'V$2(^<9^ZX;'Z8K!\/^#;?0=4U&]6]N[G[9
M*'$=Q<S2A,)$HSYDC!FS%D.1N (4' %/H+J3:S>ZQ_PD.FZ3I-S8VWVBTN;F
M26[M7G_U;PJ%`61,9\XG))Z"B#Q;9?V9#<W<<\=P\L\#6UK!)=/OAD,4I58U
M+&,.OWRH^\F0I8"GZKHNH3ZMI^HZ1?V=E):6T]MLN+-IT9)&B;@+(FTCR1Z]
M:@;PO-9FQGT:_C@O+5+A&EO;<SK-Y\BRRLRH\>',B!N"%&6 7&-J&9=U\4/#
MNC7-[_;>J006INQ%82PQ22B>/[-;RELH&!YGX/ (QUY-%>=_$WX1ZY=6FDVG
MABWDU&"!W+>9+%&T2K;VL" EF4,2+<MD`=<8]2@#WL?='TK)M]66>_B"VDH^
MU0AXBTD(9D4\OMW;MH\Q,]<;AP">=8?='TKD5\%0GQ/I^I'4;SS+"V$9B6YF
M5'R8\':)<*O[GE=NU]V3DK3$='JNI0Z1I=Q?SK(Z0ID1Q %Y6Z*B`D;G9B%4
M=R0.]9=CXFBCT..XU<^7?Q2FSN;>VA>1FN%SN$<2AI&5@#(O&?+(<@#-6=8T
M"#6+6WLV<P6:W"33Q0YC:4(#L ="&0JXB<,IS^[ Z$UE'P6;2Z-SI6I20NEP
MEY"M[YEV!<"*2%WD9Y/,<-$Z*%WJ%,2D9R04,D/C.RGU1[*"7RXQ%:3+<O;R
M.I,URT!A90!Y<FY-N&((9CE<1L*T&\4Z,MG9W1O/W-[:?;+8B)R98LQ@;5QD
ML3-&`F-Q+@`$UGW'A.XN[A;FXU7S+B3[&;EC;@!C;77VA @!&Q?FD3!W'!0D
MDJQ>.Z\!V-S:ZU 6C(U&XCG198O,1 DOGB-U)_>(9VF=A\I(E* @*N "P/%D
M"W#W,@D&DE%B5_LLJSPW())BEB(#J75HO+&W+$XZO&&N'5KC3O#DVJ:Q;>7,
MF]Q:P8:0@N?)B W$-,043 )!<X4D$5EZ+X'MM/>;[:NFW%M(AV6-MIJ6UK$[
M*R2.(P3N+Q[%)<L0-X!"N5%RX\-/?:/::7>ZE//:PW9FD.6626)69H8_,#;P
MT;>2?,W;F,7/WC0!<T#4IM2TM3>+''J%NYM[V.,$*LR<,5!.0C<.F>2CH>]%
M1Z-X?BT.\OGM+B=K6[\N1HIY7F?S@"K2&61F9MR")=I.!Y?'4T4`:Z_='TK)
MM]66>_B"VDH^U0AXBTD(9D4\OMW;MH\Q,]<;AP">=9?NCZ5R*^"H3XGT_4CJ
M-YYEA;",Q+<S*CY,>#M$N%7]SRNW:^[)R5HZ".CU74H=(TNXOYUD=(4R(X@"
M\K=%1 2-SLQ"J.Y('>LNQ\311Z''<:N?+OXI39W-O;0O(S7"YW".)0TC*P!D
M7C/ED.0!FK.L:!!K%K;V;.8+-;A)IXH<QM*$!V .A#(5<1.&4Y_=@=":RCX+
M-I=&YTK4I(72X2\A6]\R[ N!%)"[R,\GF.&B=%"[U"F)2,Y((,D/C.RGU1[*
M"7RXQ%:3+<O;R.I,URT!A90!Y<FY-N&((9CE<1L*T&\4Z,MG9W1O/W-[:?;+
M8B)R98LQ@;5QDL3-& F-Q+@`$UGW'A.XN[A;FXU7S+B3[&;EC;@!C;77VA @
M!&Q?FD3!W'!0DDJQ>.Z\!V-S:ZU 6C(U&XCG198O,1 DOGB-U)_>(9VF=A\I
M(E* @*N "P/%D"W#W,@D&DE%B5_LLJSPW())BEB(#J75HO+&W+$XZO&&DO=6
MU2P\-+>7-M!%?SW<=O'&?F6$37"Q1%P&^9D61"X5L%E8*P!!JGHO@>VT]YOM
MJZ;<6TB'98VVFI;6L3LK)(XC!.XO'L4ERQ W@$*Y4:$V@37'AT:7+J,DLL5P
ML]O<2J7*^7.)85?+9<+M16)8,X4G()R "YIB:Q%YJ:M/8W/0QS6D+PYZY4QL
MS],`[@W.XC:-N6*-,MM4A\U]5U&"[D; 1;:U\B- ,\X+NQ8YY);&`N #DL4`
J7U^Z/I5:-B=4N%XP(8CT&>6?O^%%%("U1113`**** "BBB@`HHHH`__9
`
end

"Ian Bartholomew" <[hidden email]> wrote in message
news:[hidden email]...
> The PackageBrowser's prerequisites tree view is not being drawn correctly,
> compared to other tree views the box that the + and - is shown in is too
> small - see attachment.
>
> It appears to be caused by a partial attempt to add icons that display the
> state of the package.  If you edit PackagePrerequisites.Default view and
set
> the #getImageBlock back to it's default state of IconicListAbstract and
the
> tree's viewMode aspect to #smallIcons then it displays correctly.

It's not a partial attempt. The package state icons can be enabled (or
disabled) with the 'Show Status Icons' command on the context menu. They are
off by default, because enabling them slows down the display (in effect
deciding what icon to display requires about the same amount of computation
as expanding the entire tree).

Actually this seems to be a general problem on XP (when in "XP" mode) with
trees that have no icons - see for example the categories tree in the class
browsers. Methinks Microsoft may have a bug, or it could be that they 'no
icons' mode is not supported by version 6 of the common controls, after all
MS decided not to "bother" supporting the vertical mode of the tab view.

Regards

Blair

Blair,

> It's not a partial attempt. The package state icons can be enabled (or
> disabled) with the 'Show Status Icons' command on the context menu. They
are
> off by default, because enabling them slows down the display (in effect
> deciding what icon to display requires about the same amount of
computation
> as expanding the entire tree).

Apologies for the "partial attempt" smear, I hadn't come across that option
before and it, once again, makes me wonder what else is sitting in the image
that I haven't noticed :-)  I just tried turning the option on and, IMHO, it
makes the tree much easier to use and with no apparent slowdown - one for my
install script to turn on permanantly (if possible).

> Actually this seems to be a general problem on XP (when in "XP" mode) with
> trees that have no icons - see for example the categories tree in the
class
> browsers. Methinks Microsoft may have a bug, or it could be that they 'no
> icons' mode is not supported by version 6 of the common controls, after
all
> MS decided not to "bother" supporting the vertical mode of the tab view.

I've just had a random look round some other apps on my system and the ones
that use the +/- in trees all seem to have icons. The only one that I could
find that didn't display icons also drew it's own symbols to show the state
of the tree.

Ian

"Ian Bartholomew" <[hidden email]> wrote in message
news:[hidden email]... option
> before and it, once again, makes me wonder what else is sitting in the
image
> that I haven't noticed :-)  I just tried turning the option on and, IMHO,
it
> makes the tree much easier to use and with no apparent slowdown - one for
my
> install script to turn on permanently (if possible).

The slow-down would only be noticeable when the pre-reqs need to be
calculated, even then on a fast machine I think it is unlikely to be that
noticeable.

> > Actually this seems to be a general problem on XP (when in "XP" mode)
with
> > trees that have no icons - see for example the categories tree in the
> class
> > browsers. Methinks Microsoft may have a bug, or it could be that they
'no
> > icons' mode is not supported by version 6 of the common controls, after
> all
> > MS decided not to "bother" supporting the vertical mode of the tab view.
>
> I've just had a random look round some other apps on my system and the
ones
> that use the +/- in trees all seem to have icons. The only one that I
could
> find that didn't display icons also drew it's own symbols to show the
state
> of the tree.

Try the following:

1) Enable the VisualObjectFinder 'findNonDolphinWindows' option.
2) Using the VOF toolbar button, open an inspector on the folder tree of a
Windows explorer.
3) Select the 'handle' aspect and then run Inspect-It on 'TreeView
fromHandle: self' (hmmm, wouldn't it be better if the VOF opened on the
correct type of view's for non-Dolphin windows in the first place).
4) Switch the #viewMode of the tree to smallIcons and then back to #noIcons
(it will be incorrectly showing #noIcons in the first place)

You should now see that precisely the same paint bug exists. I think the
problem is that we have hard coded the 'indentSeparation' to 8, and this is
insufficient to allow the larger XP expand/contract button to be displayed
correctly. Increasing it to 16 in the inspector will cause the explorer
folder tree to redraw correctly. I will record this on the bugs database,
and if time permits we will include a durable fix in the base (if it doesn't
we'll have to bodge it by changing the indent of the view's in question).

BTW: A warning to all is to be careful about changing styles of non-Dolphin
Windows through an inspector. Since many of the style changes must
necessarily recreate the window, you will probably find that the owning
application is no longer aware of the window after recreation, and will get
confused and/or crash. This can be mildly diverting on a rainy afternoon,
but don't blame me if you crash your system.

Regards

Blair

"Blair McGlashan" <[hidden email]> wrote in message
news:[hidden email]...
>... if time permits we will include a durable fix in the base (if it
doesn't
> we'll have to bodge it by changing the indent of the view's in question).

Five minutes of time was sufficient to permit a reasonable fix! The minimum
indents are still hard coded, but this will have to do for now.

Regards

Blair

-------------------------------------------
!TreeView methodsFor!

updateIndentation
 "Private - Update the identation of child items to reflect the current
values
 of the icon extents and identSeparation."

 self
  sendMessage: TVM_SETINDENT
  wParam: (self imageExtent x + self indentSeparation max: self
minimumIndent)
  lParam: 0! !
!TreeView categoriesFor: #updateIndentation!private!updating! !

!TreeView methodsFor!

minimumIndent
 ^OSVERSIONINFO current isWinXP ifTrue: [16] ifFalse: [8]! !
!TreeView categoriesFor: #minimumIndent!public! !