In the wiki parser I see the lines
HorizontalRule : <horizontalRule> { #addHorizontalRule } | <horizontalRule> 'rule' Paragraph { self items children addFirst: (self createText: rule value) } ; items is initialized to an OrderedCollection, which I do not think responds to children. It does manage to pass the tests though. Keith ___________________________________________________________ The all-new Yahoo! Mail goes wherever you go - free your email address from your Internet provider. http://uk.docs.yahoo.com/nowyoucan.html _______________________________________________ SmallWiki, Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki _______________________________________________ Smallwiki mailing list [hidden email] http://impara.de/mailman/listinfo/smallwiki |
Lukas,
I found this code in the parser: reduceActionForHorizontalRule2: nodes ^ self items last setChildren: (self createText: (nodes at: 1) value) , self items last children which means that the code in the class does not match that contained in the definition comment. Do you have a more recent scanner/parser definition lying around somewhere? Keith > In the wiki parser I see the lines > > HorizontalRule > : <horizontalRule> { #addHorizontalRule } > | <horizontalRule> 'rule' Paragraph { self items children addFirst: > (self createText: rule value) } ; > > items is initialized to an OrderedCollection, which I do not think > responds to children. It does manage to pass the tests though. > > Keith > ___________________________________________________________ To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com _______________________________________________ SmallWiki, Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki _______________________________________________ Smallwiki mailing list [hidden email] http://impara.de/mailman/listinfo/smallwiki |
Hi Keith,
this is rather strange to have the parser definition and the code not in sync. I don't know how this could have happened. I fixed the reported bug in the latest version and recompiled the parser from the definition, all the tests pass again. Thanks for reporting. Cheers, Lukas On 5 Jun 2006, at 03:28, Keith Hodges wrote: > Lukas, > > I found this code in the parser: > > reduceActionForHorizontalRule2: nodes > ^ self items last setChildren: (self createText: (nodes at: 1) > value) , self items last children > > which means that the code in the class does not match that > contained in > the definition comment. > > Do you have a more recent scanner/parser definition lying around > somewhere? > > Keith > >> In the wiki parser I see the lines >> >> HorizontalRule >> : <horizontalRule> { #addHorizontalRule } >> | <horizontalRule> 'rule' Paragraph { self items children >> addFirst: >> (self createText: rule value) } ; >> >> items is initialized to an OrderedCollection, which I do not think >> responds to children. It does manage to pass the tests though. >> >> Keith >> > > > > ___________________________________________________________ > To help you stay safe and secure online, we've developed the all > new Yahoo! Security Centre. http://uk.security.yahoo.com > > _______________________________________________ > SmallWiki, Magritte, Pier and Related Tools ... > https://www.iam.unibe.ch/mailman/listinfo/smallwiki -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ SmallWiki, Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki _______________________________________________ Smallwiki mailing list [hidden email] http://impara.de/mailman/listinfo/smallwiki |
In reply to this post by keith1y
This comment appeared on the scg smallwiki pier site. I do have to say I
sympathise. The majority of squeak projects are referred to without sufficient context. As a recent example on the squeak list, 'hobbes' was talked about with much enthusiasm without any reference to what it actually was! Anyhow back to the topic, perhaps pier needs some marketing speak. Mission statement, tag lines etc. best regards Keith ___________________________________________________________ Copy addresses and emails from any email account to Yahoo! Mail - quick, easy and free. http://uk.docs.yahoo.com/trueswitch2.html _______________________________________________ SmallWiki, Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki _______________________________________________ Smallwiki mailing list [hidden email] http://impara.de/mailman/listinfo/smallwiki |
> This comment appeared on the scg smallwiki pier site. I do have to
> say I > sympathise. The majority of squeak projects are referred to without > sufficient context. As a recent example on the squeak list, > 'hobbes' was > talked about with much enthusiasm without any reference to what it > actually was! Hobbes is a VM written in Smalltalk being able to simulate the original Smalltalk-80 images: <http://wiki.cs.uiuc.edu/VisualWorks/ Smalltalk-80+in+a+box> > Anyhow back to the topic, perhaps pier needs some marketing speak. > Mission statement, tag lines etc. I completely agree, however -- as it is in the open source world -- everybody is invited to contribute: the code repositories are open to commit, the wikis are writable for public, there are slides on my homepage to give presentations, etc. Cheers, Lukas -- Lukas Renggli http://www.lukas-renggli.ch _______________________________________________ SmallWiki, Magritte, Pier and Related Tools ... https://www.iam.unibe.ch/mailman/listinfo/smallwiki _______________________________________________ Smallwiki mailing list [hidden email] http://impara.de/mailman/listinfo/smallwiki |
Free forum by Nabble | Edit this page |