[Patch] FilePlugin for Windows can now delete read-only files

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Patch] FilePlugin for Windows can now delete read-only files

Max Leske

Hi,

I just submitted a patch for the FilePlugin that enables deletion of read-only files on Windows. With this patch the VM treats deletion of read-only files on Windows the same way it does on *nix systems (except for the issue of open file handles, but that’s another story…).

This patch is especially important for dealing with external tools (e.g. Git) which mark private files as read-only.

http://bugs.squeak.org/view.php?id=7836


Cheers,
Max
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] FilePlugin for Windows can now delete read-only files

marcel.taeumel
Hi Max,

thank you! I just verified it for the CogVM #3477 with Windows 10, Cygwin (32-bit), and GCC 4.9.2. It works. Find attached the patch file.

Note that there was also another bug.

sqWin32FilePrims.patch

Best,
Marcel
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] FilePlugin for Windows can now delete read-only files

Max Leske
In reply to this post by Max Leske
 
Thanks Marcel.
I’ve updated the issue on bugs.squeak.org with your patch. Now it only needs to be integrated…

Cheers,
Max



Hi Max,

thank you! I just verified it for the CogVM #3477 with Windows 10, Cygwin
(32-bit), and GCC 4.9.2. It works. Find attached the patch file.

Note that there was also another bug.

sqWin32FilePrims.patch
<http://forum.world.st/file/n4856703/sqWin32FilePrims.patch>  

Best,
Marcel

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] FilePlugin for Windows can now delete read-only files

Eliot Miranda-2
 
Hi Max,  done, finally.  Forgive the delay.

On Tue, Oct 20, 2015 at 11:26 AM, Max Leske <[hidden email]> wrote:
 
Thanks Marcel.
I’ve updated the issue on bugs.squeak.org with your patch. Now it only needs to be integrated…

Cheers,
Max



Hi Max,

thank you! I just verified it for the CogVM #3477 with Windows 10, Cygwin
(32-bit), and GCC 4.9.2. It works. Find attached the patch file.

Note that there was also another bug.

sqWin32FilePrims.patch
<http://forum.world.st/file/n4856703/sqWin32FilePrims.patch>  

Best,
Marcel





--
_,,,^..^,,,_
best, Eliot