[Patch]Reorganisation of the gnu-smalltalk emacs mode files

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Patch]Reorganisation of the gnu-smalltalk emacs mode files

Jochen Schmitt
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hallo,

I want to make the suggestion to put the emacs mode files which
you deliver with gnu-smalltalk into a seperate directory. Therefore
I have create a patch which I have introduced on gnu-smalltalk-3.2-3.fc14.

the content of this patch you may find below for upstream integration.

Best Regards:

Jochen Schmitt

diff -up smalltalk-3.2/Makefile.am.emx smalltalk-3.2/Makefile.am
- --- smalltalk-3.2/Makefile.am.emx       2010-05-02 09:06:58.000000000
+0200
+++ smalltalk-3.2/Makefile.am   2010-06-23 19:15:28.336773575 +0200
@@ -69,7 +69,9 @@ bin_SCRIPTS = gst-config
 DISTCLEANFILES = termbold termnorm pkgrules.tmp
 CLEANFILES = gst.im $(nodist_lisp_LISP) $(nodist_lispstart_LISP)
 
- -lispstartdir = $(lispdir)/site-start.d
+sitelispdir = ${datadir}/emacs/site-lisp
+lispdir = ${sitelispdir}/gnu-smalltalk
+lispstartdir = $(sitelispdir)/site-start.d
 
 if WITH_EMACS
 dist_lisp_LISP = smalltalk-mode.el
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iJwEAQECAAYFAkwjiagACgkQZLAIBz9lVu+TDQP/bsjQfQMlFUec3ysSTwGXwKq8
n8pg/RoqEA+T3sjKPc0xeS1eRx5OiDj0/ZmHGs3/D1VKHW7E0htuxTLyASfnJLt7
hbXFnb16au4M+n/MwS2Qewa9lotYnP8fCXCvbKwaJ6YntyuzLQ5SBvPWlPjGvzJt
DRJ/eUWRoUHVfd2Jfss=
=Gj08
-----END PGP SIGNATURE-----


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [Patch]Reorganisation of the gnu-smalltalk emacs mode files

Paolo Bonzini-2
On 06/24/2010 06:36 PM, Jochen Schmitt wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hallo,
>
> I want to make the suggestion to put the emacs mode files which
> you deliver with gnu-smalltalk into a seperate directory. Therefore
> I have create a patch which I have introduced on gnu-smalltalk-3.2-3.fc14.
>
> the content of this patch you may find below for upstream integration.
>
> Best Regards:
>
> Jochen Schmitt
>
> diff -up smalltalk-3.2/Makefile.am.emx smalltalk-3.2/Makefile.am
> - --- smalltalk-3.2/Makefile.am.emx       2010-05-02 09:06:58.000000000
> +0200
> +++ smalltalk-3.2/Makefile.am   2010-06-23 19:15:28.336773575 +0200
> @@ -69,7 +69,9 @@ bin_SCRIPTS = gst-config
>   DISTCLEANFILES = termbold termnorm pkgrules.tmp
>   CLEANFILES = gst.im $(nodist_lisp_LISP) $(nodist_lispstart_LISP)
>
> - -lispstartdir = $(lispdir)/site-start.d
> +sitelispdir = ${datadir}/emacs/site-lisp
> +lispdir = ${sitelispdir}/gnu-smalltalk
> +lispstartdir = $(sitelispdir)/site-start.d

I'm applying this instead:

diff --git a/Makefile.am b/Makefile.am
index a98e099..9f24d42 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -69,6 +69,7 @@ bin_SCRIPTS = gst-config
  DISTCLEANFILES = termbold termnorm pkgrules.tmp
  CLEANFILES = gst.im $(nodist_lisp_LISP) $(nodist_lispstart_LISP)

+lispdir = ${datadir}/emacs/site-lisp
  lispstartdir = $(lispdir)/site-start.d

  if WITH_EMACS

Since on Fedora I found that quite a few packages install straight in
site-lisp.

Thanks!

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [Patch]Reorganisation of the gnu-smalltalk emacs mode files

Jochen Schmitt
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 24.06.2010 18:52, schrieb Paolo Bonzini:

> On 06/24/2010 06:36 PM, Jochen Schmitt wrote: I'm applying this
> instead:
>
> diff --git a/Makefile.am b/Makefile.am index a98e099..9f24d42
> 100644 --- a/Makefile.am +++ b/Makefile.am @@ -69,6 +69,7 @@
> bin_SCRIPTS = gst-config DISTCLEANFILES = termbold termnorm
> pkgrules.tmp CLEANFILES = gst.im $(nodist_lisp_LISP)
> $(nodist_lispstart_LISP)
>
> +lispdir = ${datadir}/emacs/site-lisp lispstartdir =
> $(lispdir)/site-start.d
>
> if WITH_EMACS
>
my aim was to put gst-mode.el and smalltalk-mode.el int
/usr/share/emacs/site-lisp/gnu-smalltalk/

and the init file smalltalk-mode-init.el into
/usr/shre/emacs/site-lisp/site-start.d

Because smalltalk-mode-init.el will be created from
smalltalk-init.el.in you may not make any changes on this
file, if you are change the location of the other two emacs files
and used my suggested patch.

Best Regards:

Jochen Schmitt
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iJwEAQECAAYFAkwjj7gACgkQZLAIBz9lVu8ONAP7BhMBEEs0aWX1oQJGMR/MXYZd
0a6sNCYxqxkI7XSiBlEUrUui8NyCCQvTa+fmQXAl5+KtBDoPeVORbryjI5PSdhrR
qu2XsgVOXYKBPPq6ltefdEtnG16o2fFlyQWD4paFfbj6Y8S0bZMAfZe5DnurjYlO
z9/3wgUtFmwbApb4OTk=
=bI4+
-----END PGP SIGNATURE-----


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [Patch]Reorganisation of the gnu-smalltalk emacs mode files

Paolo Bonzini-2
On 06/24/2010 07:02 PM, Jochen Schmitt wrote:
> my aim was to put gst-mode.el and smalltalk-mode.el int
> /usr/share/emacs/site-lisp/gnu-smalltalk/
>
> and the init file smalltalk-mode-init.el into
> /usr/shre/emacs/site-lisp/site-start.d

Understood, my patch instead will use /usr/share/emacs/site-lisp and
/usr/share/emacs/site-lisp/site-start.d.  I found that this matches the
behavior of most Fedora packages with .el files installed on my machine.

> Because smalltalk-mode-init.el will be created from
> smalltalk-init.el.in you may not make any changes on this
> file, if you are change the location of the other two emacs files
> and used my suggested patch.

I get

(autoload 'smalltalk-mode
"/usr/local/share/emacs/site-lisp/smalltalk-mode.elc" "" t)
(autoload 'gst "/usr/local/share/emacs/site-lisp/gst-mode.elc" "" t)

in /usr/share/emacs/site-lisp/site-start.d/smalltalk-mode-init.el, looks
fine, no?

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [Patch]Reorganisation of the gnu-smalltalk emacs mode files

Jochen Schmitt
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 24.06.2010 19:11, schrieb Paolo Bonzini:
> Understood, my patch instead will use /usr/share/emacs/site-lisp
> and /usr/share/emacs/site-lisp/site-start.d.  I found that this
> matches the behavior of most Fedora packages with .el files
> installed on my machine.

Putting the emacs files on /usr/share/emacs/site-lisp is ok as long as
there
is only one file (one source and one bytecompiled). but if there more
files than
is preffered to create a separate subdirectory to put the files into.

A simular rule exist for puting files into the /etc directory.

Best Regards:

Jochen Schmitt
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iJwEAQECAAYFAkwjlBQACgkQZLAIBz9lVu9FGgP/Q8jRcvP9/W84OdS+P+j5O58/
IVWq1httQuwzwyA/3/nvtgELqUcQMUEYFy1o+GtE/CP3krRln31RkHIISkL5R/vE
dTk3d3rHRXz9Q7+2ZKaa5o4LSzXBQC/3RnYYLjGrq94bAFXbKBjkz2+LTzLI6YM0
nT2m29GY8205Ufh/5Uk=
=33Zo
-----END PGP SIGNATURE-----


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [Patch]Reorganisation of the gnu-smalltalk emacs mode files

Paolo Bonzini-2
On 06/24/2010 07:21 PM, Jochen Schmitt wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 24.06.2010 19:11, schrieb Paolo Bonzini:
>> Understood, my patch instead will use /usr/share/emacs/site-lisp
>> and /usr/share/emacs/site-lisp/site-start.d.  I found that this
>> matches the behavior of most Fedora packages with .el files
>> installed on my machine.
>
> Putting the emacs files on /usr/share/emacs/site-lisp is ok as long as
> there
> is only one file (one source and one bytecompiled). but if there more
> files than
> is preffered to create a separate subdirectory to put the files into.

Two still seems to favor site-lisp in practice:

autoconf-2.65-1.fc13.noarch /usr/share/emacs/site-lisp/autoconf-mode.el
autoconf-2.65-1.fc13.noarch /usr/share/emacs/site-lisp/autotest-mode.el

guile-1.8.7-5.fc13.x86_64 /usr/share/emacs/site-lisp/gds.el
guile-1.8.7-5.fc13.x86_64 /usr/share/emacs/site-lisp/gds-scheme.el
guile-1.8.7-5.fc13.x86_64 /usr/share/emacs/site-lisp/gds-server.el

libidn-1.16-1.fc13.x86_64 libidn-1.16-1.fc13.i686
/usr/share/emacs/site-lisp/idna.el
libidn-1.16-1.fc13.x86_64 libidn-1.16-1.fc13.i686
/usr/share/emacs/site-lisp/punycode.el

subversion-1.6.9-2.fc13.x86_64 /usr/share/emacs/site-lisp/psvn.el
subversion-1.6.9-2.fc13.x86_64 /usr/share/emacs/site-lisp/psvn-init.el

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk