Pen trails bug

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Pen trails bug

Ricardo Moran

On Fri, Feb 24, 2012 at 2:00 PM, Ricardo Moran <[hidden email]> wrote:
Hi, you should grab a playfield from the supplies flap and draw you background in the playfield, then put your car inside the playfield and the pen trails should be above the background.

Hi, I think this is a bug. The pen trails work different in a playfield than in the world. In the world the background morph is draw above the pen trails, but in the playfield the pen trails are draw above the background. I believe the latter is the correct.

I looked at the code briefly and I couldn't find the error. In fact, it's weird because if I evaluate
 
World drawOn: Display getCanvas

in a workspace the pen trails are draw correctly. Any ideas?

Richo


Cheers,
Richo

On Fri, Feb 24, 2012 at 1:15 PM, R.D. Latimer <[hidden email]> wrote:
I have a 'racetrack' sketch that is supposed to work as a 'stage' as
in Scratch. The car drives on this racetrack and needs to leave a pen
trail.
The pendown writes onto the main screen area, underneath this
racetrack 'stage'.  How do I create two sketches - one serving as a
'stage' /background, and the other as the 'sprite' to move and leave
pen trails on the first sketch.
Thanks
Randy Latimer
_______________________________________________
squeakland mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/squeakland



_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev
Reply | Threaded
Open this post in threaded view
|

Re: Pen trails bug

Bert Freudenberg

On 24.02.2012, at 18:19, Ricardo Moran wrote:


On Fri, Feb 24, 2012 at 2:00 PM, Ricardo Moran <[hidden email]> wrote:
Hi, you should grab a playfield from the supplies flap and draw you background in the playfield, then put your car inside the playfield and the pen trails should be above the background.

Hi, I think this is a bug. The pen trails work different in a playfield than in the world. In the world the background morph is draw above the pen trails, but in the playfield the pen trails are draw above the background. I believe the latter is the correct.

I looked at the code briefly and I couldn't find the error. In fact, it's weird because if I evaluate
 
World drawOn: Display getCanvas

in a workspace the pen trails are draw correctly. Any ideas?


Interesting bug indeed ...

- Bert -



_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev
Reply | Threaded
Open this post in threaded view
|

Re: Pen trails bug

Ricardo Moran
I seem to have found a fix by modifying PasteUpMorph>>privateOuterDisplayWorld to leave the background morph out, like this:

privateOuterDisplayWorld 
worldState displayWorld: self submorphs: (submorphs copyWithout: backgroundMorph)

This seems to work but I fear the cost of making a copy all the time could be too high (I haven't checked, though). Another idea would be to never add the backgroundMorph to the World's submorphs but this could be even worse and it's not consistent with the playfield's case.

What do you think?

Richo

On Fri, Feb 24, 2012 at 3:53 PM, Bert Freudenberg <[hidden email]> wrote:

On 24.02.2012, at 18:19, Ricardo Moran wrote:


On Fri, Feb 24, 2012 at 2:00 PM, Ricardo Moran <[hidden email]> wrote:
Hi, you should grab a playfield from the supplies flap and draw you background in the playfield, then put your car inside the playfield and the pen trails should be above the background.

Hi, I think this is a bug. The pen trails work different in a playfield than in the world. In the world the background morph is draw above the pen trails, but in the playfield the pen trails are draw above the background. I believe the latter is the correct.

I looked at the code briefly and I couldn't find the error. In fact, it's weird because if I evaluate
 
World drawOn: Display getCanvas

in a workspace the pen trails are draw correctly. Any ideas?


Interesting bug indeed ...

- Bert -



_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev



_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev
Reply | Threaded
Open this post in threaded view
|

Re: Pen trails bug

Bert Freudenberg
I found exactly the same fix :)

Let's hear from Scott what he thinks.

- Bert -

On 24.02.2012, at 20:57, Ricardo Moran wrote:

I seem to have found a fix by modifying PasteUpMorph>>privateOuterDisplayWorld to leave the background morph out, like this:

privateOuterDisplayWorld 
worldState displayWorld: self submorphs: (submorphs copyWithout: backgroundMorph)

This seems to work but I fear the cost of making a copy all the time could be too high (I haven't checked, though). Another idea would be to never add the backgroundMorph to the World's submorphs but this could be even worse and it's not consistent with the playfield's case.

What do you think?

Richo

On Fri, Feb 24, 2012 at 3:53 PM, Bert Freudenberg <[hidden email]> wrote:

On 24.02.2012, at 18:19, Ricardo Moran wrote:


On Fri, Feb 24, 2012 at 2:00 PM, Ricardo Moran <[hidden email]> wrote:
Hi, you should grab a playfield from the supplies flap and draw you background in the playfield, then put your car inside the playfield and the pen trails should be above the background.

Hi, I think this is a bug. The pen trails work different in a playfield than in the world. In the world the background morph is draw above the pen trails, but in the playfield the pen trails are draw above the background. I believe the latter is the correct.

I looked at the code briefly and I couldn't find the error. In fact, it's weird because if I evaluate
 
World drawOn: Display getCanvas

in a workspace the pen trails are draw correctly. Any ideas?


Interesting bug indeed ...

- Bert -




_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev
Reply | Threaded
Open this post in threaded view
|

Re: Pen trails bug

Ricardo Moran
Then I must have learned a lot :)

Richo

On Fri, Feb 24, 2012 at 5:01 PM, Bert Freudenberg <[hidden email]> wrote:
I found exactly the same fix :)

Let's hear from Scott what he thinks.

- Bert -

On 24.02.2012, at 20:57, Ricardo Moran wrote:

I seem to have found a fix by modifying PasteUpMorph>>privateOuterDisplayWorld to leave the background morph out, like this:

privateOuterDisplayWorld 
worldState displayWorld: self submorphs: (submorphs copyWithout: backgroundMorph)

This seems to work but I fear the cost of making a copy all the time could be too high (I haven't checked, though). Another idea would be to never add the backgroundMorph to the World's submorphs but this could be even worse and it's not consistent with the playfield's case.

What do you think?

Richo

On Fri, Feb 24, 2012 at 3:53 PM, Bert Freudenberg <[hidden email]> wrote:

On 24.02.2012, at 18:19, Ricardo Moran wrote:


On Fri, Feb 24, 2012 at 2:00 PM, Ricardo Moran <[hidden email]> wrote:
Hi, you should grab a playfield from the supplies flap and draw you background in the playfield, then put your car inside the playfield and the pen trails should be above the background.

Hi, I think this is a bug. The pen trails work different in a playfield than in the world. In the world the background morph is draw above the pen trails, but in the playfield the pen trails are draw above the background. I believe the latter is the correct.

I looked at the code briefly and I couldn't find the error. In fact, it's weird because if I evaluate
 
World drawOn: Display getCanvas

in a workspace the pen trails are draw correctly. Any ideas?


Interesting bug indeed ...

- Bert -




_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev



_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev
Reply | Threaded
Open this post in threaded view
|

Re: Pen trails bug

Karl Ramberg
In reply to this post by Bert Freudenberg
On Fri, Feb 24, 2012 at 9:01 PM, Bert Freudenberg <[hidden email]> wrote:

> I found exactly the same fix :)
>
> Let's hear from Scott what he thinks.
>
> - Bert -
>
> On 24.02.2012, at 20:57, Ricardo Moran wrote:
>
> I seem to have found a fix by modifying
> PasteUpMorph>>privateOuterDisplayWorld to leave the background morph out,
> like this:
>
> privateOuterDisplayWorld
>
> worldState displayWorld: self submorphs: (submorphs copyWithout:
> backgroundMorph)
>
>
> This seems to work but I fear the cost of making a copy all the time could
> be too high (I haven't checked, though). Another idea would be to never add
> the backgroundMorph to the World's submorphs but this could be even worse
> and it's not consistent with the playfield's case.
>
> What do you think?
>
> Richo
>
> On Fri, Feb 24, 2012 at 3:53 PM, Bert Freudenberg <[hidden email]>
> wrote:
>>
>>
>> On 24.02.2012, at 18:19, Ricardo Moran wrote:
>>
>>
>> On Fri, Feb 24, 2012 at 2:00 PM, Ricardo Moran <[hidden email]>
>> wrote:
>>>
>>> Hi, you should grab a playfield from the supplies flap and draw you
>>> background in the playfield, then put your car inside the playfield and the
>>> pen trails should be above the background.
>>
>>
>> Hi, I think this is a bug. The pen trails work different in a playfield
>> than in the world. In the world the background morph is draw above the pen
>> trails, but in the playfield the pen trails are draw above the background. I
>> believe the latter is the correct.
>>
>> I looked at the code briefly and I couldn't find the error. In fact, it's
>> weird because if I evaluate
>>
>>>
>>> World drawOn: Display getCanvas
>>
>>
>> in a workspace the pen trails are draw correctly. Any ideas?
>>
>>
>>
>> Interesting bug indeed ...
>>
>> - Bert -
>

I have always had a little problems with the pen trails.
They have not had a first row seat and that have bothered me a little.
But I'm not sure what I want instead.

Karl
_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev
Reply | Threaded
Open this post in threaded view
|

Re: Pen trails bug

Scott Wallace
In reply to this post by Bert Freudenberg
Excellent… but we should only do the "copyWithout:" in the comparatively uncommon case of the backgroundMorph's actually being notNil…

Great finally to get consistency between playfields and worlds here :)

  -- Scott





On Feb 24, 2012, at 12:01 PM, Bert Freudenberg wrote:

I found exactly the same fix :)

Let's hear from Scott what he thinks.

- Bert -

On 24.02.2012, at 20:57, Ricardo Moran wrote:

I seem to have found a fix by modifying PasteUpMorph>>privateOuterDisplayWorld to leave the background morph out, like this:

privateOuterDisplayWorld 
worldState displayWorld: self submorphs: (submorphs copyWithout: backgroundMorph)

This seems to work but I fear the cost of making a copy all the time could be too high (I haven't checked, though). Another idea would be to never add the backgroundMorph to the World's submorphs but this could be even worse and it's not consistent with the playfield's case.

What do you think?

Richo

On Fri, Feb 24, 2012 at 3:53 PM, Bert Freudenberg <[hidden email]> wrote:

On 24.02.2012, at 18:19, Ricardo Moran wrote:


On Fri, Feb 24, 2012 at 2:00 PM, Ricardo Moran <[hidden email]> wrote:
Hi, you should grab a playfield from the supplies flap and draw you background in the playfield, then put your car inside the playfield and the pen trails should be above the background.

Hi, I think this is a bug. The pen trails work different in a playfield than in the world. In the world the background morph is draw above the pen trails, but in the playfield the pen trails are draw above the background. I believe the latter is the correct.

I looked at the code briefly and I couldn't find the error. In fact, it's weird because if I evaluate
 
World drawOn: Display getCanvas

in a workspace the pen trails are draw correctly. Any ideas?


Interesting bug indeed ...

- Bert -



_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev


_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev

privateOuterDisplayWorld.st.gz (366 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Pen trails bug

Karl Ramberg
Added in http://source.squeak.org/etoys/Morphic-kfr.76.mcz

Karl

On Sat, Feb 25, 2012 at 6:29 AM, Scott Wallace
<[hidden email]> wrote:

> Excellent… but we should only do the "copyWithout:" in the comparatively
> uncommon case of the backgroundMorph's actually being notNil…
>
> Great finally to get consistency between playfields and worlds here :)
>
>   -- Scott
>
>
>
>
>
> On Feb 24, 2012, at 12:01 PM, Bert Freudenberg wrote:
>
> I found exactly the same fix :)
>
> Let's hear from Scott what he thinks.
>
> - Bert -
>
> On 24.02.2012, at 20:57, Ricardo Moran wrote:
>
> I seem to have found a fix by modifying
> PasteUpMorph>>privateOuterDisplayWorld to leave the background morph out,
> like this:
>
> privateOuterDisplayWorld
>
> worldState displayWorld: self submorphs: (submorphs copyWithout:
> backgroundMorph)
>
>
> This seems to work but I fear the cost of making a copy all the time could
> be too high (I haven't checked, though). Another idea would be to never add
> the backgroundMorph to the World's submorphs but this could be even worse
> and it's not consistent with the playfield's case.
>
> What do you think?
>
> Richo
>
> On Fri, Feb 24, 2012 at 3:53 PM, Bert Freudenberg <[hidden email]>
> wrote:
>>
>>
>> On 24.02.2012, at 18:19, Ricardo Moran wrote:
>>
>>
>> On Fri, Feb 24, 2012 at 2:00 PM, Ricardo Moran <[hidden email]>
>> wrote:
>>>
>>> Hi, you should grab a playfield from the supplies flap and draw you
>>> background in the playfield, then put your car inside the playfield and the
>>> pen trails should be above the background.
>>
>>
>> Hi, I think this is a bug. The pen trails work different in a playfield
>> than in the world. In the world the background morph is draw above the pen
>> trails, but in the playfield the pen trails are draw above the background. I
>> believe the latter is the correct.
>>
>> I looked at the code briefly and I couldn't find the error. In fact, it's
>> weird because if I evaluate
>>
>>>
>>> World drawOn: Display getCanvas
>>
>>
>> in a workspace the pen trails are draw correctly. Any ideas?
>>
>>
>>
>> Interesting bug indeed ...
>>
>> - Bert -
>
>
>
>
> _______________________________________________
> etoys-dev mailing list
> [hidden email]
> http://lists.squeakland.org/mailman/listinfo/etoys-dev
>
>
>
> _______________________________________________
> etoys-dev mailing list
> [hidden email]
> http://lists.squeakland.org/mailman/listinfo/etoys-dev
>
_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev