Pharo 1.2 broken on Hudson due to XMLSupport changes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

Pharo 1.2 broken on Hudson due to XMLSupport changes

Torsten Bergmann
Still I do not understand:

Evaluate this in an updated Pharo core 1.2:

------------------------------------------------------------------------
  Gofer new
    squeaksource: 'MetacelloRepository';
    package: 'ConfigurationOfXMLSupport';
    load.
       
  (Smalltalk at: #ConfigurationOfXMLSupport) project latestVersion
------------------------------------------------------------------------

returns  1.1.8 [ConfigurationOfXMLSupport]

This is now broken by Otto. OK, he broke it, he has to repair it ;)

But independent from that, the method in:

 ConfigurationOfPharo>>version12beta2:

includes the following:
 
   project: 'XMLSupport' with: '1.1.6'.

So I would have expected that for Pharo "1.2-beta2" the 1.1.6 (and not the
1.1.8) of XMLSupport gets loaded and Hudson should have been green.

Why does Metacello load the 1.1.8 when a previous project version (1.1.6)
is referenced?

Dale, any comments?

Bye
T.



--
Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir
belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de

Reply | Threaded
Open this post in threaded view
|

Re: Pharo 1.2 broken on Hudson due to XMLSupport changes

Marcus Denker-4
I personally thing if we ever want to release 1.2, we need to start to be more radical.

The XML package breaks the build? So let's remove it completely. Let's ship 1.2, but without
all the packages that are problematic.

Same for any other package that has a failing test.

        Marcus


On Feb 25, 2011, at 1:12 PM, Torsten Bergmann wrote:

> Still I do not understand:
>
> Evaluate this in an updated Pharo core 1.2:
>
> ------------------------------------------------------------------------
>  Gofer new
>    squeaksource: 'MetacelloRepository';
>    package: 'ConfigurationOfXMLSupport';
>    load.
>
>  (Smalltalk at: #ConfigurationOfXMLSupport) project latestVersion
> ------------------------------------------------------------------------
>
> returns  1.1.8 [ConfigurationOfXMLSupport]
>
> This is now broken by Otto. OK, he broke it, he has to repair it ;)
>
> But independent from that, the method in:
>
> ConfigurationOfPharo>>version12beta2:
>
> includes the following:
>
>   project: 'XMLSupport' with: '1.1.6'.
>
> So I would have expected that for Pharo "1.2-beta2" the 1.1.6 (and not the
> 1.1.8) of XMLSupport gets loaded and Hudson should have been green.
>
> Why does Metacello load the 1.1.8 when a previous project version (1.1.6)
> is referenced?
>
> Dale, any comments?
>
> Bye
> T.
>
>
>
> --
> Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir
> belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de
>

--
Marcus Denker  -- http://www.marcusdenker.de
INRIA Lille -- Nord Europe. Team RMoD.


Reply | Threaded
Open this post in threaded view
|

Re: Pharo 1.2 broken on Hudson due to XMLSupport changes

laurent laffont
Marcus,

I've worked on this this week:
- I've fixed ReleaseTest.testUndeclared and RBInlineMethodFromComponentTest.testInlineEmptyComponentMethod 

- For all Metacello tests, the fix is available but Dale said: "I haven't released my changes yet ... once I'm satisfied with the the behavior on PharoCore1.2 (that's where I'm doing development) I now have to get the new version of Gofer ported to Squeak and GemStone before I can make the full release ... otherwise the tests will be failing on Squeak/GemStone ..."

I think this is really problematic to wait for Squeak/GemStone but one way to go forward is to put them in #expectedFailures

- For XML I can fix this tonight if Otto don't want / can do it.


So there's only one failing test without fix awaiting: ReleaseTest.testObsoleteClasses. Guillermo and I had a look at it on Monday:


GuilleP: Ok, obsoletes come from: ClassRenameFixTest seems to be creating an AutoGeneratedClassForTestingSystemChanges

GuilleP: But I can't find the source of AnObsoleteMCMockClassG :(

laurentlaffont: it  comes from MCMockPackageInfo>>#classNames

laurentlaffont: see also the comment in MCPackageTest>>#tearDown


some work needed to fix this. 


But I agree that it seems few people care about 1.2. Sad, I like it far better than 1.1.1.  


Laurent.



On Fri, Feb 25, 2011 at 1:18 PM, Marcus Denker <[hidden email]> wrote:
I personally thing if we ever want to release 1.2, we need to start to be more radical.

The XML package breaks the build? So let's remove it completely. Let's ship 1.2, but without
all the packages that are problematic.

Same for any other package that has a failing test.

       Marcus


On Feb 25, 2011, at 1:12 PM, Torsten Bergmann wrote:

> Still I do not understand:
>
> Evaluate this in an updated Pharo core 1.2:
>
> ------------------------------------------------------------------------
>  Gofer new
>    squeaksource: 'MetacelloRepository';
>    package: 'ConfigurationOfXMLSupport';
>    load.
>
>  (Smalltalk at: #ConfigurationOfXMLSupport) project latestVersion
> ------------------------------------------------------------------------
>
> returns  1.1.8 [ConfigurationOfXMLSupport]
>
> This is now broken by Otto. OK, he broke it, he has to repair it ;)
>
> But independent from that, the method in:
>
> ConfigurationOfPharo>>version12beta2:
>
> includes the following:
>
>   project: 'XMLSupport' with: '1.1.6'.
>
> So I would have expected that for Pharo "1.2-beta2" the 1.1.6 (and not the
> 1.1.8) of XMLSupport gets loaded and Hudson should have been green.
>
> Why does Metacello load the 1.1.8 when a previous project version (1.1.6)
> is referenced?
>
> Dale, any comments?
>
> Bye
> T.
>
>
>
> --
> Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir
> belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de
>

--
Marcus Denker  -- http://www.marcusdenker.de
INRIA Lille -- Nord Europe. Team RMoD.



Reply | Threaded
Open this post in threaded view
|

Re: Pharo 1.2 broken on Hudson due to XMLSupport changes

otto
> - For XML I can fix this tonight if Otto don't want / can do it.

1.1.9 was blessed as #development and 1.1.8 as #release. I changed the
blessing 1.1.9 to #released. I do believe that the 1.1.9 version works
well. 1.1.8 is now #broken.

Sorry about that. Thanks for the help.

I'm doing a load in Pharo 1.2 now...

Reply | Threaded
Open this post in threaded view
|

Re: Pharo 1.2 broken on Hudson due to XMLSupport changes

laurent laffont
On Fri, Feb 25, 2011 at 4:53 PM, Otto Behrens <[hidden email]> wrote:
> - For XML I can fix this tonight if Otto don't want / can do it.

1.1.9 was blessed as #development and 1.1.8 as #release. I changed the
blessing 1.1.9 to #released. I do believe that the 1.1.9 version works
well. 1.1.8 is now #broken.

Sorry about that. Thanks for the help.

I'm doing a load in Pharo 1.2 now...


Thank you Otto

Laurent.
Reply | Threaded
Open this post in threaded view
|

Re: Pharo 1.2 broken on Hudson due to XMLSupport changes

otto
In reply to this post by otto
I've downloaded the PharoOneClick1.2.zip file and am evaluating

 (ConfigurationOfPharo project version: '1.2-beta2') load

now. This is the best "entry point" that I could determine from the
console output. Please let me know if this is OK. My bandwidth is not
amazing, but it's running.

On Fri, Feb 25, 2011 at 5:53 PM, Otto Behrens <[hidden email]> wrote:

>> - For XML I can fix this tonight if Otto don't want / can do it.
>
> 1.1.9 was blessed as #development and 1.1.8 as #release. I changed the
> blessing 1.1.9 to #released. I do believe that the 1.1.9 version works
> well. 1.1.8 is now #broken.
>
> Sorry about that. Thanks for the help.
>
> I'm doing a load in Pharo 1.2 now...
>

Reply | Threaded
Open this post in threaded view
|

Re: Pharo 1.2 broken on Hudson due to XMLSupport changes

Stéphane Ducasse
In reply to this post by Marcus Denker-4
Marcus
 
I would not add XML in dev. just dev tools no extra package.
So yes let us remove XML package. I already asked for that.
Now the problem encountered reveal something deeper.


STef

On Feb 25, 2011, at 1:18 PM, Marcus Denker wrote:

> I personally thing if we ever want to release 1.2, we need to start to be more radical.
>
> The XML package breaks the build? So let's remove it completely. Let's ship 1.2, but without
> all the packages that are problematic.
>
> Same for any other package that has a failing test.
>
> Marcus
>
>
> On Feb 25, 2011, at 1:12 PM, Torsten Bergmann wrote:
>
>> Still I do not understand:
>>
>> Evaluate this in an updated Pharo core 1.2:
>>
>> ------------------------------------------------------------------------
>> Gofer new
>>   squeaksource: 'MetacelloRepository';
>>   package: 'ConfigurationOfXMLSupport';
>>   load.
>>
>> (Smalltalk at: #ConfigurationOfXMLSupport) project latestVersion
>> ------------------------------------------------------------------------
>>
>> returns  1.1.8 [ConfigurationOfXMLSupport]
>>
>> This is now broken by Otto. OK, he broke it, he has to repair it ;)
>>
>> But independent from that, the method in:
>>
>> ConfigurationOfPharo>>version12beta2:
>>
>> includes the following:
>>
>>  project: 'XMLSupport' with: '1.1.6'.
>>
>> So I would have expected that for Pharo "1.2-beta2" the 1.1.6 (and not the
>> 1.1.8) of XMLSupport gets loaded and Hudson should have been green.
>>
>> Why does Metacello load the 1.1.8 when a previous project version (1.1.6)
>> is referenced?
>>
>> Dale, any comments?
>>
>> Bye
>> T.
>>
>>
>>
>> --
>> Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir
>> belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de
>>
>
> --
> Marcus Denker  -- http://www.marcusdenker.de
> INRIA Lille -- Nord Europe. Team RMoD.
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Pharo 1.2 broken on Hudson due to XMLSupport changes

otto
In reply to this post by otto
It loaded and XML-Tests-Parser reports:

361 run, 361 passes, 0 expected failures, 0 failures, 0 errors, 0
unexpected passes

Running all tests now (11240) ...

On Fri, Feb 25, 2011 at 6:04 PM, Otto Behrens <[hidden email]> wrote:

> I've downloaded the PharoOneClick1.2.zip file and am evaluating
>
>  (ConfigurationOfPharo project version: '1.2-beta2') load
>
> now. This is the best "entry point" that I could determine from the
> console output. Please let me know if this is OK. My bandwidth is not
> amazing, but it's running.
>
> On Fri, Feb 25, 2011 at 5:53 PM, Otto Behrens <[hidden email]> wrote:
>>> - For XML I can fix this tonight if Otto don't want / can do it.
>>
>> 1.1.9 was blessed as #development and 1.1.8 as #release. I changed the
>> blessing 1.1.9 to #released. I do believe that the 1.1.9 version works
>> well. 1.1.8 is now #broken.
>>
>> Sorry about that. Thanks for the help.
>>
>> I'm doing a load in Pharo 1.2 now...
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: Pharo 1.2 broken on Hudson due to XMLSupport changes

Stéphane Ducasse
In reply to this post by otto
Hi otto

no stress. :)
There is no problem. Doing something implies that we can do it wrong (I do all the times mistakes and I hope that I learn
to improve myself). I prefer having a community of people doing some wrong actions than just talking.

Stef

On Feb 25, 2011, at 4:53 PM, Otto Behrens wrote:

>> - For XML I can fix this tonight if Otto don't want / can do it.
>
> 1.1.9 was blessed as #development and 1.1.8 as #release. I changed the
> blessing 1.1.9 to #released. I do believe that the 1.1.9 version works
> well. 1.1.8 is now #broken.
>
> Sorry about that. Thanks for the help.
>
> I'm doing a load in Pharo 1.2 now...
>


Reply | Threaded
Open this post in threaded view
|

Re: Pharo 1.2 broken on Hudson due to XMLSupport changes

EstebanLM
In reply to this post by Stéphane Ducasse
+1

El 25/02/2011, a las 1:09p.m., Stéphane Ducasse escribió:

> Marcus
>
> I would not add XML in dev. just dev tools no extra package.
> So yes let us remove XML package. I already asked for that.
> Now the problem encountered reveal something deeper.
>
>
> STef
>
> On Feb 25, 2011, at 1:18 PM, Marcus Denker wrote:
>
>> I personally thing if we ever want to release 1.2, we need to start to be more radical.
>>
>> The XML package breaks the build? So let's remove it completely. Let's ship 1.2, but without
>> all the packages that are problematic.
>>
>> Same for any other package that has a failing test.
>>
>> Marcus
>>
>>
>> On Feb 25, 2011, at 1:12 PM, Torsten Bergmann wrote:
>>
>>> Still I do not understand:
>>>
>>> Evaluate this in an updated Pharo core 1.2:
>>>
>>> ------------------------------------------------------------------------
>>> Gofer new
>>>  squeaksource: 'MetacelloRepository';
>>>  package: 'ConfigurationOfXMLSupport';
>>>  load.
>>>
>>> (Smalltalk at: #ConfigurationOfXMLSupport) project latestVersion
>>> ------------------------------------------------------------------------
>>>
>>> returns  1.1.8 [ConfigurationOfXMLSupport]
>>>
>>> This is now broken by Otto. OK, he broke it, he has to repair it ;)
>>>
>>> But independent from that, the method in:
>>>
>>> ConfigurationOfPharo>>version12beta2:
>>>
>>> includes the following:
>>>
>>> project: 'XMLSupport' with: '1.1.6'.
>>>
>>> So I would have expected that for Pharo "1.2-beta2" the 1.1.6 (and not the
>>> 1.1.8) of XMLSupport gets loaded and Hudson should have been green.
>>>
>>> Why does Metacello load the 1.1.8 when a previous project version (1.1.6)
>>> is referenced?
>>>
>>> Dale, any comments?
>>>
>>> Bye
>>> T.
>>>
>>>
>>>
>>> --
>>> Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir
>>> belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de
>>>
>>
>> --
>> Marcus Denker  -- http://www.marcusdenker.de
>> INRIA Lille -- Nord Europe. Team RMoD.
>>
>>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Pharo 1.2 broken on Hudson due to XMLSupport changes

Guillermo Polito
In reply to this post by Stéphane Ducasse
I didn't try it yet, but using metacello browser, and letting it have a project description, will do the work for us ;).

On Fri, Feb 25, 2011 at 1:09 PM, Stéphane Ducasse <[hidden email]> wrote:
Marcus

I would not add XML in dev. just dev tools no extra package.
So yes let us remove XML package. I already asked for that.
Now the problem encountered reveal something deeper.


STef

On Feb 25, 2011, at 1:18 PM, Marcus Denker wrote:

> I personally thing if we ever want to release 1.2, we need to start to be more radical.
>
> The XML package breaks the build? So let's remove it completely. Let's ship 1.2, but without
> all the packages that are problematic.
>
> Same for any other package that has a failing test.
>
>       Marcus
>
>
> On Feb 25, 2011, at 1:12 PM, Torsten Bergmann wrote:
>
>> Still I do not understand:
>>
>> Evaluate this in an updated Pharo core 1.2:
>>
>> ------------------------------------------------------------------------
>> Gofer new
>>   squeaksource: 'MetacelloRepository';
>>   package: 'ConfigurationOfXMLSupport';
>>   load.
>>
>> (Smalltalk at: #ConfigurationOfXMLSupport) project latestVersion
>> ------------------------------------------------------------------------
>>
>> returns  1.1.8 [ConfigurationOfXMLSupport]
>>
>> This is now broken by Otto. OK, he broke it, he has to repair it ;)
>>
>> But independent from that, the method in:
>>
>> ConfigurationOfPharo>>version12beta2:
>>
>> includes the following:
>>
>>  project: 'XMLSupport' with: '1.1.6'.
>>
>> So I would have expected that for Pharo "1.2-beta2" the 1.1.6 (and not the
>> 1.1.8) of XMLSupport gets loaded and Hudson should have been green.
>>
>> Why does Metacello load the 1.1.8 when a previous project version (1.1.6)
>> is referenced?
>>
>> Dale, any comments?
>>
>> Bye
>> T.
>>
>>
>>
>> --
>> Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir
>> belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de
>>
>
> --
> Marcus Denker  -- http://www.marcusdenker.de
> INRIA Lille -- Nord Europe. Team RMoD.
>
>



Reply | Threaded
Open this post in threaded view
|

Re: Pharo 1.2 broken on Hudson due to XMLSupport changes

Dale Henrichs
In reply to this post by Torsten Bergmann
I've downloaded a Pharo1.2 image from Hudson to see what's happening and
I notice that there are a number of validation issues with the
ConfigurationOfPharo ... so I think that the XMLSupport issues have been
addressed ... this build is yello and the earlier build was red ...

Is that right? Or are there other things that I don't know about?

Dale
On 02/25/2011 04:11 AM, Torsten Bergmann wrote:

> Still I do not understand:
>
> Evaluate this in an updated Pharo core 1.2:
>
> ------------------------------------------------------------------------
>    Gofer new
>      squeaksource: 'MetacelloRepository';
>      package: 'ConfigurationOfXMLSupport';
>      load.
>
>    (Smalltalk at: #ConfigurationOfXMLSupport) project latestVersion
> ------------------------------------------------------------------------
>
> returns  1.1.8 [ConfigurationOfXMLSupport]
>
> This is now broken by Otto. OK, he broke it, he has to repair it;)
>
> But independent from that, the method in:
>
>   ConfigurationOfPharo>>version12beta2:
>
> includes the following:
>
>     project: 'XMLSupport' with: '1.1.6'.
>
> So I would have expected that for Pharo "1.2-beta2" the 1.1.6 (and not the
> 1.1.8) of XMLSupport gets loaded and Hudson should have been green.
>
> Why does Metacello load the 1.1.8 when a previous project version (1.1.6)
> is referenced?
>
> Dale, any comments?


Reply | Threaded
Open this post in threaded view
|

Re: Pharo 1.2 broken on Hudson due to XMLSupport changes

Marcus Denker-4
In reply to this post by Torsten Bergmann

On Feb 26, 2011, at 1:44 AM, Dale Henrichs wrote:

> I've downloaded a Pharo1.2 image from Hudson to see what's happening and I notice that there are a number of validation issues with the ConfigurationOfPharo ... so I think that the XMLSupport issues have been addressed ...

yes.

> this build is yello and the earlier build was red ...
>
> Is that right?

yes

> Or are there other things that I don't know about?
>
Maybe that 1.1 is now broken: https://pharo-ic.lille.inria.fr/hudson/job/Pharo%201.1/



--
Marcus Denker  -- http://www.marcusdenker.de
INRIA Lille -- Nord Europe. Team RMoD.