Smalltalk › Pharo › Pharo Smalltalk Developers

[Pharo 7.0-dev] Build #593: 21390-Do-not-store-any-non-literals-in-the-literal-array

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

ci-pharo-ci-jenkins2

[Pharo 7.0-dev] Build #593: 21390-Do-not-store-any-non-literals-in-the-literal-array

There is a new Pharo build available!

The status of the build #593 was: SUCCESS.

The Pull Request #932 was integrated: "21390-Do-not-store-any-non-literals-in-the-literal-array"
Pull request url: https://github.com/pharo-project/pharo/pull/932

Issue Url: https://pharo.fogbugz.com/f/cases/21390
Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/593/

Marcus Denker-4

Re: [Pharo 7.0-dev] Build #593: 21390-Do-not-store-any-non-literals-in-the-literal-array

This fixes the Reflectivity compiler to not store normal objects in the literalArray… so instead of “pushLiteral:” is now uses
“pushLiteralVariable:”.

This is needed as we do now have a compiler option to compile methods with read-only literals.

Marcus

> On 22 Feb 2018, at 11:45, [hidden email] wrote:
>
> There is a new Pharo build available!
>
> The status of the build #593 was: SUCCESS.
>
> The Pull Request #932 was integrated: "21390-Do-not-store-any-non-literals-in-the-literal-array"
> Pull request url: https://github.com/pharo-project/pharo/pull/932
>
> Issue Url: https://pharo.fogbugz.com/f/cases/21390
> Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/593/

Stephane Ducasse-3

Re: [Pharo 7.0-dev] Build #593: 21390-Do-not-store-any-non-literals-in-the-literal-array

I really like this idea of read only literals :)
Tx for pushing it.

On Thu, Feb 22, 2018 at 11:52 AM, Marcus Denker <[hidden email]> wrote:

> This fixes the Reflectivity compiler to not store normal objects in the literalArray… so instead of “pushLiteral:” is now uses
> “pushLiteralVariable:”.
>
> This is needed as we do now have a compiler option to compile methods with read-only literals.
>
> Marcus
>
>> On 22 Feb 2018, at 11:45, [hidden email] wrote:
>>
>> There is a new Pharo build available!
>>
>> The status of the build #593 was: SUCCESS.
>>
>> The Pull Request #932 was integrated: "21390-Do-not-store-any-non-literals-in-the-literal-array"
>> Pull request url: https://github.com/pharo-project/pharo/pull/932
>>
>> Issue Url: https://pharo.fogbugz.com/f/cases/21390
>> Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/593/
>
>

NorbertHartl

Re: [Pharo 7.0-dev] Build #593: 21390-Do-not-store-any-non-literals-in-the-literal-array

> Am 25.02.2018 um 22:02 schrieb Stephane Ducasse <[hidden email]>:
>
> I really like this idea of read only literals :)
> Tx for pushing it.

+1

>
>> On Thu, Feb 22, 2018 at 11:52 AM, Marcus Denker <[hidden email]> wrote:
>> This fixes the Reflectivity compiler to not store normal objects in the literalArray… so instead of “pushLiteral:” is now uses
>> “pushLiteralVariable:”.
>>
>> This is needed as we do now have a compiler option to compile methods with read-only literals.
>>
>> Marcus
>>
>>> On 22 Feb 2018, at 11:45, [hidden email] wrote:
>>>
>>> There is a new Pharo build available!
>>>
>>> The status of the build #593 was: SUCCESS.
>>>
>>> The Pull Request #932 was integrated: "21390-Do-not-store-any-non-literals-in-the-literal-array"
>>> Pull request url: https://github.com/pharo-project/pharo/pull/932
>>>
>>> Issue Url: https://pharo.fogbugz.com/f/cases/21390
>>> Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/593/
>>
>>