Pharo Launcher multiplicated PhLDeploymentScript

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Pharo Launcher multiplicated PhLDeploymentScript

Peter Uhnák
Hi,

I've noticed that when I save Pharo Launcher image (ctrl+shift+s), because I was changing something, then PhLDeploymentScript is added to the the startup classes list.

PhLStartupManager startUpClasses "a SortedCollection(PhLDirectoryBasedImageRepository PhLSettingBrowser PhLDeploymentScript PhLDeploymentScript ...(atm 34x)... PhLDeploymentScript)"

PhLStartupManager startUpClasses asSet "a Set(PhLDirectoryBasedImageRepository PhLDeploymentScript PhLSettingBrowser)"

I didn't notice any impact on functionality or speed (although for some reason there is a significant delay between clicking on the PhL icon and the image opening), but nevertheless it probably should be deduplicated.

Thanks.

Peter
Reply | Threaded
Open this post in threaded view
|

Re: Pharo Launcher multiplicated PhLDeploymentScript

Peter Uhnák
PhLStartupManager class>>addToLauncherStartUpList: aClass
self startUpClasses addIfNotPresent: aClass

seems to be enough.

Peter

On Fri, Jun 29, 2018 at 9:58 AM, Peter Uhnák <[hidden email]> wrote:
Hi,

I've noticed that when I save Pharo Launcher image (ctrl+shift+s), because I was changing something, then PhLDeploymentScript is added to the the startup classes list.

PhLStartupManager startUpClasses "a SortedCollection(PhLDirectoryBasedImageRepository PhLSettingBrowser PhLDeploymentScript PhLDeploymentScript ...(atm 34x)... PhLDeploymentScript)"

PhLStartupManager startUpClasses asSet "a Set(PhLDirectoryBasedImageRepository PhLDeploymentScript PhLSettingBrowser)"

I didn't notice any impact on functionality or speed (although for some reason there is a significant delay between clicking on the PhL icon and the image opening), but nevertheless it probably should be deduplicated.

Thanks.

Peter