Pharo and Categories Importer update

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Pharo and Categories Importer update

Gustavo Santos
Hello,

I have noticed that the Category Importer was removed from Moose. I've been using the Pharo Importer instead, but there are some information missing in the model it generates (e.g., the parent package of a method). This information is important for the project I'm working on (Orion).

So, I made commit of the missing code in order to make Orion tests pass again. Does it make sense to commit on Moose to make PharoImporter work as CategoriesImporter was working before?

Regards,

--
Gustavo Santos

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Pharo and Categories Importer update

Gustavo Santos
Ok, after some inspection i found the lost code on FAMIXPackage

On Sun, Nov 23, 2014 at 11:02 AM, Gustavo Santos <[hidden email]> wrote:
Hello,

I have noticed that the Category Importer was removed from Moose. I've been using the Pharo Importer instead, but there are some information missing in the model it generates (e.g., the parent package of a method). This information is important for the project I'm working on (Orion).

So, I made commit of the missing code in order to make Orion tests pass again. Does it make sense to commit on Moose to make PharoImporter work as CategoriesImporter was working before?

Regards,

--
Gustavo Santos

--
Gustavo Santos

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Pharo and Categories Importer update

Tudor Girba-2
Hi,

I saw your commit on SmalltalkImporter, but this was wrong. A method can be packaged in a different package than its class. What exactly do you miss?

Cheers,
Doru



On Sun, Nov 23, 2014 at 4:27 PM, Gustavo Santos <[hidden email]> wrote:
Ok, after some inspection i found the lost code on FAMIXPackage

On Sun, Nov 23, 2014 at 11:02 AM, Gustavo Santos <[hidden email]> wrote:
Hello,

I have noticed that the Category Importer was removed from Moose. I've been using the Pharo Importer instead, but there are some information missing in the model it generates (e.g., the parent package of a method). This information is important for the project I'm working on (Orion).

So, I made commit of the missing code in order to make Orion tests pass again. Does it make sense to commit on Moose to make PharoImporter work as CategoriesImporter was working before?

Regards,

--
Gustavo Santos

--
Gustavo Santos

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev




--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Pharo and Categories Importer update

Gustavo Santos
I'm aware of that. I commited because it was there before :)
Anyways, I needed the information of parent packages on classes and methods, to perform refactorings with Orion. But I found that the code was migrated to FAMIXPackage>>convertPackagesFromCategories.

So yes, ignore my commit. I fixed it back in Orion

Regards

On Sun, Nov 23, 2014 at 4:50 PM, Tudor Girba <[hidden email]> wrote:
Hi,

I saw your commit on SmalltalkImporter, but this was wrong. A method can be packaged in a different package than its class. What exactly do you miss?

Cheers,
Doru



On Sun, Nov 23, 2014 at 4:27 PM, Gustavo Santos <[hidden email]> wrote:
Ok, after some inspection i found the lost code on FAMIXPackage

On Sun, Nov 23, 2014 at 11:02 AM, Gustavo Santos <[hidden email]> wrote:
Hello,

I have noticed that the Category Importer was removed from Moose. I've been using the Pharo Importer instead, but there are some information missing in the model it generates (e.g., the parent package of a method). This information is important for the project I'm working on (Orion).

So, I made commit of the missing code in order to make Orion tests pass again. Does it make sense to commit on Moose to make PharoImporter work as CategoriesImporter was working before?

Regards,

--
Gustavo Santos

--
Gustavo Santos

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev




--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


--
Gustavo Santos

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev