Pharo4 builds, WIP

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Pharo4 builds, WIP

Stephan Eggermont-3
Ok, it works. These failed build messages are annoying.

This is what I found:
- WAPharoFileLibraryTest>>testAddAllFilesIn uses ensureDirectory in
#'release3.0'
- In Issue 13739, build 40145 classesInTheSelectedPackage in Nautilus
was removed.
   That breaks WABrowserTest>>testContentsNotifying
- The slime tests that are green in the Grease builds, fail in the
Seaside builds for Pharo 4.
- WARenderLoopContinuationTest>>testExceptionHandlerNesting looks scary.

Stephan

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: Pharo4 builds, WIP

Johan Brichau-2
Thanks for scouting.

I just fixed the Slime tests in a separate package ‘Seaside-Pharo40-Slime’.
Updating the configuration will take a bit of time.

On to the exception handler… and then the configuration.

What is the verdict of the discussion in Pharo on the WABrowserTest? (did not follow that, but I thought there was advice?)

Johan

> On 24 Mar 2015, at 10:00, Stephan Eggermont <[hidden email]> wrote:
>
> Ok, it works. These failed build messages are annoying.
>
> This is what I found:
> - WAPharoFileLibraryTest>>testAddAllFilesIn uses ensureDirectory in #'release3.0'
> - In Issue 13739, build 40145 classesInTheSelectedPackage in Nautilus was removed.
>  That breaks WABrowserTest>>testContentsNotifying
> - The slime tests that are green in the Grease builds, fail in the Seaside builds for Pharo 4.
> - WARenderLoopContinuationTest>>testExceptionHandlerNesting looks scary.
>
> Stephan
>
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: Pharo4 builds, WIP

Johan Brichau-2
There is now a version 3.1.4 and 3.2.0 that should load and work cleanly on Pharo 2 through 4 [1]

testExceptionHandlerNesting is failing in Pharo 4 but I think this more an issue of the test [2].

Squeak builds for 3.2.0 are failing, however, though they already failed before I started making adaptations… anyone know about 3.2.0 on Squeak ??

Once again, several packages needed to be ‘forked’ for Pharo4:
- Seaside-Pharo-Continuation -> Seaside-Pharo40-Continuation
- Seaside-Pharo20-Tests -> Seaside-Pharo40-Tests
- Seaside-Slime -> Seaside-Pharo40-Slime

imho, the ConfigurationOfSeaside3 is in a too complex state wrt Pharo. All the different packages names and versions for the different versions of Pharo are creating understandability horror.
I suggest I rewrite the baseline methods to explicitly list each version of Pharo, rather than trying to keep common things common between the different versions of Pharo.

Obviously, this is only what the unit tests tell us. So, please try it yourself and give feedback!

Johan

[1] https://travis-ci.org/SeasideSt/Seaside/builds/57331316
[2] http://lists.squeakfoundation.org/pipermail/seaside-dev/2015-April/006399.html

> On 04 Apr 2015, at 13:16, Johan Brichau <[hidden email]> wrote:
>
> Thanks for scouting.
>
> I just fixed the Slime tests in a separate package ‘Seaside-Pharo40-Slime’.
> Updating the configuration will take a bit of time.
>
> On to the exception handler… and then the configuration.
>
> What is the verdict of the discussion in Pharo on the WABrowserTest? (did not follow that, but I thought there was advice?)
>
> Johan
>
>> On 24 Mar 2015, at 10:00, Stephan Eggermont <[hidden email]> wrote:
>>
>> Ok, it works. These failed build messages are annoying.
>>
>> This is what I found:
>> - WAPharoFileLibraryTest>>testAddAllFilesIn uses ensureDirectory in #'release3.0'
>> - In Issue 13739, build 40145 classesInTheSelectedPackage in Nautilus was removed.
>> That breaks WABrowserTest>>testContentsNotifying
>> - The slime tests that are green in the Grease builds, fail in the Seaside builds for Pharo 4.
>> - WARenderLoopContinuationTest>>testExceptionHandlerNesting looks scary.
>>
>> Stephan
>>
>> _______________________________________________
>> seaside-dev mailing list
>> [hidden email]
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: Pharo4 builds, WIP

Sven Van Caekenberghe-2
Thanks for all the work, Johan!

Sven

> On 06 Apr 2015, at 15:18, Johan Brichau <[hidden email]> wrote:
>
> There is now a version 3.1.4 and 3.2.0 that should load and work cleanly on Pharo 2 through 4 [1]
>
> testExceptionHandlerNesting is failing in Pharo 4 but I think this more an issue of the test [2].
>
> Squeak builds for 3.2.0 are failing, however, though they already failed before I started making adaptations… anyone know about 3.2.0 on Squeak ??
>
> Once again, several packages needed to be ‘forked’ for Pharo4:
> - Seaside-Pharo-Continuation -> Seaside-Pharo40-Continuation
> - Seaside-Pharo20-Tests -> Seaside-Pharo40-Tests
> - Seaside-Slime -> Seaside-Pharo40-Slime
>
> imho, the ConfigurationOfSeaside3 is in a too complex state wrt Pharo. All the different packages names and versions for the different versions of Pharo are creating understandability horror.
> I suggest I rewrite the baseline methods to explicitly list each version of Pharo, rather than trying to keep common things common between the different versions of Pharo.
>
> Obviously, this is only what the unit tests tell us. So, please try it yourself and give feedback!
>
> Johan
>
> [1] https://travis-ci.org/SeasideSt/Seaside/builds/57331316
> [2] http://lists.squeakfoundation.org/pipermail/seaside-dev/2015-April/006399.html
>
>> On 04 Apr 2015, at 13:16, Johan Brichau <[hidden email]> wrote:
>>
>> Thanks for scouting.
>>
>> I just fixed the Slime tests in a separate package ‘Seaside-Pharo40-Slime’.
>> Updating the configuration will take a bit of time.
>>
>> On to the exception handler… and then the configuration.
>>
>> What is the verdict of the discussion in Pharo on the WABrowserTest? (did not follow that, but I thought there was advice?)
>>
>> Johan
>>
>>> On 24 Mar 2015, at 10:00, Stephan Eggermont <[hidden email]> wrote:
>>>
>>> Ok, it works. These failed build messages are annoying.
>>>
>>> This is what I found:
>>> - WAPharoFileLibraryTest>>testAddAllFilesIn uses ensureDirectory in #'release3.0'
>>> - In Issue 13739, build 40145 classesInTheSelectedPackage in Nautilus was removed.
>>> That breaks WABrowserTest>>testContentsNotifying
>>> - The slime tests that are green in the Grease builds, fail in the Seaside builds for Pharo 4.
>>> - WARenderLoopContinuationTest>>testExceptionHandlerNesting looks scary.
>>>
>>> Stephan
>>>
>>> _______________________________________________
>>> seaside-dev mailing list
>>> [hidden email]
>>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>>
>
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev