[Pharo7] halt inside and outside tests

> On 4 April 2018 at 22:20, Peter Uhnák <[hidden email]> wrote:
>> If we remove self halt, then I won't be able to use `1halt.`. :-D which is
>> actually what I always do, because writing `self halt` is 4 characters tooo
>> long. :)
>>
>> On Wed, Apr 4, 2018 at 9:40 PM, Sean P. DeNigris <[hidden email]>
>> wrote:
>>>
>>> Peter Uhnák wrote
>>> > Would it be possible to instead have a #haltIf object to which you can
>>> > send
>>> > additional conditions?
>>>
>>> Maybe we could use that as an excuse to clean more halting out of object
>>> completely e.g.
>>> self halt now
>>> self halt once
>>> self halt ifInsideTest
>>> self halt ifOutsideTest
>>> self halt xyz
>>>
>>> Although IIRC when we first started cleaning the idea was too eventually
>>> remove all halt-related stuff from Object and only have `Halt xyz`. At the
>>> time, it seemed that was a little too scary, but even today I do not
>>> understand what objectively is gained by `self halt` vs. `Halt now`…
>
> One (very small) advantage of having 'self halt' is that a few times
> I've had a single, long, expression that I want to halt in, and since
> #halt returns self it is easy to insert it in the middle of an
> expression.
>
> Cheers,
> Alistair
>

>
>
> On 3 Apr 2018, at 21:56, Christophe Demarey <[hidden email]>
> wrote:
>
> Nice addition!
> I should say that names are not really intention revealing.
> What about haltIfTestExecutionEnvironment and
> haltIfDefaultExecutionEnvironment ?
>
> To long and too implementation centered.
>
> I would even shorten it to haltIfTest and haltIfNotTest.
>
> Le 2 avr. 2018 à 21:12, Marcus Denker <[hidden email]> a écrit :
>
> Hi,
>
> As we can not very easily decide if we are inside a test execution or not
> there was the idea to have special #halt messages
>
> https://pharo.fogbugz.com/f/cases/20151/new-halt-messages
>
> This PR implements them:
>
> https://github.com/pharo-project/pharo/pull/1177
>
> There is now #haltIfInsideTest and #haltfOutsideTest. In addition, the PR
> adds a helper method to make checking if the current
> execution environment is a test run a bit easier:
> "CurrentExecutionEnvironment value isTest”.
>
> Marcus
>
>
>

>
>
> On 5 Apr 2018, at 09:10, Marcus Denker <[hidden email]> wrote:
>
>
>
> On 3 Apr 2018, at 21:56, Christophe Demarey <[hidden email]>
> wrote:
>
> Nice addition!
> I should say that names are not really intention revealing.
> What about haltIfTestExecutionEnvironment and
> haltIfDefaultExecutionEnvironment ?
>
> To long and too implementation centered.
>
> I would even shorten it to haltIfTest and haltIfNotTest.
>
>
> https://github.com/pharo-project/pharo/pull/1187/files
>
> I simplified them further and added test (will be in the next build)
>
> Marcus