Pier-Documents and Pier-EditorEnh

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Pier-Documents and Pier-EditorEnh

Nick
I've saved an initial port of Pier-Documents and Pier-EditorEnh for Seaside 3.0 to the pier2 repository. I've focused on making essential changes to ensure that the packages work on Seaside 3.0, rather than all the changes necessary for the packages to work in other dialects.

One of the changes I made was to remove the image caching as:
| cache |
cache := #(nil) beMutable.
(cache at: 1) isNil ifTrue: [
cache at:  1 put: #(137 80 78 ...
        ^ cache at: 1
becomes:

 ^ #(137 80 78 ...

rational: beMutable is no longer defined and the change appeared to be inline with changes made to images elsewhere.

Be careful if you're trying to diff in MC, I found that MC disappeared into a processing back-hole when I tried to diff PRHaloScripts>>haloPng

BTW I don't understand the original caching code, but am intrigued by it. Is it explained anywhere?

Nick

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: Pier-Documents and Pier-EditorEnh

Julian Fitzell-2
It's just creating a one element literal array, which gets a slot in
the CompiledMethod. Then it says, actually I want that literal to be
mutable, and sets the value of the first element to what it wants to
cache. Bit ugly, what? :)

Julian

On Wed, Jan 13, 2010 at 1:33 AM, Nick Ager <[hidden email]> wrote:

> I've saved an initial port of Pier-Documents and Pier-EditorEnh for Seaside
> 3.0 to the pier2 repository. I've focused on making essential changes to
> ensure that the packages work on Seaside 3.0, rather than all the changes
> necessary for the packages to work in other dialects.
> One of the changes I made was to remove the image caching as:
> | cache |
> cache := #(nil) beMutable.
> (cache at: 1) isNil ifTrue: [
> cache at:  1 put: #(137 80 78 ...
>         ^ cache at: 1
> becomes:
>  ^ #(137 80 78 ...
> rational: beMutable is no longer defined and the change appeared to be
> inline with changes made to images elsewhere.
> Be careful if you're trying to diff in MC, I found that MC disappeared into
> a processing back-hole when I tried to diff PRHaloScripts>>haloPng
> BTW I don't understand the original caching code, but am intrigued by it. Is
> it explained anywhere?
> Nick
> _______________________________________________
> Magritte, Pier and Related Tools ...
> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki