Please Review 15395 ASAP

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Please Review 15395 ASAP

Sean P. DeNigris
Administrator
If someone can review this quickly, there are a ton of packages touched as you can see below and I don't want to keep redoing the slice!!!

Fix in inbox: SLICE-Issue-15395-Cleanup-1-SeanDeNigris.1

Various cleanups - most notable is applying the "a >= b and: [a <= c]" -> "a between: b and: c" everywhere; also fix typos in comments, etc.

Dependencies: AsmJit-Extension-SeanDeNigris.9, AsmJit-Operands-SeanDeNigris.15, Balloon-SeanDeNigris.119, Collections-Native-SeanDeNigris.10, Collections-Sequenceable-SeanDeNigris.193, Collections-Streams-SeanDeNigris.169, FreeType-SeanDeNigris.698, Graphics-Primitives-SeanDeNigris.158, Kernel-SeanDeNigris.2014, Morphic-Widgets-List-SeanDeNigris.16, Morphic-Widgets-Pluggable-SeanDeNigris.45, Morphic-Widgets-Tree-SeanDeNigris.28, Morphic-Widgets-Windows-SeanDeNigris.48, Multilingual-OtherLanguages-SeanDeNigris.13, Network-UUID-SeanDeNigris.30, RPackage-Core-SeanDeNigris.384, System-Platforms-SeanDeNigris.62, System-Support-SeanDeNigris.1096, Text-Core-SeanDeNigris.32
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: Please Review 15395 ASAP

Sean P. DeNigris
Administrator
Reply | Threaded
Open this post in threaded view
|

Re: Please Review 15395 ASAP

Nicolai Hess
In reply to this post by Sean P. DeNigris
+1
looks good

2015-04-24 19:42 GMT+02:00 Sean P. DeNigris <[hidden email]>:
If someone can review this quickly, there are a ton of packages touched as
you can see below and I don't want to keep redoing the slice!!!

Fix in inbox: SLICE-Issue-15395-Cleanup-1-SeanDeNigris.1

Various cleanups - most notable is applying the "a >= b and: [a <= c]" -> "a
between: b and: c" everywhere; also fix typos in comments, etc.

Dependencies: AsmJit-Extension-SeanDeNigris.9,
AsmJit-Operands-SeanDeNigris.15, Balloon-SeanDeNigris.119,
Collections-Native-SeanDeNigris.10,
Collections-Sequenceable-SeanDeNigris.193,
Collections-Streams-SeanDeNigris.169, FreeType-SeanDeNigris.698,
Graphics-Primitives-SeanDeNigris.158, Kernel-SeanDeNigris.2014,
Morphic-Widgets-List-SeanDeNigris.16,
Morphic-Widgets-Pluggable-SeanDeNigris.45,
Morphic-Widgets-Tree-SeanDeNigris.28,
Morphic-Widgets-Windows-SeanDeNigris.48,
Multilingual-OtherLanguages-SeanDeNigris.13, Network-UUID-SeanDeNigris.30,
RPackage-Core-SeanDeNigris.384, System-Platforms-SeanDeNigris.62,
System-Support-SeanDeNigris.1096, Text-Core-SeanDeNigris.32




-----
Cheers,
Sean
--
View this message in context: http://forum.world.st/Please-Review-15395-ASAP-tp4821695.html
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.