Please review Issue 7390

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Please review Issue 7390

Sean P. DeNigris
Administrator
Issue 7390: FileDialogWindow answers wrong FileReference for selected file
http://code.google.com/p/pharo/issues/detail?id=7390

This one is important because in 20503, directory repositories can not be added via the MC browser.

Steps to reproduce:
1. In MC Browser, click +Repository, choose Directory
2. Select a directory in the "File" (right) pane of the directory chooser, and accept

Problem:
The returned FileReference will be the path to the directory selected in the left pane, with a printString of a FileDirectoryEntry appended to it - i.e. garbage

Fix in inbox: SLICE-Issue-7390-FileDialogWindow-answers-wrong-FileReference-for-selected-file-SeanDeNigris.1

- Fix FileDialogWindow>>selectedAnyFileDirectory
        - return the proper FileReference when a file is selected
        - Refactor for clarity incl. adding temps
        - Clean up comment
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: Please review Issue 7390

Stéphane Ducasse
thanks!

I'm back to france and not totally leglagged nor frozen :)

Stef

On Feb 1, 2013, at 2:06 PM, Sean P. DeNigris wrote:

> Issue 7390: FileDialogWindow answers wrong FileReference for selected file
> http://code.google.com/p/pharo/issues/detail?id=7390
>
> This one is important because in 20503, directory repositories can not be
> added via the MC browser.
>
> Steps to reproduce:
> 1. In MC Browser, click +Repository, choose Directory
> 2. Select a directory in the "File" (right) pane of the directory chooser,
> and accept
>
> Problem:
> The returned FileReference will be the path to the directory selected in the
> left pane, with a printString of a FileDirectoryEntry appended to it - i.e.
> garbage
>
> Fix in inbox:
> SLICE-Issue-7390-FileDialogWindow-answers-wrong-FileReference-for-selected-file-SeanDeNigris.1
>
> - Fix FileDialogWindow>>selectedAnyFileDirectory
> - return the proper FileReference when a file is selected
> - Refactor for clarity incl. adding temps
> - Clean up comment
>
>
>
> --
> View this message in context: http://forum.world.st/Please-review-Issue-7390-tp4667063.html
> Sent from the Pharo Smalltalk mailing list archive at Nabble.com.
>