PluggableTextMorph(Object)>>does
Locked
PluggableTextMorph(Object)>>does
 
|
>> PluggableTextMorph(Object)>>doesNotUnderstand: #stylerStyled:
this is probably with a MC problem because in Issue 3486: PluggableTextMorph should be able to support text styling we payed attention to have it. http://code.google.com/p/pharo/issues/detail?id=3486 Benjamin can you have a look? Stef |
Re: PluggableTextMorph(Object)>>does
|
|
Can somebody try by defining these methods
!PluggableTextMorph methodsFor: 'zork' stamp: 'BenjaminVanRyseghem 11/25/2010 15:35'! stylerStyled: styledCopyOfText textMorph contents runs: styledCopyOfText runs . "textMorph paragraph recomposeFrom: 1 to: textMorph contents size delta: 0." "caused chars to appear in wrong order esp. in demo mode. remove this line when sure it is fixed" textMorph updateFromParagraph. selectionInterval ifNotNil:[ textMorph editor selectInvisiblyFrom: selectionInterval first to: selectionInterval last; storeSelectionInParagraph; setEmphasisHere]. textMorph editor blinkParen. self scrollSelectionIntoView ! ! !PluggableTextMorph methodsFor: 'zork' stamp: 'BenjaminVanRyseghem 11/25/2010 15:35'! stylerStyledInBackground: styledCopyOfText "It is possible that the text string has changed since the styling began. Disregard the styles if styledCopyOfText's string differs with the current textMorph contents string" textMorph contents string = styledCopyOfText string ifTrue: [self stylerStyled: styledCopyOfText]! ! I think that we found a bug in MC since the category where named: 'shout' (not with * so that the changes do not belong to the package of shout but really the one of PluggableTextMorph. On Jan 19, 2011, at 10:34 PM, Stéphane Ducasse wrote: >>> PluggableTextMorph(Object)>>doesNotUnderstand: #stylerStyled: > > > this is probably with a MC problem because in > Issue 3486: PluggableTextMorph should be able to support text styling > > we payed attention to have it. > http://code.google.com/p/pharo/issues/detail?id=3486 > > Benjamin can you have a look? > > Stef > |
Re: PluggableTextMorph(Object)>>does
|
|
I do not understand. What can I do to help?
Alexandre On 19 Jan 2011, at 18:40, Stéphane Ducasse wrote: > Can somebody try by defining these methods > > !PluggableTextMorph methodsFor: 'zork' stamp: 'BenjaminVanRyseghem 11/25/2010 15:35'! > stylerStyled: styledCopyOfText > > textMorph contents runs: styledCopyOfText runs . > "textMorph paragraph recomposeFrom: 1 to: textMorph contents size delta: 0." "caused chars to appear in wrong order esp. in demo mode. remove this line when sure it is fixed" > textMorph updateFromParagraph. > selectionInterval > ifNotNil:[ > textMorph editor > selectInvisiblyFrom: selectionInterval first to: selectionInterval last; > storeSelectionInParagraph; > setEmphasisHere]. > textMorph editor blinkParen. > self scrollSelectionIntoView > ! ! > > !PluggableTextMorph methodsFor: 'zork' stamp: 'BenjaminVanRyseghem 11/25/2010 15:35'! > stylerStyledInBackground: styledCopyOfText > "It is possible that the text string has changed since the styling began. Disregard the styles if styledCopyOfText's string differs with the current textMorph contents string" > > textMorph contents string = styledCopyOfText string > ifTrue: [self stylerStyled: styledCopyOfText]! ! > > > > I think that we found a bug in MC since the category where named: 'shout' (not with * so that the changes do not belong to the package of shout but really the one of PluggableTextMorph. > > > On Jan 19, 2011, at 10:34 PM, Stéphane Ducasse wrote: > >>>> PluggableTextMorph(Object)>>doesNotUnderstand: #stylerStyled: >> >> >> this is probably with a MC problem because in >> Issue 3486: PluggableTextMorph should be able to support text styling >> >> we payed attention to have it. >> http://code.google.com/p/pharo/issues/detail?id=3486 >> >> Benjamin can you have a look? >> >> Stef >> > > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. |
Re: PluggableTextMorph(Object)>>does
|
|
alain
mentioned that in another thread I've the same problem when I load Moose and/or Petit with the following scripts: Gofer new squeaksource: 'Moose'; package: 'ConfigurationOfMoose'; load. (Smalltalk at: #ConfigurationOfMoose) perform: #loadDefault. Gofer new renggli: 'petit'; package: 'ConfigurationOfPetitParser'; load. (Smalltalk at: #ConfigurationOfPetitParser) perform: #loadDefault. On Jan 19, 2011, at 10:43 PM, Alexandre Bergel wrote: > I do not understand. What can I do to help? > > Alexandre > > > On 19 Jan 2011, at 18:40, Stéphane Ducasse wrote: > >> Can somebody try by defining these methods >> >> !PluggableTextMorph methodsFor: 'zork' stamp: 'BenjaminVanRyseghem 11/25/2010 15:35'! >> stylerStyled: styledCopyOfText >> >> textMorph contents runs: styledCopyOfText runs . >> "textMorph paragraph recomposeFrom: 1 to: textMorph contents size delta: 0." "caused chars to appear in wrong order esp. in demo mode. remove this line when sure it is fixed" >> textMorph updateFromParagraph. >> selectionInterval >> ifNotNil:[ >> textMorph editor >> selectInvisiblyFrom: selectionInterval first to: selectionInterval last; >> storeSelectionInParagraph; >> setEmphasisHere]. >> textMorph editor blinkParen. >> self scrollSelectionIntoView >> ! ! >> >> !PluggableTextMorph methodsFor: 'zork' stamp: 'BenjaminVanRyseghem 11/25/2010 15:35'! >> stylerStyledInBackground: styledCopyOfText >> "It is possible that the text string has changed since the styling began. Disregard the styles if styledCopyOfText's string differs with the current textMorph contents string" >> >> textMorph contents string = styledCopyOfText string >> ifTrue: [self stylerStyled: styledCopyOfText]! ! >> >> >> >> I think that we found a bug in MC since the category where named: 'shout' (not with * so that the changes do not belong to the package of shout but really the one of PluggableTextMorph. >> >> >> On Jan 19, 2011, at 10:34 PM, Stéphane Ducasse wrote: >> >>>>> PluggableTextMorph(Object)>>doesNotUnderstand: #stylerStyled: >>> >>> >>> this is probably with a MC problem because in >>> Issue 3486: PluggableTextMorph should be able to support text styling >>> >>> we payed attention to have it. >>> http://code.google.com/p/pharo/issues/detail?id=3486 >>> >>> Benjamin can you have a look? >>> >>> Stef >>> >> >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > |
Re: PluggableTextMorph(Object)>>does
|
|
I got bitten by the Shout problem.
But ConfigurationOfMoose automatically loads Petit. Why loading it manually? Alexandre On 19 Jan 2011, at 18:49, Stéphane Ducasse wrote: > alain > mentioned that in another thread > > > I've the same problem when I load Moose and/or Petit with the following scripts: > > Gofer new > squeaksource: 'Moose'; > package: 'ConfigurationOfMoose'; > load. > (Smalltalk at: #ConfigurationOfMoose) perform: #loadDefault. > > Gofer new > renggli: 'petit'; > package: 'ConfigurationOfPetitParser'; > load. > (Smalltalk at: #ConfigurationOfPetitParser) perform: #loadDefault. > > > > > > On Jan 19, 2011, at 10:43 PM, Alexandre Bergel wrote: > >> I do not understand. What can I do to help? >> >> Alexandre >> >> >> On 19 Jan 2011, at 18:40, Stéphane Ducasse wrote: >> >>> Can somebody try by defining these methods >>> >>> !PluggableTextMorph methodsFor: 'zork' stamp: 'BenjaminVanRyseghem 11/25/2010 15:35'! >>> stylerStyled: styledCopyOfText >>> >>> textMorph contents runs: styledCopyOfText runs . >>> "textMorph paragraph recomposeFrom: 1 to: textMorph contents size delta: 0." "caused chars to appear in wrong order esp. in demo mode. remove this line when sure it is fixed" >>> textMorph updateFromParagraph. >>> selectionInterval >>> ifNotNil:[ >>> textMorph editor >>> selectInvisiblyFrom: selectionInterval first to: selectionInterval last; >>> storeSelectionInParagraph; >>> setEmphasisHere]. >>> textMorph editor blinkParen. >>> self scrollSelectionIntoView >>> ! ! >>> >>> !PluggableTextMorph methodsFor: 'zork' stamp: 'BenjaminVanRyseghem 11/25/2010 15:35'! >>> stylerStyledInBackground: styledCopyOfText >>> "It is possible that the text string has changed since the styling began. Disregard the styles if styledCopyOfText's string differs with the current textMorph contents string" >>> >>> textMorph contents string = styledCopyOfText string >>> ifTrue: [self stylerStyled: styledCopyOfText]! ! >>> >>> >>> >>> I think that we found a bug in MC since the category where named: 'shout' (not with * so that the changes do not belong to the package of shout but really the one of PluggableTextMorph. >>> >>> >>> On Jan 19, 2011, at 10:34 PM, Stéphane Ducasse wrote: >>> >>>>>> PluggableTextMorph(Object)>>doesNotUnderstand: #stylerStyled: >>>> >>>> >>>> this is probably with a MC problem because in >>>> Issue 3486: PluggableTextMorph should be able to support text styling >>>> >>>> we payed attention to have it. >>>> http://code.google.com/p/pharo/issues/detail?id=3486 >>>> >>>> Benjamin can you have a look? >>>> >>>> Stef >>>> >>> >>> >> >> -- >> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >> Alexandre Bergel http://www.bergel.eu >> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >> >> >> >> >> >> > > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. |
Re: PluggableTextMorph(Object)>>does
|
|
I guess this was just for testing different scenarios :)
Cheers, Doru On 19 Jan 2011, at 22:55, Alexandre Bergel wrote: > I got bitten by the Shout problem. > But ConfigurationOfMoose automatically loads Petit. Why loading it manually? > > Alexandre > > > On 19 Jan 2011, at 18:49, Stéphane Ducasse wrote: > >> alain >> mentioned that in another thread >> >> >> I've the same problem when I load Moose and/or Petit with the following scripts: >> >> Gofer new >> squeaksource: 'Moose'; >> package: 'ConfigurationOfMoose'; >> load. >> (Smalltalk at: #ConfigurationOfMoose) perform: #loadDefault. >> >> Gofer new >> renggli: 'petit'; >> package: 'ConfigurationOfPetitParser'; >> load. >> (Smalltalk at: #ConfigurationOfPetitParser) perform: #loadDefault. >> >> >> >> >> >> On Jan 19, 2011, at 10:43 PM, Alexandre Bergel wrote: >> >>> I do not understand. What can I do to help? >>> >>> Alexandre >>> >>> >>> On 19 Jan 2011, at 18:40, Stéphane Ducasse wrote: >>> >>>> Can somebody try by defining these methods >>>> >>>> !PluggableTextMorph methodsFor: 'zork' stamp: 'BenjaminVanRyseghem 11/25/2010 15:35'! >>>> stylerStyled: styledCopyOfText >>>> >>>> textMorph contents runs: styledCopyOfText runs . >>>> "textMorph paragraph recomposeFrom: 1 to: textMorph contents size delta: 0." "caused chars to appear in wrong order esp. in demo mode. remove this line when sure it is fixed" >>>> textMorph updateFromParagraph. >>>> selectionInterval >>>> ifNotNil:[ >>>> textMorph editor >>>> selectInvisiblyFrom: selectionInterval first to: selectionInterval last; >>>> storeSelectionInParagraph; >>>> setEmphasisHere]. >>>> textMorph editor blinkParen. >>>> self scrollSelectionIntoView >>>> ! ! >>>> >>>> !PluggableTextMorph methodsFor: 'zork' stamp: 'BenjaminVanRyseghem 11/25/2010 15:35'! >>>> stylerStyledInBackground: styledCopyOfText >>>> "It is possible that the text string has changed since the styling began. Disregard the styles if styledCopyOfText's string differs with the current textMorph contents string" >>>> >>>> textMorph contents string = styledCopyOfText string >>>> ifTrue: [self stylerStyled: styledCopyOfText]! ! >>>> >>>> >>>> >>>> I think that we found a bug in MC since the category where named: 'shout' (not with * so that the changes do not belong to the package of shout but really the one of PluggableTextMorph. >>>> >>>> >>>> On Jan 19, 2011, at 10:34 PM, Stéphane Ducasse wrote: >>>> >>>>>>> PluggableTextMorph(Object)>>doesNotUnderstand: #stylerStyled: >>>>> >>>>> >>>>> this is probably with a MC problem because in >>>>> Issue 3486: PluggableTextMorph should be able to support text styling >>>>> >>>>> we payed attention to have it. >>>>> http://code.google.com/p/pharo/issues/detail?id=3486 >>>>> >>>>> Benjamin can you have a look? >>>>> >>>>> Stef >>>>> >>>> >>>> >>> >>> -- >>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >>> Alexandre Bergel http://www.bergel.eu >>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >>> >>> >>> >>> >>> >>> >> >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > -- www.tudorgirba.com "What is more important: To be happy, or to make happy?" |
Re: PluggableTextMorph(Object)>>does
|
|
In reply to this post by Alexandre Bergel
Can you check if with the fix it works?
The rest is not my concern. I need to know to integrate them or not. Stef On Jan 19, 2011, at 10:55 PM, Alexandre Bergel wrote: > I got bitten by the Shout problem. > But ConfigurationOfMoose automatically loads Petit. Why loading it manually? > > Alexandre > > > On 19 Jan 2011, at 18:49, Stéphane Ducasse wrote: > >> alain >> mentioned that in another thread >> >> >> I've the same problem when I load Moose and/or Petit with the following scripts: >> >> Gofer new >> squeaksource: 'Moose'; >> package: 'ConfigurationOfMoose'; >> load. >> (Smalltalk at: #ConfigurationOfMoose) perform: #loadDefault. >> >> Gofer new >> renggli: 'petit'; >> package: 'ConfigurationOfPetitParser'; >> load. >> (Smalltalk at: #ConfigurationOfPetitParser) perform: #loadDefault. >> >> >> >> >> >> On Jan 19, 2011, at 10:43 PM, Alexandre Bergel wrote: >> >>> I do not understand. What can I do to help? >>> >>> Alexandre >>> >>> >>> On 19 Jan 2011, at 18:40, Stéphane Ducasse wrote: >>> >>>> Can somebody try by defining these methods >>>> >>>> !PluggableTextMorph methodsFor: 'zork' stamp: 'BenjaminVanRyseghem 11/25/2010 15:35'! >>>> stylerStyled: styledCopyOfText >>>> >>>> textMorph contents runs: styledCopyOfText runs . >>>> "textMorph paragraph recomposeFrom: 1 to: textMorph contents size delta: 0." "caused chars to appear in wrong order esp. in demo mode. remove this line when sure it is fixed" >>>> textMorph updateFromParagraph. >>>> selectionInterval >>>> ifNotNil:[ >>>> textMorph editor >>>> selectInvisiblyFrom: selectionInterval first to: selectionInterval last; >>>> storeSelectionInParagraph; >>>> setEmphasisHere]. >>>> textMorph editor blinkParen. >>>> self scrollSelectionIntoView >>>> ! ! >>>> >>>> !PluggableTextMorph methodsFor: 'zork' stamp: 'BenjaminVanRyseghem 11/25/2010 15:35'! >>>> stylerStyledInBackground: styledCopyOfText >>>> "It is possible that the text string has changed since the styling began. Disregard the styles if styledCopyOfText's string differs with the current textMorph contents string" >>>> >>>> textMorph contents string = styledCopyOfText string >>>> ifTrue: [self stylerStyled: styledCopyOfText]! ! >>>> >>>> >>>> >>>> I think that we found a bug in MC since the category where named: 'shout' (not with * so that the changes do not belong to the package of shout but really the one of PluggableTextMorph. >>>> >>>> >>>> On Jan 19, 2011, at 10:34 PM, Stéphane Ducasse wrote: >>>> >>>>>>> PluggableTextMorph(Object)>>doesNotUnderstand: #stylerStyled: >>>>> >>>>> >>>>> this is probably with a MC problem because in >>>>> Issue 3486: PluggableTextMorph should be able to support text styling >>>>> >>>>> we payed attention to have it. >>>>> http://code.google.com/p/pharo/issues/detail?id=3486 >>>>> >>>>> Benjamin can you have a look? >>>>> >>>>> Stef >>>>> >>>> >>>> >>> >>> -- >>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >>> Alexandre Bergel http://www.bergel.eu >>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >>> >>> >>> >>> >>> >>> >> >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > |
Re: PluggableTextMorph(Object)>>does
|
|
It works ! It works !
Laurent On Thu, Jan 20, 2011 at 7:51 AM, Stéphane Ducasse <[hidden email]> wrote: Can you check if with the fix it works? |
Re: PluggableTextMorph(Object)>>does
|
|
One problem though: syntax highlighting is activated everywhere: text fields, dev workspace, help system ....
Laurent
On Thu, Jan 20, 2011 at 8:08 AM, laurent laffont <[hidden email]> wrote: It works ! It works ! |
Re: PluggableTextMorph(Object)>>does
|
|
In reply to this post by laurent laffont
the same here, it works.
Now I can load Petit. Thanks Alain Le 20/01/2011 08:08, laurent laffont a écrit : > It works ! It works ! > > Laurent > > |
Re: PluggableTextMorph(Object)>>does
|
|
Thanks Laurent and Alain for testing this.
Cheers, Doru On 20 Jan 2011, at 08:21, Alain Plantec wrote: > the same here, it works. > Now I can load Petit. > Thanks > Alain > > Le 20/01/2011 08:08, laurent laffont a écrit : >> It works ! It works ! >> >> Laurent >> >> > > > -- www.tudorgirba.com "Live like you mean it." |
Re: PluggableTextMorph(Object)>>does
|
|
Other error: https://pharo-ic.lille.inria.fr/hudson/view/Pharo/job/Pharo%201.2/71/console
duplicatedVariableError: styler is already defined in PluggableTextMorph Laurent
On Thu, Jan 20, 2011 at 8:38 AM, Tudor Girba <[hidden email]> wrote: Thanks Laurent and Alain for testing this. |
Re: PluggableTextMorph(Object)>>does
|
|
We probably need to remove that variable from PluggableShoutMorph. This variable does not exist in Pharo 1.2 12292.
Cheers, Doru On 20 Jan 2011, at 09:11, laurent laffont wrote: > Other error: https://pharo-ic.lille.inria.fr/hudson/view/Pharo/job/Pharo%201.2/71/console > > > duplicatedVariableError: styler is already defined in PluggableTextMorph > > > Laurent > > On Thu, Jan 20, 2011 at 8:38 AM, Tudor Girba <[hidden email]> wrote: > Thanks Laurent and Alain for testing this. > > Cheers, > Doru > > > On 20 Jan 2011, at 08:21, Alain Plantec wrote: > > > the same here, it works. > > Now I can load Petit. > > Thanks > > Alain > > > > Le 20/01/2011 08:08, laurent laffont a écrit : > >> It works ! It works ! > >> > >> Laurent > >> > >> > > > > > > > > -- > www.tudorgirba.com > > "Live like you mean it." > > > -- www.tudorgirba.com "Presenting is storytelling." |
Re: PluggableTextMorph(Object)>>does
|
|
In fact, PluggableShoutMorph shouldn't be used anymore, but PluggableTextMorph instead now that PluggableTextMorph handle the text styling :)
Ben On Jan 20, 2011, at 9:34 AM, Tudor Girba wrote: > We probably need to remove that variable from PluggableShoutMorph. This variable does not exist in Pharo 1.2 12292. > > Cheers, > Doru > > > On 20 Jan 2011, at 09:11, laurent laffont wrote: > >> Other error: https://pharo-ic.lille.inria.fr/hudson/view/Pharo/job/Pharo%201.2/71/console >> >> >> duplicatedVariableError: styler is already defined in PluggableTextMorph >> >> >> Laurent >> >> On Thu, Jan 20, 2011 at 8:38 AM, Tudor Girba <[hidden email]> wrote: >> Thanks Laurent and Alain for testing this. >> >> Cheers, >> Doru >> >> >> On 20 Jan 2011, at 08:21, Alain Plantec wrote: >> >>> the same here, it works. >>> Now I can load Petit. >>> Thanks >>> Alain >>> >>> Le 20/01/2011 08:08, laurent laffont a écrit : >>>> It works ! It works ! >>>> >>>> Laurent >>>> >>>> >>> >>> >>> >> >> -- >> www.tudorgirba.com >> >> "Live like you mean it." >> >> >> > > -- > www.tudorgirba.com > > "Presenting is storytelling." > > |
Re: PluggableTextMorph(Object)>>does
|
|
Yes, but I guess code still depends on this class. So, at the very least the class should still be preserved for one version.
Cheers, Doru On 20 Jan 2011, at 11:05, Benjamin wrote: > In fact, PluggableShoutMorph shouldn't be used anymore, but PluggableTextMorph instead now that PluggableTextMorph handle the text styling :) > > > Ben > > > On Jan 20, 2011, at 9:34 AM, Tudor Girba wrote: > >> We probably need to remove that variable from PluggableShoutMorph. This variable does not exist in Pharo 1.2 12292. >> >> Cheers, >> Doru >> >> >> On 20 Jan 2011, at 09:11, laurent laffont wrote: >> >>> Other error: https://pharo-ic.lille.inria.fr/hudson/view/Pharo/job/Pharo%201.2/71/console >>> >>> >>> duplicatedVariableError: styler is already defined in PluggableTextMorph >>> >>> >>> Laurent >>> >>> On Thu, Jan 20, 2011 at 8:38 AM, Tudor Girba <[hidden email]> wrote: >>> Thanks Laurent and Alain for testing this. >>> >>> Cheers, >>> Doru >>> >>> >>> On 20 Jan 2011, at 08:21, Alain Plantec wrote: >>> >>>> the same here, it works. >>>> Now I can load Petit. >>>> Thanks >>>> Alain >>>> >>>> Le 20/01/2011 08:08, laurent laffont a écrit : >>>>> It works ! It works ! >>>>> >>>>> Laurent >>>>> >>>>> >>>> >>>> >>>> >>> >>> -- >>> www.tudorgirba.com >>> >>> "Live like you mean it." >>> >>> >>> >> >> -- >> www.tudorgirba.com >> >> "Presenting is storytelling." >> >> > > -- www.tudorgirba.com "It's not how it is, it is how we see it." |
Re: PluggableTextMorph(Object)>>does
|
|
Yes, code depends of this class, but this class inherits from PluggableTextMorph, so we can just remove everything in it, and just keep the name to keep the system working (and maybe move this class in the package Deprecated)
Ben On Jan 20, 2011, at 11:09 AM, Tudor Girba wrote: > Yes, but I guess code still depends on this class. So, at the very least the class should still be preserved for one version. > > Cheers, > Doru > > > On 20 Jan 2011, at 11:05, Benjamin wrote: > >> In fact, PluggableShoutMorph shouldn't be used anymore, but PluggableTextMorph instead now that PluggableTextMorph handle the text styling :) >> >> >> Ben >> >> >> On Jan 20, 2011, at 9:34 AM, Tudor Girba wrote: >> >>> We probably need to remove that variable from PluggableShoutMorph. This variable does not exist in Pharo 1.2 12292. >>> >>> Cheers, >>> Doru >>> >>> >>> On 20 Jan 2011, at 09:11, laurent laffont wrote: >>> >>>> Other error: https://pharo-ic.lille.inria.fr/hudson/view/Pharo/job/Pharo%201.2/71/console >>>> >>>> >>>> duplicatedVariableError: styler is already defined in PluggableTextMorph >>>> >>>> >>>> Laurent >>>> >>>> On Thu, Jan 20, 2011 at 8:38 AM, Tudor Girba <[hidden email]> wrote: >>>> Thanks Laurent and Alain for testing this. >>>> >>>> Cheers, >>>> Doru >>>> >>>> >>>> On 20 Jan 2011, at 08:21, Alain Plantec wrote: >>>> >>>>> the same here, it works. >>>>> Now I can load Petit. >>>>> Thanks >>>>> Alain >>>>> >>>>> Le 20/01/2011 08:08, laurent laffont a écrit : >>>>>> It works ! It works ! >>>>>> >>>>>> Laurent >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>> >>>> -- >>>> www.tudorgirba.com >>>> >>>> "Live like you mean it." >>>> >>>> >>>> >>> >>> -- >>> www.tudorgirba.com >>> >>> "Presenting is storytelling." >>> >>> >> >> > > -- > www.tudorgirba.com > > "It's not how it is, it is how we see it." > > |
Re: PluggableTextMorph(Object)>>does
|
|
Yes we should do that.
let it and deprecate all the methods or remove the methods if they are in the superclass. Ben apparently monticello is bogus and the methods we moved from *soup to soup were removed from the class :( Stef On Jan 20, 2011, at 11:19 AM, Benjamin wrote: > Yes, code depends of this class, but this class inherits from PluggableTextMorph, so we can just remove everything in it, and just keep the name to keep the system working (and maybe move this class in the package Deprecated) > > > Ben > > On Jan 20, 2011, at 11:09 AM, Tudor Girba wrote: > >> Yes, but I guess code still depends on this class. So, at the very least the class should still be preserved for one version. >> >> Cheers, >> Doru >> >> >> On 20 Jan 2011, at 11:05, Benjamin wrote: >> >>> In fact, PluggableShoutMorph shouldn't be used anymore, but PluggableTextMorph instead now that PluggableTextMorph handle the text styling :) >>> >>> >>> Ben >>> >>> >>> On Jan 20, 2011, at 9:34 AM, Tudor Girba wrote: >>> >>>> We probably need to remove that variable from PluggableShoutMorph. This variable does not exist in Pharo 1.2 12292. >>>> >>>> Cheers, >>>> Doru >>>> >>>> >>>> On 20 Jan 2011, at 09:11, laurent laffont wrote: >>>> >>>>> Other error: https://pharo-ic.lille.inria.fr/hudson/view/Pharo/job/Pharo%201.2/71/console >>>>> >>>>> >>>>> duplicatedVariableError: styler is already defined in PluggableTextMorph >>>>> >>>>> >>>>> Laurent >>>>> >>>>> On Thu, Jan 20, 2011 at 8:38 AM, Tudor Girba <[hidden email]> wrote: >>>>> Thanks Laurent and Alain for testing this. >>>>> >>>>> Cheers, >>>>> Doru >>>>> >>>>> >>>>> On 20 Jan 2011, at 08:21, Alain Plantec wrote: >>>>> >>>>>> the same here, it works. >>>>>> Now I can load Petit. >>>>>> Thanks >>>>>> Alain >>>>>> >>>>>> Le 20/01/2011 08:08, laurent laffont a écrit : >>>>>>> It works ! It works ! >>>>>>> >>>>>>> Laurent >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>>> -- >>>>> www.tudorgirba.com >>>>> >>>>> "Live like you mean it." >>>>> >>>>> >>>>> >>>> >>>> -- >>>> www.tudorgirba.com >>>> >>>> "Presenting is storytelling." >>>> >>>> >>> >>> >> >> -- >> www.tudorgirba.com >> >> "It's not how it is, it is how we see it." >> >> > > |
Re: PluggableTextMorph(Object)>>does
|
|
Strange ...
For PluggableShoutMorph, all the expected behavior is now in PluugableTextMorph, so I will try to remove everything, just to see if it works ^^ (but first let's finish the list stuff ;) ) Ben On Jan 20, 2011, at 11:51 AM, Stéphane Ducasse wrote: > Yes we should do that. > let it and deprecate all the methods or remove the methods if they are in the superclass. > Ben apparently monticello is bogus and the methods we moved from *soup to soup were removed from the class :( > > Stef > > On Jan 20, 2011, at 11:19 AM, Benjamin wrote: > >> Yes, code depends of this class, but this class inherits from PluggableTextMorph, so we can just remove everything in it, and just keep the name to keep the system working (and maybe move this class in the package Deprecated) >> >> >> Ben >> >> On Jan 20, 2011, at 11:09 AM, Tudor Girba wrote: >> >>> Yes, but I guess code still depends on this class. So, at the very least the class should still be preserved for one version. >>> >>> Cheers, >>> Doru >>> >>> >>> On 20 Jan 2011, at 11:05, Benjamin wrote: >>> >>>> In fact, PluggableShoutMorph shouldn't be used anymore, but PluggableTextMorph instead now that PluggableTextMorph handle the text styling :) >>>> >>>> >>>> Ben >>>> >>>> >>>> On Jan 20, 2011, at 9:34 AM, Tudor Girba wrote: >>>> >>>>> We probably need to remove that variable from PluggableShoutMorph. This variable does not exist in Pharo 1.2 12292. >>>>> >>>>> Cheers, >>>>> Doru >>>>> >>>>> >>>>> On 20 Jan 2011, at 09:11, laurent laffont wrote: >>>>> >>>>>> Other error: https://pharo-ic.lille.inria.fr/hudson/view/Pharo/job/Pharo%201.2/71/console >>>>>> >>>>>> >>>>>> duplicatedVariableError: styler is already defined in PluggableTextMorph >>>>>> >>>>>> >>>>>> Laurent >>>>>> >>>>>> On Thu, Jan 20, 2011 at 8:38 AM, Tudor Girba <[hidden email]> wrote: >>>>>> Thanks Laurent and Alain for testing this. >>>>>> >>>>>> Cheers, >>>>>> Doru >>>>>> >>>>>> >>>>>> On 20 Jan 2011, at 08:21, Alain Plantec wrote: >>>>>> >>>>>>> the same here, it works. >>>>>>> Now I can load Petit. >>>>>>> Thanks >>>>>>> Alain >>>>>>> >>>>>>> Le 20/01/2011 08:08, laurent laffont a écrit : >>>>>>>> It works ! It works ! >>>>>>>> >>>>>>>> Laurent >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> www.tudorgirba.com >>>>>> >>>>>> "Live like you mean it." >>>>>> >>>>>> >>>>>> >>>>> >>>>> -- >>>>> www.tudorgirba.com >>>>> >>>>> "Presenting is storytelling." >>>>> >>>>> >>>> >>>> >>> >>> -- >>> www.tudorgirba.com >>> >>> "It's not how it is, it is how we see it." >>> >>> >> >> > > |
«
Return to Pharo Smalltalk Developers
|
1 view|%1 views
| Free forum by Nabble | Edit this page |