PolyMath 1.0

Nobody to help ?

On Tue, Apr 10, 2018 at 4:47 PM Serge Stinckwich <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="Omk9XU3nBgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">serge.st...@...> wrote:

dear all,

I would like to push PolyMath 1.0 before ESUG 2018.

I create a milestone on github with some issues:
<a href="https://github.com/PolyMathOrg/PolyMath/issues?q=is%3Aopen+is%3Aissue+milestone%3A%221.0+%28codename+Cagliari%29%22" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fissues%3Fq%3Dis%253Aopen%2Bis%253Aissue%2Bmilestone%253A%25221.0%2B%2528codename%2BCagliari%2529%2522\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHVZ_JfPGnsyZUv3iGsAXCH3zdWZg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fissues%3Fq%3Dis%253Aopen%2Bis%253Aissue%2Bmilestone%253A%25221.0%2B%2528codename%2BCagliari%2529%2522\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHVZ_JfPGnsyZUv3iGsAXCH3zdWZg&#39;;return true;">https://github.com/PolyMathOrg/PolyMath/issues?q=is%3Aopen+is%3Aissue+milestone%3A%221.0+%28codename+Cagliari%29%22

Do you want to add more ?

Who want to help ?

Thank you.

​Regards,​

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/

On Wed, Jun 27, 2018 at 4:12 PM Hemal Varambhia <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="4zJ3FJnWBgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">h.n.va...@...> wrote:

Hi, Serge.

​hi Hemal,

​

I loaded the project on to my distribution of Pharo. I ran the PMPolynomialsTest and noticed the testPolynomialNumberAdditionInverse are failing.

​There is some red tests in last CI:

<a href="https://travis-ci.org/PolyMathOrg/PolyMath" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZDxneEIkt-NPouFomoy47uS2suA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZDxneEIkt-NPouFomoy47uS2suA&#39;;return true;">https://travis-ci.org/PolyMathOrg/PolyMath

​but this is method is green on my computer. Are you running on Pharo 6.1 ? Which computer ?

I'd love to work on getting this passing. Is this something that needs to be ready for v1.0 of PolyMath? If so, do I just create an issue and get going?

​Yes sure, ​you are welcome to create an issue if there is test failure.

For the release v1.0, we want all tests to be green :-)

I'm new to Smalltalk (I've been toying with it for 6 months but part-time) and I would love to contribute in some way to your project.

​This is great ! There is lot of tasks that can be done even for a Pharo beginner :-)

​Thank you for your contribution to PolyMath !​

​A+​

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/

ok, this is better to try PolyMath on Pharo 6.1 or Pharo 7.0.

On Wed, Jun 27, 2018 at 4:32 PM Hemal Varambhia <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="31QiTY7XBgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">h.n.va...@...> wrote:

Hi, Serge.

I should have been clearer, sorry. It turns out that I'm running Pharo 6.0 when I look at the system's 'about' window. I'll try to update first! I'm running my distribution on Ubuntu 16.04. The test was failing because it claims that instances of PMPolynomials are not Indexable. Let me get back to you.

Hemal

On Wednesday, June 27, 2018 at 4:22:55 PM UTC+1, Serge Stinckwich wrote:

On Wed, Jun 27, 2018 at 4:12 PM Hemal Varambhia <[hidden email]> wrote:

Hi, Serge.

​hi Hemal,

​

I loaded the project on to my distribution of Pharo. I ran the PMPolynomialsTest and noticed the testPolynomialNumberAdditionInverse are failing.

​There is some red tests in last CI:

<a href="https://travis-ci.org/PolyMathOrg/PolyMath" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZDxneEIkt-NPouFomoy47uS2suA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZDxneEIkt-NPouFomoy47uS2suA&#39;;return true;">https://travis-ci.org/PolyMathOrg/PolyMath

​but this is method is green on my computer. Are you running on Pharo 6.1 ? Which computer ?

I'd love to work on getting this passing. Is this something that needs to be ready for v1.0 of PolyMath? If so, do I just create an issue and get going?

​Yes sure, ​you are welcome to create an issue if there is test failure.

For the release v1.0, we want all tests to be green :-)

I'm new to Smalltalk (I've been toying with it for 6 months but part-time) and I would love to contribute in some way to your project.

​This is great ! There is lot of tasks that can be done even for a Pharo beginner :-)

​Thank you for your contribution to PolyMath !​

​A+​

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" rel="nofollow" target="_blank" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="31QiTY7XBgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">polymath-proje...@googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/

You have been added !

On Thu, Jun 28, 2018 at 7:19 PM Hemal Varambhia <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="zBOvtjUxBwAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">h.n.va...@...> wrote:

Hi, Serge

My github ID is hemalvarambhia. Thank you for adding me.

Hemal

On Thu, 28 Jun 2018, 9:51 am Serge Stinckwich, <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="zBOvtjUxBwAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">serge.st...@...> wrote:

ok thank you Hemal for your help !

Can you wait a little bit ? Stephane should move the code on github and should avoid to commit code during that time.

Do you have a github ID so I add you to the PolyMath org ?

Regards,

On Wed, Jun 27, 2018 at 7:07 PM Hemal Varambhia <<a href="javascript:" rel="nofollow" target="_blank" gdf-obfuscated-mailto="zBOvtjUxBwAJ" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">h.n.va...@...> wrote:

Serge,

Of course you're right. The test is green now.

I would like to try 

<a href="https://github.com/PolyMathOrg/PolyMath/issues/48" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fissues%2F48\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHVY9YSOmfpc0cKhGMkRyyN00WWxw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Fissues%2F48\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHVY9YSOmfpc0cKhGMkRyyN00WWxw&#39;;return true;">https://github.com/PolyMathOrg/PolyMath/issues/48 - it seems not to have been assigned to anyone yet and it feels like something I could do. Where do I go from here in terms of workflow and submitting code?

Hemal

On Wednesday, June 27, 2018 at 4:40:28 PM UTC+1, Serge Stinckwich wrote:

ok, this is better to try PolyMath on Pharo 6.1 or Pharo 7.0.

On Wed, Jun 27, 2018 at 4:32 PM Hemal Varambhia <[hidden email]> wrote:

Hi, Serge.

I should have been clearer, sorry. It turns out that I'm running Pharo 6.0 when I look at the system's 'about' window. I'll try to update first! I'm running my distribution on Ubuntu 16.04. The test was failing because it claims that instances of PMPolynomials are not Indexable. Let me get back to you.

Hemal

On Wednesday, June 27, 2018 at 4:22:55 PM UTC+1, Serge Stinckwich wrote:

On Wed, Jun 27, 2018 at 4:12 PM Hemal Varambhia <[hidden email]> wrote:

Hi, Serge.

​hi Hemal,

​

I loaded the project on to my distribution of Pharo. I ran the PMPolynomialsTest and noticed the testPolynomialNumberAdditionInverse are failing.

​There is some red tests in last CI:

<a href="https://travis-ci.org/PolyMathOrg/PolyMath" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZDxneEIkt-NPouFomoy47uS2suA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Ftravis-ci.org%2FPolyMathOrg%2FPolyMath\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZDxneEIkt-NPouFomoy47uS2suA&#39;;return true;">https://travis-ci.org/PolyMathOrg/PolyMath

​but this is method is green on my computer. Are you running on Pharo 6.1 ? Which computer ?

I'd love to work on getting this passing. Is this something that needs to be ready for v1.0 of PolyMath? If so, do I just create an issue and get going?

​Yes sure, ​you are welcome to create an issue if there is test failure.

For the release v1.0, we want all tests to be green :-)

I'm new to Smalltalk (I've been toying with it for 6 months but part-time) and I would love to contribute in some way to your project.

​This is great ! There is lot of tasks that can be done even for a Pharo beginner :-)

​Thank you for your contribution to PolyMath !​

​A+​

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" rel="nofollow" target="_blank" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to polymath-proje...@googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" rel="nofollow" target="_blank" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" rel="nofollow" target="_blank" gdf-obfuscated-mailto="zBOvtjUxBwAJ" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">polymath-proje...@googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" rel="nofollow" target="_blank" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" rel="nofollow" target="_blank" gdf-obfuscated-mailto="zBOvtjUxBwAJ" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">polymath-proje...@googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "PolyMath" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="zBOvtjUxBwAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">polymath-proje...@googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/

On Sun, Jul 1, 2018 at 10:33 AM Hemal Varambhia <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="U2XLmQtbCAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">h.n.va...@...> wrote:

Dear Serge,

​Dear Hemal,

​

 

I have question around the workflow for contributing code to PolyMath. I've assigned myself an issue now (#48). I am aware I should publish a PR for the issue I'm working on, but should I branch off of master, since there's no development branch yet?

​At the moment there is no dev branch. We will do one before the 1.0 version release I guess.

Until now, you can fork the main branch and send PR on this branch.

Regards,

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/

Dear Serge,

That's awesome. Thank you. I've created a branch from master 

<a href="https://github.com/PolyMathOrg/PolyMath/tree/hemalvarambhia-issue-48" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Ftree%2Fhemalvarambhia-issue-48\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEbN5EV_RJg4GB-ZKEKZ9GfEB55PA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FPolyMathOrg%2FPolyMath%2Ftree%2Fhemalvarambhia-issue-48\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEbN5EV_RJg4GB-ZKEKZ9GfEB55PA&#39;;return true;">https://github.com/PolyMathOrg/PolyMath/tree/hemalvarambhia-issue-48. 

I moved the QuaternionExtension class and instance messages over to the Quaternion package over two commits (I wanted to take microsteps). I ran the tests on Pharo and they're still green. Would the next step be to just delete the Math-QuaternionExtensions package from the file system entirely?

Hemal

On Monday, July 2, 2018 at 3:01:17 PM UTC+1, Serge Stinckwich wrote:

On Sun, Jul 1, 2018 at 10:33 AM Hemal Varambhia <[hidden email]> wrote:

Dear Serge,

​Dear Hemal,

​

 

I have question around the workflow for contributing code to PolyMath. I've assigned myself an issue now (#48). I am aware I should publish a PR for the issue I'm working on, but should I branch off of master, since there's no development branch yet?

​At the moment there is no dev branch. We will do one before the 1.0 version release I guess.

Until now, you can fork the main branch and send PR on this branch.

Regards,

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" rel="nofollow" target="_blank" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/

On Mon, Jul 2, 2018 at 11:03 PM Hemal Varambhia <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="eaE1_--WCAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">h.n.va...@...> wrote:

Serge,

I guess, just in case I wasn't clear. would I now, following my two commits on the said branch, be able to 'Remove the package from disk,' as per the Iceberg option?

​I don't understand sorry ?

Yes we have to remove the package.

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/

Hi, Serge

As you mentioned in the PR, I have now merged the packages specified in QuaternionExtensions into Quaternion in the BaselineOfPolyMath class, and deleted the QuanternionExtensions package from the project entirely. I just pushed my changes up to the remote branch.

However, I found one reference to the QuaternionExtensions package in the BaselineOfPolyMath class in the groups section:

group: 'Extensions' with: #('Math-Clustering' 'Math-Number-Extensions' 'Math-QuaternionExtensions' 'Math-Chromosome' 'Math-PrincipalComponentAnalysis' 'Math-FunctionFit'

Can that item in the array (Math-QuaternionExtensions) be removed as well?

Otherwise I think the PR is ready for review. 

Again, thank you for taking the time to help me and answering my (presumeably very basic) questions. Hopefully they weren't too annoying!

Hemal

On Tuesday, July 3, 2018 at 9:18:49 AM UTC+1, Serge Stinckwich wrote:

On Mon, Jul 2, 2018 at 11:03 PM Hemal Varambhia <[hidden email]> wrote:

Serge,

I guess, just in case I wasn't clear. would I now, following my two commits on the said branch, be able to 'Remove the package from disk,' as per the Iceberg option?

​I don't understand sorry ?

Yes we have to remove the package.

--

Serge Stinckwich
UMI UMMISCO 209 (SU/IRD/UY1)

"Programs must be written for people to read, and only incidentally for machines to execute."

<a href="http://www.doesnotunderstand.org/" rel="nofollow" target="_blank" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fwww.doesnotunderstand.org%2F\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEmratUCplMDry5gDXSals1R-iPLw&#39;;return true;">http://www.doesnotunderstand.org/