Possible bug with <ul> generation?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Possible bug with <ul> generation?

Rick Flower
I ran across this last night when perusing the generated code in my
test-web-app I've been working on (debugging firefox css issues I had)..
I have a block of code that populates an unordered list (for the Canvas
API).. The unordered list will contain the contents of a shopping cart.
  In this case if that cart is empty, I should effectively get (in my
opinion) an empty list.. However, what I got was a single "</ul>" and
nothing more.. I did not get the opening html tag (e.g. <ul>).. I'm
guessing that the generation of that may be tied to the generation of a
<li> item perhaps.. I've not bothered looking at the code yet.. In this
case I fixed my problem and first check to see if my list is empty or
not -- if it is then I skip that entire unordered list generation block
thereby getting around the problem.

Anyway, this is by no means an issue for me and perhaps that's the way
this is supposed to work, but I thought I'd see if anyone thought it
might be a bug or not..

If you need some sample code, I could probably modify one of the
standard Seaside tests pretty easily..

P.S. I'm using Seaside 2.6b1.129.0 (1/19/2007) if that helps..


_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
Reply | Threaded
Open this post in threaded view
|

Re: Possible bug with <ul> generation?

Michel Bany

On 06 Feb 2007, at 16:13 , Rick Flower wrote:

> I ran across this last night when perusing the generated code in my  
> test-web-app I've been working on (debugging firefox css issues I  
> had).. I have a block of code that populates an unordered list (for  
> the Canvas API).. The unordered list will contain the contents of a  
> shopping cart.  In this case if that cart is empty, I should  
> effectively get (in my opinion) an empty list.. However, what I got  
> was a single "</ul>" and nothing more.. I did not get the opening  
> html tag (e.g. <ul>).. I'm guessing that the generation of that may  
> be tied to the generation of a <li> item perhaps.. I've not  
> bothered looking at the code yet.. In this case I fixed my problem  
> and first check to see if my list is empty or not -- if it is then  
> I skip that entire unordered list generation block thereby getting  
> around the problem.
>
> Anyway, this is by no means an issue for me and perhaps that's the  
> way this is supposed to work, but I thought I'd see if anyone  
> thought it might be a bug or not..
>
> If you need some sample code, I could probably modify one of the  
> standard Seaside tests pretty easily..

Yes, please supply some sample code that produces the symptom.
I tried it hard here and could not come up with a case.
TIA
Michel.

>
> P.S. I'm using Seaside 2.6b1.129.0 (1/19/2007) if that helps..
>
>
> _______________________________________________
> Seaside mailing list
> [hidden email]
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
Reply | Threaded
Open this post in threaded view
|

Re: Possible bug with <ul> generation?

Philippe Marschall
In reply to this post by Rick Flower
2007/2/6, Rick Flower <[hidden email]>:
> I ran across this last night when perusing the generated code in my
> test-web-app I've been working on (debugging firefox css issues I had)..
> I have a block of code that populates an unordered list (for the Canvas
> API).. The unordered list will contain the contents of a shopping cart.
>   In this case if that cart is empty, I should effectively get (in my
> opinion) an empty list..

Wouldn't that be invalid? ul is defined in the XHTML DTD as:
<!ELEMENT ul (li)+>
what means is has to have one or more il child nodes.

Philippe

> However, what I got was a single "</ul>" and
> nothing more.. I did not get the opening html tag (e.g. <ul>).. I'm
> guessing that the generation of that may be tied to the generation of a
> <li> item perhaps.. I've not bothered looking at the code yet.. In this
> case I fixed my problem and first check to see if my list is empty or
> not -- if it is then I skip that entire unordered list generation block
> thereby getting around the problem.
>
> Anyway, this is by no means an issue for me and perhaps that's the way
> this is supposed to work, but I thought I'd see if anyone thought it
> might be a bug or not..
>
> If you need some sample code, I could probably modify one of the
> standard Seaside tests pretty easily..
>
> P.S. I'm using Seaside 2.6b1.129.0 (1/19/2007) if that helps..
>
>
> _______________________________________________
> Seaside mailing list
> [hidden email]
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
>
_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
Reply | Threaded
Open this post in threaded view
|

Re: Possible bug with <ul> generation?

Rick Flower
Philippe Marschall wrote:

> 2007/2/6, Rick Flower <[hidden email]>:
>> I ran across this last night when perusing the generated code in my
>> test-web-app I've been working on (debugging firefox css issues I had)..
>> I have a block of code that populates an unordered list (for the Canvas
>> API).. The unordered list will contain the contents of a shopping cart.
>>   In this case if that cart is empty, I should effectively get (in my
>> opinion) an empty list..
>
> Wouldn't that be invalid? ul is defined in the XHTML DTD as:
> <!ELEMENT ul (li)+>
> what means is has to have one or more il child nodes.

Sounds reasonable -- If that's the case, then perhaps the code could be
smart enough to know that no <li> tags have been generated and not
bother generating the parent <ul></ul> tag-pairs either.. However, that
sounds like a lot more work than it's really worth to me and possibly
a case where the code could perhaps get confused and do the wrong thing
I suppose (the old keep-it-simple adage)
_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
Reply | Threaded
Open this post in threaded view
|

Re: Possible bug with <ul> generation?

Rick Flower
In reply to this post by Michel Bany
Michel Bany wrote:

> Yes, please supply some sample code that produces the symptom.
> I tried it hard here and could not come up with a case.

Michel --

Sorry.. I was able to repro the problem in my code, but upon further
investigation I see the tag as not being </ul>, but being <ul/> which
I believe is correct (even though there is no content).. So, I think
that exonerates Seaside and I'll leave it as a bad coding problem on
my part..  Sorry..



_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
Reply | Threaded
Open this post in threaded view
|

RE: Possible bug with <ul> generation?

Boris Popov, DeepCove Labs (SNN)
In reply to this post by Philippe Marschall
It is indeed technically invalid, one shouldn't be creating lists
without list elements, this snippet fails to validate for exact this
reason,

Line 8 column 8: end tag for "ul" which is not finished.

<html xmlns="http://www.w3.org/1999/xhtml" lang="en" xml:lang="en">
<head>
<title>Title</title>
</head>
<body>
<ul></ul>
</body>
</html>

with all 3 xhtml doctypes,

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
   "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
   "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN"
   "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd">

as well as 3 html doctypes,

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"
   "http://www.w3.org/TR/html4/strict.dtd">
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
   "http://www.w3.org/TR/html4/loose.dtd">
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Frameset//EN"
   "http://www.w3.org/TR/html4/frameset.dtd">

-Boris

--
+1.604.689.0322
DeepCove Labs Ltd.
4th floor 595 Howe Street
Vancouver, Canada V6C 2T5
http://tinyurl.com/r7uw4

[hidden email]

CONFIDENTIALITY NOTICE

This email is intended only for the persons named in the message
header. Unless otherwise indicated, it contains information that is
private and confidential. If you have received it in error, please
notify the sender and delete the entire message including any
attachments.

Thank you.

-----Original Message-----
From: [hidden email]
[mailto:[hidden email]] On Behalf Of
Philippe Marschall
Sent: Tuesday, February 06, 2007 8:48 AM
To: The Squeak Enterprise Aubergines Server - general discussion.
Subject: Re: [Seaside] Possible bug with <ul> generation?

2007/2/6, Rick Flower <[hidden email]>:
> I ran across this last night when perusing the generated code in my
> test-web-app I've been working on (debugging firefox css issues I
had)..
> I have a block of code that populates an unordered list (for the
Canvas
> API).. The unordered list will contain the contents of a shopping
cart.
>   In this case if that cart is empty, I should effectively get (in my
> opinion) an empty list..

Wouldn't that be invalid? ul is defined in the XHTML DTD as:
<!ELEMENT ul (li)+>
what means is has to have one or more il child nodes.

Philippe

> However, what I got was a single "</ul>" and
> nothing more.. I did not get the opening html tag (e.g. <ul>).. I'm
> guessing that the generation of that may be tied to the generation of
a
> <li> item perhaps.. I've not bothered looking at the code yet.. In
this
> case I fixed my problem and first check to see if my list is empty or
> not -- if it is then I skip that entire unordered list generation
block

> thereby getting around the problem.
>
> Anyway, this is by no means an issue for me and perhaps that's the way
> this is supposed to work, but I thought I'd see if anyone thought it
> might be a bug or not..
>
> If you need some sample code, I could probably modify one of the
> standard Seaside tests pretty easily..
>
> P.S. I'm using Seaside 2.6b1.129.0 (1/19/2007) if that helps..
>
>
> _______________________________________________
> Seaside mailing list
> [hidden email]
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
>
_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
Reply | Threaded
Open this post in threaded view
|

Re: Possible bug with <ul> generation?

Rick Flower
Boris Popov wrote:
> It is indeed technically invalid, one shouldn't be creating lists
> without list elements, this snippet fails to validate for exact this
> reason,

Thanks Boris.. (8->

I've already fixed my code so it does the "right" thing in this
situation.. I'll keep my mouth shut next time until I can fully verify
my problem..
_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
Reply | Threaded
Open this post in threaded view
|

RE: Possible bug with <ul> generation?

Boris Popov, DeepCove Labs (SNN)
Oh I would personally prefer to see *more* questions on the list
regardless, because they are often things that others overlook. That,
plus don't underestimate the value of being able to search the mailing
list in the future.

Thanks!

-Boris

--
+1.604.689.0322
DeepCove Labs Ltd.
4th floor 595 Howe Street
Vancouver, Canada V6C 2T5
http://tinyurl.com/r7uw4

[hidden email]

CONFIDENTIALITY NOTICE

This email is intended only for the persons named in the message
header. Unless otherwise indicated, it contains information that is
private and confidential. If you have received it in error, please
notify the sender and delete the entire message including any
attachments.

Thank you.

-----Original Message-----
From: [hidden email]
[mailto:[hidden email]] On Behalf Of Rick
Flower
Sent: Tuesday, February 06, 2007 11:03 AM
To: The Squeak Enterprise Aubergines Server - general discussion.
Subject: Re: [Seaside] Possible bug with <ul> generation?

Boris Popov wrote:
> It is indeed technically invalid, one shouldn't be creating lists
> without list elements, this snippet fails to validate for exact this
> reason,

Thanks Boris.. (8->

I've already fixed my code so it does the "right" thing in this
situation.. I'll keep my mouth shut next time until I can fully verify
my problem..
_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
_______________________________________________
Seaside mailing list
[hidden email]
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside