Problem (and PR fix!) with `deleteClient` in latest GsDevKit_home release

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Problem (and PR fix!) with `deleteClient` in latest GsDevKit_home release

GLASS mailing list
Hi Dale,

Look at this execution:

 ❯ ./deleteClient tode2                                                                                                                                                                                                                                            
=================
   GsDevKit script: deleteClient tode2
              path: ./deleteClient
=================
/opt/gemstoneAdditions/GsDevKit_home/dev/todeClient/bin/deleteClient tode2
./deleteClient: line 51: /opt/gemstoneAdditions/GsDevKit_home/dev/todeClient/bin/deleteClient tode2: No such file or directory
Error on or near line 46 :: deleteClient tode2 :: deleteClient tode2


 ❯ /opt/gemstoneAdditions/GsDevKit_home/dev/todeClient/bin/deleteClient tode2         
=================
   GsDevKit script: deleteClient tode2
              path: /opt/gemstoneAdditions/GsDevKit_home/dev/todeClient/bin/deleteClient
=================
...finished :: deleteClient tode2

 
In other words, `deleteClient` fails but calling the internal dev script it works. I found the culprit to be the quotes to make the cmd executable path. 

I made a PR  [1] ..let's see if my fix works too in the rest of the OSes

Cheers,



--

_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass
Reply | Threaded
Open this post in threaded view
|

Re: Problem (and PR fix!) with `deleteClient` in latest GsDevKit_home release

GLASS mailing list

Just merge the deleteClient fix from Mariano[1] ... Thanks Mariano!

  Fixed deleteClients not working on OSX with quotes for execution CMD #198

Since it is a new issue I recommend that folks update their GsDevKit_home checkout to pick up the fix:

  updateGsDevKit -g

Since it is a script update, nothing else needs to be done ...

Dale

[1] https://github.com/GsDevKit/GsDevKit_home/pull/198


On 11/21/17 5:30 AM, Mariano Martinez Peck via Glass wrote:
Hi Dale,

Look at this execution:

 ❯ ./deleteClient tode2                                                                                                                                                                                                                                            
=================
   GsDevKit script: deleteClient tode2
              path: ./deleteClient
=================
/opt/gemstoneAdditions/GsDevKit_home/dev/todeClient/bin/deleteClient tode2
./deleteClient: line 51: /opt/gemstoneAdditions/GsDevKit_home/dev/todeClient/bin/deleteClient tode2: No such file or directory
Error on or near line 46 :: deleteClient tode2 :: deleteClient tode2


 ❯ /opt/gemstoneAdditions/GsDevKit_home/dev/todeClient/bin/deleteClient tode2         
=================
   GsDevKit script: deleteClient tode2
              path: /opt/gemstoneAdditions/GsDevKit_home/dev/todeClient/bin/deleteClient
=================
...finished :: deleteClient tode2

 
In other words, `deleteClient` fails but calling the internal dev script it works. I found the culprit to be the quotes to make the cmd executable path. 

I made a PR  [1] ..let's see if my fix works too in the rest of the OSes

Cheers,



--


_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass


_______________________________________________
Glass mailing list
[hidden email]
http://lists.gemtalksystems.com/mailman/listinfo/glass