Problem loading new class comments

I am working on https://pharo.fogbugz.com/f/cases/16893/Update-STON and I noticed that class comments did not update, even if they are changed.

Specifically, the class comments of ConfigurationOfSton and STONWriter did definitively change, I can see the changed comments in the MC code browser, but when I load the code, the comments stay the same, both in Nautilus as using the #comment message.

#50591

Sven

On 19 Feb 2016, at 22:19, Sven Van Caekenberghe <[hidden email]> wrote:

On 19 Feb 2016, at 22:06, Nicolai Hess <[hidden email]> wrote:



2016-02-19 15:37 GMT+01:00 Sven Van Caekenberghe <[hidden email]>:
I am working on https://pharo.fogbugz.com/f/cases/16893/Update-STON and I noticed that class comments did not update, even if they are changed.

Specifically, the class comments of ConfigurationOfSton and STONWriter did definitively change, I can see the changed comments in the MC code browser, but when I load the code, the comments stay the same, both in Nautilus as using the #comment message.

#50591

!!!!!
There are two changes in the behavior how packages are loaded - somewhere, don't know what exactly.
See my analysis
17655 Changes in package loading behavior
I don't know how many changed class comments got lost since Pharo-50497 !

Thanks for looking into this, Nicolai.

This strikes me as an important bug, not because I reported it, but because we silently lose code. And because we have to test to guard us against such loss of functionality.

Yes, it seems that for Spur, some code in the class builder was reverted. (e.g. all the code related to migrating classes with Slots)

So yes, we have to merge the changes back.

Marcus