Problem with Author

Hi folks: I think I found a little bug with the Author refactor. To reproduce:

1) Open Monticello browser
2) select a package you modified something, select a repository and press save
3) The popup asking you the full name and surename is opened. The thing is that if you press cancel, it closes the popup but another one is opened :(   yo have no other choice that put "ok"

Can anyone reproduce this ? If so, I'll open a bug ticket.

Best,

Mariano

El lun, 17-08-2009 a las 16:42 -0300, Mariano Martinez Peck escribió:

> Hi folks: I think I found a little bug with the Author refactor. To
> reproduce:
>
> 1) Open Monticello browser
> 2) select a package you modified something, select a repository and
> press save
> 3) The popup asking you the full name and surename is opened. The
> thing is that if you press cancel, it closes the popup but another one
> is opened :(   yo have no other choice that put "ok"
>

Yes, this is how the original prompt for initials worked before the
rewrite, I didn't modify it.
The thinkg is, it keeps asking until you enter something.

If you could press cancel, when you do other modification, it will
prompt again, so I prefer to keep the old behavior of a continuous
asking for full name.

But this could be changed, of course. What should be the behavior?

> Can anyone reproduce this ? If so, I'll open a bug ticket.
>
> Best,
>
> Mariano

> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
--

Miguel Cobá
http://miguel.leugim.com.mx

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

> I suppose you refer to the last time you enter your name on *other*
> image as if it is the same image, it won't ask for the full name as
> already have it.

Exact.

> I think that someone (maybe you) asked for the capability of storing
> the
> full name on the computer disk and if found it will pre-fill the
> prompt.

That was an idea yes.

> I can add this to the author code, but just need to ask if:
> - is there a convention for storing squeak/pharo settings e.g. in
> linux
> could be a .squeak/ or .pharo/ folder on the $HOME of the user. In
> windows I suppose that in my documents but I really don't use it so I
> don't know.

I would not rely on this. I usually have my images a bit everywhere.
and move frequently them around.

> - is there a convention for storing this files besides the
> image/changes/sources files. This is as the current pharo/squeak
> works,
> I think.

next to the image will make me happy.

> - the preference browser has the capability of storing the preferences
> in a file. Maybe this could be reused and include the full name and
> try
> to read from there on first full name prompt.

Could be yes

> Will be useful to other users to have this, supposing the they change
> image often, or the hassle of writing by hand once for image it is
> negligible?

It will be useful for me yes

Alexandre

>
>> Like this, I just have to press 'Ok'.
>>
>> Alexandre
>>
> --
> Miguel Cobá
> http://miguel.leugim.com.mx
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.






_______________________________________________

Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

El lun, 17-08-2009 a las 18:13 -0300, Mariano Martinez Peck escribió:

>
>
> 2009/8/17 Miguel Enrique Cobá Martinez <[hidden email]>
>         El lun, 17-08-2009 a las 16:42 -0300, Mariano Martinez Peck
>         escribió:
>         > Hi folks: I think I found a little bug with the Author
>         refactor. To
>         > reproduce:
>         >
>         > 1) Open Monticello browser
>         > 2) select a package you modified something, select a
>         repository and
>         > press save
>         > 3) The popup asking you the full name and surename is
>         opened. The
>         > thing is that if you press cancel, it closes the popup but
>         another one
>         > is opened :(   yo have no other choice that put "ok"
>         >
>
>         Yes, this is how the original prompt for initials worked
>         before the
>         rewrite, I didn't modify it.
>         The thinkg is, it keeps asking until you enter something.
>
>         If you could press cancel, when you do other modification, it
>         will
>         prompt again, so I prefer to keep the old behavior of a
>         continuous
>         asking for full name.
>
>         But this could be changed, of course. What should be the
>         behavior?
>
> The behavior must be just cancel. Close the popup and do nothing. Not
> to open the popup again.
>
>

But this maybe can brake other parts, as the generation of signature for
methods. Supposing that the Author class let the cancel proceed. This
will necessarily to store nil or '' in the fullName inst var of Author.
the calling code (in this case, the evaluate part of the browser or the
debug windows where you modified some code) won't know that the author
hasn't stored the name correctly, so it will procedd as if were. Then
when saving the method/exporting to mc/generating the signature of the
method maybe will go on the assumption that there is a name stored.
Well you get the idea. Maybe I am exaggerating but will be necessary to
review the code using Author to see what will happen if a '' or nil is
stored there.

Of course also can be true that nothing wrong happens (at least with a
nil stored the next time it will prompt again for a full name).

What say the community? :)

>
>
>         > Can anyone reproduce this ? If so, I'll open a bug ticket.
>         >
>         > Best,
>         >
>         > Mariano
>
>         > _______________________________________________
>         > Pharo-project mailing list
>         > [hidden email]
>         >
>         http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>         --
>
>         Miguel Cobá
>         http://miguel.leugim.com.mx
>
>
>
>         _______________________________________________
>         Pharo-project mailing list
>         [hidden email]
>         http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
--
Miguel Cobá
http://miguel.leugim.com.mx


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project