Problem with FileSystem primitives in latest Pharo2.0

> Hi, i found an error in the latest Pharo2.0 build, at least in OSX ,
> that prevents from using Gofer and monticello.
>
> Its related to the FileSystem primitives, when trying to delete a file.
>
> To reproduce evaluate the following code ( change 'PharoDebug.log' for
> any existing file in the same directory as the image).
>
> | path |
> path := FileSystem disk workingDirectory.
> p := FilePluginPrims new .
> p  deleteDirectory: (path / 'PharoDebug.log') fullName.
>
>
> Any idea why?
>
> Thanks,
> Fernando
>

> Hi, i found an error in the latest Pharo2.0 build, at least in OSX ,
> that prevents from using Gofer and monticello.
>
> Its related to the FileSystem primitives, when trying to delete a file.
>
> To reproduce evaluate the following code ( change 'PharoDebug.log' for
> any existing file in the same directory as the image).
>
> | path |
> path := FileSystem disk workingDirectory.
> p := FilePluginPrims new .
> p  deleteDirectory: (path / 'PharoDebug.log') fullName.
>
>
> Any idea why?
>
> Thanks,
> Fernando
>

> Are you using a current VM from Jenkins?
>
> I think FileSystem needs some fixes in the Vm File plugin...
>
> On Jul 4, 2012, at 9:23 AM, Fernando Olivero wrote:
>
>> Hi, i found an error in the latest Pharo2.0 build, at least in OSX ,
>> that prevents from using Gofer and monticello.
>>
>> Its related to the FileSystem primitives, when trying to delete a file.
>>
>> To reproduce evaluate the following code ( change 'PharoDebug.log' for
>> any existing file in the same directory as the image).
>>
>> | path |
>> path := FileSystem disk workingDirectory.
>> p := FilePluginPrims new .
>> p  deleteDirectory: (path / 'PharoDebug.log') fullName.
>>
>>
>> Any idea why?
>>
>> Thanks,
>> Fernando
>>
>
> --
> Marcus Denker -- http://marcusdenker.de
>

> Yes, i'm using the latest VM's from Jenkins.
>
> I've tried with both Cog and NB vm's.
>
> It appears to be related to the (internal) FilePlugin, did esteban
> make changes to it?
>
> Surely this happened to somebody else? When trying to load/merge/commit ?
>
> Fernando
>
>
> On Wed, Jul 4, 2012 at 9:28 AM, Marcus Denker <[hidden email]> wrote:
>> Are you using a current VM from Jenkins?
>>
>> I think FileSystem needs some fixes in the Vm File plugin...
>>
>> On Jul 4, 2012, at 9:23 AM, Fernando Olivero wrote:
>>
>>> Hi, i found an error in the latest Pharo2.0 build, at least in OSX ,
>>> that prevents from using Gofer and monticello.
>>>
>>> Its related to the FileSystem primitives, when trying to delete a file.
>>>
>>> To reproduce evaluate the following code ( change 'PharoDebug.log' for
>>> any existing file in the same directory as the image).
>>>
>>> | path |
>>> path := FileSystem disk workingDirectory.
>>> p := FilePluginPrims new .
>>> p  deleteDirectory: (path / 'PharoDebug.log') fullName.
>>>
>>>
>>> Any idea why?
>>>
>>> Thanks,
>>> Fernando
>>>
>>
>> --
>> Marcus Denker -- http://marcusdenker.de
>>
>

> Yes, i'm using the latest VM's from Jenkins.
>
> I've tried with both Cog and NB vm's.
>
> It appears to be related to the (internal) FilePlugin, did esteban
> make changes to it?
>
> Surely this happened to somebody else? When trying to load/merge/commit ?
>
> Fernando
>
>
> On Wed, Jul 4, 2012 at 9:28 AM, Marcus Denker <[hidden email]> wrote:
>> Are you using a current VM from Jenkins?
>>
>> I think FileSystem needs some fixes in the Vm File plugin...
>>
>> On Jul 4, 2012, at 9:23 AM, Fernando Olivero wrote:
>>
>>> Hi, i found an error in the latest Pharo2.0 build, at least in OSX ,
>>> that prevents from using Gofer and monticello.
>>>
>>> Its related to the FileSystem primitives, when trying to delete a file.
>>>
>>> To reproduce evaluate the following code ( change 'PharoDebug.log' for
>>> any existing file in the same directory as the image).
>>>
>>> | path |
>>> path := FileSystem disk workingDirectory.
>>> p := FilePluginPrims new .
>>> p  deleteDirectory: (path / 'PharoDebug.log') fullName.
>>>
>>>
>>> Any idea why?
>>>
>>> Thanks,
>>> Fernando
>>>
>>
>> --
>> Marcus Denker -- http://marcusdenker.de
>>
>

> Hi Sven, yes is working.
>
> I found the error. Try evaluating the code WHEN the file is un-existing.
>
> 2 timesRepeat:[ (FileSystem disk workingDirectory /
> 'unexistingFileForTesting.txt') delete ].
>
> I will try to fix it,
>
> The initial problem was that monticello is trying to delete an
> un-existing mcz file in the package-cache.
> Strange that nobody else had this problem before.
>
> Fernando
>
>
> On Wed, Jul 4, 2012 at 9:32 AM, [hidden email]
> <[hidden email]> wrote:
>> Yes, i'm using the latest VM's from Jenkins.
>>
>> I've tried with both Cog and NB vm's.
>>
>> It appears to be related to the (internal) FilePlugin, did esteban
>> make changes to it?
>>
>> Surely this happened to somebody else? When trying to load/merge/commit ?
>>
>> Fernando
>>
>>
>> On Wed, Jul 4, 2012 at 9:28 AM, Marcus Denker <[hidden email]> wrote:
>>> Are you using a current VM from Jenkins?
>>>
>>> I think FileSystem needs some fixes in the Vm File plugin...
>>>
>>> On Jul 4, 2012, at 9:23 AM, Fernando Olivero wrote:
>>>
>>>> Hi, i found an error in the latest Pharo2.0 build, at least in OSX ,
>>>> that prevents from using Gofer and monticello.
>>>>
>>>> Its related to the FileSystem primitives, when trying to delete a file.
>>>>
>>>> To reproduce evaluate the following code ( change 'PharoDebug.log' for
>>>> any existing file in the same directory as the image).
>>>>
>>>> | path |
>>>> path := FileSystem disk workingDirectory.
>>>> p := FilePluginPrims new .
>>>> p  deleteDirectory: (path / 'PharoDebug.log') fullName.
>>>>
>>>>
>>>> Any idea why?
>>>>
>>>> Thanks,
>>>> Fernando
>>>>
>>>
>>> --
>>> Marcus Denker -- http://marcusdenker.de
>>>
>>
>

> I wanted to provide the following fix to the previous problem: to
> check wether a file exists before deleting it.
>
> FileSystem>>delete: aResolvable
> aResolvable asFileReference exists ifTrue:[ store delete: (self
> resolve: aResolvable) ]
>
> But i found that the following is working incorrectly:
>
> (FileSystem disk workingDirectory / 'unexistingFileForTesting.txt')
> asFileReference exists = true
>
>
> Esteban, maybe this is the cause of problems? Was it like this before?
>
>
> Fernando
>
>
> On Wed, Jul 4, 2012 at 9:42 AM, [hidden email]
> <[hidden email]> wrote:
>> Hi Sven, yes is working.
>>
>> I found the error. Try evaluating the code WHEN the file is un-existing.
>>
>> 2 timesRepeat:[ (FileSystem disk workingDirectory /
>> 'unexistingFileForTesting.txt') delete ].
>>
>> I will try to fix it,
>>
>> The initial problem was that monticello is trying to delete an
>> un-existing mcz file in the package-cache.
>> Strange that nobody else had this problem before.
>>
>> Fernando
>>
>>
>> On Wed, Jul 4, 2012 at 9:32 AM, [hidden email]
>> <[hidden email]> wrote:
>>> Yes, i'm using the latest VM's from Jenkins.
>>>
>>> I've tried with both Cog and NB vm's.
>>>
>>> It appears to be related to the (internal) FilePlugin, did esteban
>>> make changes to it?
>>>
>>> Surely this happened to somebody else? When trying to load/merge/commit ?
>>>
>>> Fernando
>>>
>>>
>>> On Wed, Jul 4, 2012 at 9:28 AM, Marcus Denker <[hidden email]> wrote:
>>>> Are you using a current VM from Jenkins?
>>>>
>>>> I think FileSystem needs some fixes in the Vm File plugin...
>>>>
>>>> On Jul 4, 2012, at 9:23 AM, Fernando Olivero wrote:
>>>>
>>>>> Hi, i found an error in the latest Pharo2.0 build, at least in OSX ,
>>>>> that prevents from using Gofer and monticello.
>>>>>
>>>>> Its related to the FileSystem primitives, when trying to delete a file.
>>>>>
>>>>> To reproduce evaluate the following code ( change 'PharoDebug.log' for
>>>>> any existing file in the same directory as the image).
>>>>>
>>>>> | path |
>>>>> path := FileSystem disk workingDirectory.
>>>>> p := FilePluginPrims new .
>>>>> p  deleteDirectory: (path / 'PharoDebug.log') fullName.
>>>>>
>>>>>
>>>>> Any idea why?
>>>>>
>>>>> Thanks,
>>>>> Fernando
>>>>>
>>>>
>>>> --
>>>> Marcus Denker -- http://marcusdenker.de
>>>>
>>>
>>
>

>
> On 04 Jul 2012, at 09:51, Fernando Olivero wrote:
>
>> But i found that the following is working incorrectly:
>>
>> (FileSystem disk workingDirectory / 'unexistingFileForTesting.txt')
>> asFileReference exists = true
>
> Hmm, that would be a serious problem, I am using that as well,
>
>         (FileSystem disk workingDirectory / 'unexistingFileForTesting.txt') exists
>
> gives false for me ;-)
>
> And this works as well:
>
>         2 timesRepeat:[ (FileSystem disk workingDirectory /
>                 'unexistingFileForTesting.txt') delete ].
>
> Is there a unit test covering your problem ?
> If not, there should be.
>
> Sven

> Yes, i'm using the latest.
>
> VM:  https://ci.lille.inria.fr/pharo/job/Cog-VM/Architecture=32,OS=mac/58/
>
> Sven, are you using Mac OSX ?
>
> Esteban replied that's a known bug, (unexisting file giving tue on
> #exists) maybe its implied that'solely for the Mac ?
>
> I will do an unit test to capture this issue.
>
> Fernando
>
>
> On Wed, Jul 4, 2012 at 10:44 AM, Sven Van Caekenberghe <[hidden email]> wrote:
>>
>> On 04 Jul 2012, at 09:51, Fernando Olivero wrote:
>>
>>> But i found that the following is working incorrectly:
>>>
>>> (FileSystem disk workingDirectory / 'unexistingFileForTesting.txt')
>>> asFileReference exists = true
>>
>> Hmm, that would be a serious problem, I am using that as well,
>>
>>        (FileSystem disk workingDirectory / 'unexistingFileForTesting.txt') exists
>>
>> gives false for me ;-)
>>
>> And this works as well:
>>
>>        2 timesRepeat:[ (FileSystem disk workingDirectory /
>>                'unexistingFileForTesting.txt') delete ].
>>
>> Is there a unit test covering your problem ?
>> If not, there should be.
>>
>> Sven
>

> Yes, i'm using the latest.
>
> VM:  https://ci.lille.inria.fr/pharo/job/Cog-VM/Architecture=32,OS=mac/58/
>
> Sven, are you using Mac OSX ?
>
> Esteban replied that's a known bug, (unexisting file giving tue on
> #exists) maybe its implied that'solely for the Mac ?
>
> I will do an unit test to capture this issue.
>
> Fernando

> Fernando be sure to get rid of all the old vms on OSX :P
> OSX is particularly good in finding an old version somewhere that does not properly work :P
>
> On 2012-07-04, at 10:54, Fernando Olivero wrote:
>
>> Yes, i'm using the latest.
>>
>> VM:  https://ci.lille.inria.fr/pharo/job/Cog-VM/Architecture=32,OS=mac/58/
>>
>> Sven, are you using Mac OSX ?
>>
>> Esteban replied that's a known bug, (unexisting file giving tue on
>> #exists) maybe its implied that'solely for the Mac ?
>>
>> I will do an unit test to capture this issue.
>>
>> Fernando