Problem with amberc

Hi!

Which version of Amber are you using?

Nico

Dave Mason <[hidden email]> writes:

> A few developers are working on the same code.  We're using mercurial as
> the VCS.  Currently we have the js directory in the repository, but merging
> js is painful and, frankly, stupid - it's like putting exe files in a
> repository!
>
> It would be easy to put a hook in mercurial so that it would automatically
> run amberc on an update from the repository.  However, that doesn't work
> because amberc gives the following error:
>
> Reading file st/Kit.st
>
> /Users/dmason/Ryerson/p4ru/kit/amberc.9XS5BF/compiler.js:412
> throw(error);
>       ^
> SyntaxError: Unexpected reserved word
>     at smalltalk.addMethod.smalltalk.method.fn
> (/Users/dmason/Ryerson/p4ru/kit/amberc.9XS5BF/compiler.js:18389:13)
>     at withContextSend
> (/Users/dmason/Ryerson/p4ru/kit/amberc.9XS5BF/compiler.js:426:18)
>     at Smalltalk.st.send
> (/Users/dmason/Ryerson/p4ru/kit/amberc.9XS5BF/compiler.js:403:11)
>     at smalltalk.addMethod.smalltalk.method.fn
> (/Users/dmason/Ryerson/p4ru/kit/amberc.9XS5BF/compiler.js:18426:21)
>     at withContextSend
> (/Users/dmason/Ryerson/p4ru/kit/amberc.9XS5BF/compiler.js:426:18)
>     at Smalltalk.st.send
> (/Users/dmason/Ryerson/p4ru/kit/amberc.9XS5BF/compiler.js:403:11)
>     at smalltalk.addMethod.smalltalk.method.fn
> (/Users/dmason/Ryerson/p4ru/kit/amberc.9XS5BF/compiler.js:6517:11)
>     at withContextSend
> (/Users/dmason/Ryerson/p4ru/kit/amberc.9XS5BF/compiler.js:426:18)
>     at Smalltalk.st.send
> (/Users/dmason/Ryerson/p4ru/kit/amberc.9XS5BF/compiler.js:403:11)
>     at smalltalk.addMethod.smalltalk.method.fn
> (/Users/dmason/Ryerson/p4ru/kit/amberc.9XS5BF/compiler.js:6556:18)
> Failed compilation of Kit.js, exiting.
>
> I presume this is my problem, not amber's, which is why I didn't file this
> as a bug.  I presume I have some reserved word, but am surprised that the
> browser-side compiler didn't see it (this st file has been developed from
> scratch on using amber)  I include Kit.st as an attachment.
>
>
> ../Dave
>

> --
> You received this message because you are subscribed to the Google Groups "amber-lang" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

--
Nicolas Petton
http://nicolas-petton.fr

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.

Great!  Thanks!

How did you figure this out?  I tried to track it down, but all I found was that it was trying to eval this giant string...

../Dave

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Manfred,

Could you report an issue about this one? The compiler *should always*
escape this variable names :)

Nico

Manfred Kröhnert <[hidden email]> writes:

> Hi Dave,
>
> well, from the error it was somehow clear to me that it was a JavaScript
> and not a Smalltalk error.
> So a few weeks ago I was going through the compiler classes to see how they
> work together.
> From there I knew that .st files get parsed and evaluated in chunks which
> are enclosed by exclamation marks.
>
> Now, getting the compiler to emit the relevant information probably needs
> some deeper changes in the compiler classes.
> Instead, I just added a logging statement in the Smalltalk>>basicParse:
> method to print the current chunk to parse.
> When it stopped at this specific piece of code changing the name of the
> temporary variable did the trick.
>
> What is left now is to actually investigate why the variable name wasn't
> escaped correctly in this situation.
>
> Best,
> Manfred
>
>
> On Tue, Feb 5, 2013 at 3:52 AM, Dave Mason <[hidden email]> wrote:
>
>> Great!  Thanks!
>>
>> How did you figure this out?  I tried to track it down, but all I found
>> was that it was trying to eval this giant string...
>>
>> ../Dave
>>
>>  --
>> You received this message because you are subscribed to the Google Groups
>> "amber-lang" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [hidden email].
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>>
>
> --
> You received this message because you are subscribed to the Google Groups "amber-lang" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

--
Nicolas Petton
http://nicolas-petton.fr