Pull Request 20898-MultiByteFileStream-upToAll-does-not-work-correctly-with-UTF-8

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
bpi
Reply | Threaded
Open this post in threaded view
|

Pull Request 20898-MultiByteFileStream-upToAll-does-not-work-correctly-with-UTF-8

bpi
Hi all,

Can somebody please help me get my bugfix from December integrated? For some reason CI fails and I have no idea how to debug that. :-(
https://github.com/pharo-project/pharo/pull/632

Bernhard
Reply | Threaded
Open this post in threaded view
|

Re: Pull Request 20898-MultiByteFileStream-upToAll-does-not-work-correctly-with-UTF-8

Stephane Ducasse-3
Hi bernhard

sorry. Yes we should have a look.

Stef

On Sun, Feb 25, 2018 at 4:12 PM, Bernhard Pieber <[hidden email]> wrote:
> Hi all,
>
> Can somebody please help me get my bugfix from December integrated? For some reason CI fails and I have no idea how to debug that. :-(
> https://github.com/pharo-project/pharo/pull/632
>
> Bernhard

Reply | Threaded
Open this post in threaded view
|

Re: Pull Request 20898-MultiByteFileStream-upToAll-does-not-work-correctly-with-UTF-8

Guillermo Polito
Well, It looks like when you read tonel files with your changes there are some "invisible"  characters left over in the stream.

I think that first you should be able to reproduce the issue locally without bootstrapping by trying to import a tonel file in an image with your changes.
Just take any of the files inside Pharo's src/ directory and try:

reader := TonelReader on: stream fileName: '...'.
reader loadDefinitions.

Once with the monticello definitions you can try to compile them or check if the source code in the methods have something strange...

If that fails, come back and we can do a skype trying to show you how to bootstrap :)
Guille

On Sun, Feb 25, 2018 at 9:37 PM, Stephane Ducasse <[hidden email]> wrote:
Hi bernhard

sorry. Yes we should have a look.

Stef

On Sun, Feb 25, 2018 at 4:12 PM, Bernhard Pieber <[hidden email]> wrote:
> Hi all,
>
> Can somebody please help me get my bugfix from December integrated? For some reason CI fails and I have no idea how to debug that. :-(
> https://github.com/pharo-project/pharo/pull/632
>
> Bernhard




--

   

Guille Polito

Research Engineer

Centre de Recherche en Informatique, Signal et Automatique de Lille

CRIStAL - UMR 9189

French National Center for Scientific Research - http://www.cnrs.fr


Web: http://guillep.github.io

Phone: +33 06 52 70 66 13