Smalltalk › Redline Smalltalk

Pull request sent

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Srinivas JONNALAGADDA

Pull request sent

James,

The commit 990d776be6 of 14 days ago fails one test: PrimObjectTest#variableAtShouldCallResolveObject. I fixed the test, and have sent a pull request to you. This one-line pull request is also intended to verify that I am following the process! Thanks.

-- |0|0|

James Ladd

Re: Pull request sent

I'll be sure to review this tonight.
Not sure why I didn't get notification.
I'll check that too

Sent from Hyperspace.

On 28/12/2012, at 4:05 PM, Srinivas JONNALAGADDA <[hidden email]> wrote:

> James,
>
> The commit 990d776be6 of 14 days ago fails one test: PrimObjectTest#variableAtShouldCallResolveObject. I fixed the test, and have sent a pull request to you. This one-line pull request is also intended to verify that I am following the process! Thanks.
>
> -- |0|0|

James Ladd

Re: Pull request sent

Merged. Very sorry I didn't action this sooner.

On Fri, Dec 28, 2012 at 6:04 PM, James Ladd <[hidden email]> wrote:

I'll be sure to review this tonight.
Not sure why I didn't get notification.
I'll check that too

Sent from Hyperspace.

On 28/12/2012, at 4:05 PM, Srinivas JONNALAGADDA <[hidden email]> wrote:

> James,
>
> The commit 990d776be6 of 14 days ago fails one test: PrimObjectTest#variableAtShouldCallResolveObject. I fixed the test, and have sent a pull request to you. This one-line pull request is also intended to verify that I am following the process! Thanks.
>
> -- |0|0|