[QUESTION] For Dark Theme users

@esteban, as you are working on dark theme, can you take a look at this

issue

14923

TextAdornment: take account of current theme background color

I am not sure what is the right way to solve this for rubric, and even if I would know it,

I can not commit to rubrics repository :)

2015-05-02 10:24 GMT+02:00 Esteban Lorenzano <[hidden email]>:

On 02 May 2015, at 04:10, Cyril Ferlicot <[hidden email]> wrote:

This is maybe a little 'too' dark.

Maybe we can do a setting to choose if we want it more or less dark.

yes, but we also need a good default, because most people will not tune their system until they are used to it :)

So, I think we need to restore the “preference theme settings” options (another brick in the wall… I mean another todo entry in my list)

And in the mean time I will chose something between current and my proposal (because I’m convinced current one does not offer good contrast).

Esteban

An other think that would be good with the dark theme is to change the color of the Test Runner because the fluo green attack the eyes when we're on the dark theme x_x.

Since we talk about the dark theme, is that normal than the background of the RubScrolledTextMorph stay white ? Or should I use an other Rub text morph ?

On 1 May 2015 at 13:52, [hidden email] <[hidden email]> wrote:

Dawn Theme is lighter actually.

As long as it is not black ...

Phil

Le 1 mai 2015 12:34, "Esteban Lorenzano" <[hidden email]> a écrit :

I suppose "Down Theme” users (cough, cough, Phil) too. 

I want to change the background color for something even darker: 

<Screen Shot 2015-05-01 at 12.33.48.png>

I think it look better… what do you think?

(Also… I need to refactor this theme thingy… is really ugly :P)

Esteban

--

Cheers

Cyril Ferlicot

On Mon, May 4, 2015 at 11:31 PM, Nicolai Hess <[hidden email]> wrote:

@esteban, as you are working on dark theme, can you take a look at this

issue

14923

TextAdornment: take account of current theme background color

I am not sure what is the right way to solve this for rubric, and even if I would know it,

I can not commit to rubrics repository :)

Rubric repo is now under the Pharo team (Pharo/Rubric)

Cheers,

Andrei

 

2015-05-02 10:24 GMT+02:00 Esteban Lorenzano <[hidden email]>:

On 02 May 2015, at 04:10, Cyril Ferlicot <[hidden email]> wrote:

This is maybe a little 'too' dark.

Maybe we can do a setting to choose if we want it more or less dark.

yes, but we also need a good default, because most people will not tune their system until they are used to it :)

So, I think we need to restore the “preference theme settings” options (another brick in the wall… I mean another todo entry in my list)

And in the mean time I will chose something between current and my proposal (because I’m convinced current one does not offer good contrast).

Esteban

An other think that would be good with the dark theme is to change the color of the Test Runner because the fluo green attack the eyes when we're on the dark theme x_x.

Since we talk about the dark theme, is that normal than the background of the RubScrolledTextMorph stay white ? Or should I use an other Rub text morph ?

On 1 May 2015 at 13:52, [hidden email] <[hidden email]> wrote:

Dawn Theme is lighter actually.

As long as it is not black ...

Phil

Le 1 mai 2015 12:34, "Esteban Lorenzano" <[hidden email]> a écrit :

I suppose "Down Theme” users (cough, cough, Phil) too. 

I want to change the background color for something even darker: 

<Screen Shot 2015-05-01 at 12.33.48.png>

I think it look better… what do you think?

(Also… I need to refactor this theme thingy… is really ugly :P)

Esteban

--

Cheers

Cyril Ferlicot