Smalltalk › Pharo › Pharo Smalltalk Users

QualityAssistant ignoring rules

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Peter Uhnak

QualityAssistant ignoring rules

Hi,

is there a simple way to add certain rule as ignored? Something like "right click -> supress rule"

I am working on tools that do use metaprogramming, so it tends to complain, and for example in roassal there is a common pattern

element := RTBox new size: 50; elementOn: 'sth'.

But that of course complains about missing "; yourself". Of course I could break it into two statements but that is counter-productive.

So it would be nice if I could with a simple click ignore certain rules.

Thanks,

Peter

Uko2

Re: QualityAssistant ignoring rules

Hi Peter.

For now - no, but you can check a prototype if you load QualityAssistant with:

Metacello new
baseline: #QualityAssistant;
repository: 'github://Uko/QualityAssistant:development';
load

Want to make a whole new philosophy of how do you tell which parts should be checked with which rules. So in future you’ll be able to tell on the level of a package, class or method which rules do you want to run and which rules do you want to skip, or which parameters (number of methods in a class) should a rule use when it checks your entities.

For now you can skip rule on the level of class or method. When you do this a specific code is written down in the class or method, so if the other developer will read your code he can also se the you’ve skipped the rule on porpoise and it’s a planned decision.

Cheers!
Uko

> On 25 Apr 2015, at 09:50, Peter Uhnák <[hidden email]> wrote:
>
> Hi,
>
> is there a simple way to add certain rule as ignored? Something like "right click -> supress rule"
> I am working on tools that do use metaprogramming, so it tends to complain, and for example in roassal there is a common pattern
> element := RTBox new size: 50; elementOn: 'sth'.
> But that of course complains about missing "; yourself". Of course I could break it into two statements but that is counter-productive.
> So it would be nice if I could with a simple click ignore certain rules.
>
> Thanks,
> Peter

Peter Uhnak

Re: QualityAssistant ignoring rules

Excellent!

I'm also noticing that this doesn't use the CriticBrowser's Manifest class, but I assume this is already somewhere on your todo list. (I'm not very fond of the pragma usage here, it would be nice to have it as metadata (in a possibly separate window which I can't open/close on demand)).

Thanks!

Peter

On Sat, Apr 25, 2015 at 10:30 AM, Yuriy Tymchuk <[hidden email]> wrote:

Hi Peter.

For now - no, but you can check a prototype if you load QualityAssistant with:

Metacello new
baseline: #QualityAssistant;
repository: 'github://Uko/QualityAssistant:development';
load

Want to make a whole new philosophy of how do you tell which parts should be checked with which rules. So in future you’ll be able to tell on the level of a package, class or method which rules do you want to run and which rules do you want to skip, or which parameters (number of methods in a class) should a rule use when it checks your entities.

For now you can skip rule on the level of class or method. When you do this a specific code is written down in the class or method, so if the other developer will read your code he can also se the you’ve skipped the rule on porpoise and it’s a planned decision.

Cheers!
Uko

> On 25 Apr 2015, at 09:50, Peter Uhnák <[hidden email]> wrote:
>
> Hi,
>
> is there a simple way to add certain rule as ignored? Something like "right click -> supress rule"
> I am working on tools that do use metaprogramming, so it tends to complain, and for example in roassal there is a common pattern
> element := RTBox new size: 50; elementOn: 'sth'.
> But that of course complains about missing "; yourself". Of course I could break it into two statements but that is counter-productive.
> So it would be nice if I could with a simple click ignore certain rules.
>
> Thanks,
> Peter

Uko2

Re: QualityAssistant ignoring rules

That’s why it’s not in production :).

Thank you for the feedback

On 25 Apr 2015, at 11:54, Peter Uhnák <[hidden email]> wrote:

Excellent!

I'm also noticing that this doesn't use the CriticBrowser's Manifest class, but I assume this is already somewhere on your todo list. (I'm not very fond of the pragma usage here, it would be nice to have it as metadata (in a possibly separate window which I can't open/close on demand)).

Thanks!

Peter

On Sat, Apr 25, 2015 at 10:30 AM, Yuriy Tymchuk <[hidden email]> wrote:
Hi Peter.

For now - no, but you can check a prototype if you load QualityAssistant with:

Metacello new
baseline: #QualityAssistant;
repository: '<a href="github://Uko/QualityAssistant:development'" class="">github://Uko/QualityAssistant:development';
load

Want to make a whole new philosophy of how do you tell which parts should be checked with which rules. So in future you’ll be able to tell on the level of a package, class or method which rules do you want to run and which rules do you want to skip, or which parameters (number of methods in a class) should a rule use when it checks your entities.

For now you can skip rule on the level of class or method. When you do this a specific code is written down in the class or method, so if the other developer will read your code he can also se the you’ve skipped the rule on porpoise and it’s a planned decision.

Cheers!
Uko

> On 25 Apr 2015, at 09:50, Peter Uhnák <[hidden email]> wrote:
>
> Hi,
>
> is there a simple way to add certain rule as ignored? Something like "right click -> supress rule"
> I am working on tools that do use metaprogramming, so it tends to complain, and for example in roassal there is a common pattern
> element := RTBox new size: 50; elementOn: 'sth'.
> But that of course complains about missing "; yourself". Of course I could break it into two statements but that is counter-productive.
> So it would be nice if I could with a simple click ignore certain rules.
>
> Thanks,
> Peter