RB: push down

It seems that rb: push down variable operation works half way :) , it
deletes variable from the class, but id does not appear in any of the
subclasses.

rush

"rush" <[hidden email]> wrote in message
news:[hidden email]...
> It seems that rb: push down variable operation works half way :) , it
> deletes variable from the class, but id does not appear in any of the
> subclasses.

it seems the problem was in detecting if some subclass methed uses variable
or not; I had something like:

markerMethod
    instanceVariableInQuestion

and rb did not take it as usage of variable. When I changed the above into:


markerMethod
    ^instanceVariableInQuestion

things worked out.

rush

Davorin

You wrote in message news:[hidden email]...
>
> "rush" <[hidden email]> wrote in message
> news:[hidden email]...
> > It seems that rb: push down variable operation works half way :) , it
> > deletes variable from the class, but id does not appear in any of the
> > subclasses.
>
> it seems the problem was in detecting if some subclass methed uses
variable
> or not; I had something like:
>
> markerMethod
>     instanceVariableInQuestion
>
> and rb did not take it as usage of variable. When I changed the above
into:
>
>
> markerMethod
>     ^instanceVariableInQuestion
>
> things worked out.

I think that is probably a bug in the refactoring engine (or alternatively
it is spotting that #markerMethod is dead code :-)).

Regards

Blair