RBUnpackagedCodeRule

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RBUnpackagedCodeRule

Uko2
Hi, does RBUnpackagedCodeRule still make sense?

Because from time to time it gives false positives, so I’ve tried to rewrite it as:
“anEntity package mcPackage isNil”

but it turns out that every method and class has MCPackage.

Uko
Reply | Threaded
Open this post in threaded view
|

Re: RBUnpackagedCodeRule

Thierry Goubier
I believe what you want to check is if it belongs to the #_UnpackagedPackage, in which cas it is not referenced in any package yet.

Thierry

2015-06-16 16:58 GMT+02:00 Yuriy Tymchuk <[hidden email]>:
Hi, does RBUnpackagedCodeRule still make sense?

Because from time to time it gives false positives, so I’ve tried to rewrite it as:
“anEntity package mcPackage isNil”

but it turns out that every method and class has MCPackage.

Uko

Reply | Threaded
Open this post in threaded view
|

Re: RBUnpackagedCodeRule

Uko2
Ah, then I can do it like:

anEntity package isDefault

Thanks, I like that, but I’ll also wait a bit for other feedback before submitting the change :)

Uko

On 16 Jun 2015, at 17:02, Thierry Goubier <[hidden email]> wrote:

I believe what you want to check is if it belongs to the #_UnpackagedPackage, in which cas it is not referenced in any package yet.

Thierry

2015-06-16 16:58 GMT+02:00 Yuriy Tymchuk <[hidden email]>:
Hi, does RBUnpackagedCodeRule still make sense?

Because from time to time it gives false positives, so I’ve tried to rewrite it as:
“anEntity package mcPackage isNil”

but it turns out that every method and class has MCPackage.

Uko


Reply | Threaded
Open this post in threaded view
|

Re: RBUnpackagedCodeRule

stepharo
send it ;)

Le 16/6/15 17:06, Yuriy Tymchuk a écrit :
Ah, then I can do it like:

anEntity package isDefault

Thanks, I like that, but I’ll also wait a bit for other feedback before submitting the change :)

Uko

On 16 Jun 2015, at 17:02, Thierry Goubier <[hidden email]> wrote:

I believe what you want to check is if it belongs to the #_UnpackagedPackage, in which cas it is not referenced in any package yet.

Thierry

2015-06-16 16:58 GMT+02:00 Yuriy Tymchuk <[hidden email]>:
Hi, does RBUnpackagedCodeRule still make sense?

Because from time to time it gives false positives, so I’ve tried to rewrite it as:
“anEntity package mcPackage isNil”

but it turns out that every method and class has MCPackage.

Uko



Reply | Threaded
Open this post in threaded view
|

Re: RBUnpackagedCodeRule

Uko2
It’s already integrated in Pharo 5. I’ll open a backport issue for Pharo 4 soon. I was a bit… busy last few days

Uko

On 07 Jul 2015, at 21:34, stepharo <[hidden email]> wrote:

send it ;)

Le 16/6/15 17:06, Yuriy Tymchuk a écrit :
Ah, then I can do it like:

anEntity package isDefault

Thanks, I like that, but I’ll also wait a bit for other feedback before submitting the change :)

Uko

On 16 Jun 2015, at 17:02, Thierry Goubier <[hidden email]> wrote:

I believe what you want to check is if it belongs to the #_UnpackagedPackage, in which cas it is not referenced in any package yet.

Thierry

2015-06-16 16:58 GMT+02:00 Yuriy Tymchuk <[hidden email]>:
Hi, does RBUnpackagedCodeRule still make sense?

Because from time to time it gives false positives, so I’ve tried to rewrite it as:
“anEntity package mcPackage isNil”

but it turns out that every method and class has MCPackage.

Uko