ROBeginingAnimation>>isOver

I was browsing Roassal looking for how mouse-overs are handled, and
bumped into the method ROBeginingAnimation>>isOver, and I was
momentarily confused by what "over" would mean in this context.  Without
knowing the whole architecture, I am thinking that perhaps a better
method name would be 'isComplete'.  In a highly GUI oriented system,
"over" has too many meanings without diving into the code.

If that is reasonable, but I distraction from other work, I could
implement and submit the change.  The method is referenced from five
methods and three tests.

cheers -ben
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Very good point!

Fixed in Roassal 1.95

Alexandre


On Aug 18, 2012, at 2:31 AM, Ben Coman <[hidden email]> wrote:

> I was browsing Roassal looking for how mouse-overs are handled, and bumped into the method ROBeginingAnimation>>isOver, and I was momentarily confused by what "over" would mean in this context.  Without knowing the whole architecture, I am thinking that perhaps a better method name would be 'isComplete'.  In a highly GUI oriented system, "over" has too many meanings without diving into the code.
>
> If that is reasonable, but I distraction from other work, I could implement and submit the change.  The method is referenced from five methods and three tests.
>
> cheers -ben
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Thanks Alex.

Alexandre Bergel wrote:

Very good point!

Fixed in Roassal 1.95

Alexandre


On Aug 18, 2012, at 2:31 AM, Ben Coman [hidden email] wrote:

  

I was browsing Roassal looking for how mouse-overs are handled, and bumped into the method ROBeginingAnimation>>isOver, and I was momentarily confused by what "over" would mean in this context.  Without knowing the whole architecture, I am thinking that perhaps a better method name would be 'isComplete'.  In a highly GUI oriented system, "over" has too many meanings without diving into the code.

If that is reasonable, but I distraction from other work, I could implement and submit the change.  The method is referenced from five methods and three tests.

cheers -ben
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
    

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev