ROCircle - rename to ROElipse? (related to issue 857)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
cbc
Reply | Threaded
Open this post in threaded view
|

ROCircle - rename to ROElipse? (related to issue 857)

cbc
As stated in this bug:
"(Sorry) to be explicit, "Circles" should be constrained to remain a circle when either dimension is changed."

That's probably right.  However, I like the current behavior - I would like an ellipse that fit around my text.  Could we rename the current ROCircle to be ROEllipse (and add related code to handle this), and create a new ROCircle that maintained itself as a Circle for those who want that behavior?

I'd be happy to take on doing this (or at least some of it) in the next few days; I just need to understand how to submit the changes (and if you want them).

-Chris

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: ROCircle - rename to ROElipse? (related to issue 857)

vpena
Today I'm working with ROCIrcle for this issue:

http://code.google.com/p/moose-technology/issues/detail?id=915

So I'll try to do this today as well :)

Vanessa.

On 03/07/2013 01:46 PM, Chris Cunningham wrote:
As stated in this bug:
"(Sorry) to be explicit, "Circles" should be constrained to remain a circle when either dimension is changed."

That's probably right.  However, I like the current behavior - I would like an ellipse that fit around my text.  Could we rename the current ROCircle to be ROEllipse (and add related code to handle this), and create a new ROCircle that maintained itself as a Circle for those who want that behavior?

I'd be happy to take on doing this (or at least some of it) in the next few days; I just need to understand how to submit the changes (and if you want them).

-Chris


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: ROCircle - rename to ROElipse? (related to issue 857)

abergel
In reply to this post by cbc
Hi Chris,

Thanks for your input. Having a circle with text inside is not an easy thing to do, especially if you want the circle to be the smallest possible for a given piece of text.

Yesterday, Vanessa and I have discussed about this point. We will probably do a ROLabelledEllipse or something similar.

@Vanessa, I think this is the second time that we heard the point about ellipse vs circle. So yes, we should rename ROCircle into ROEllipse.

Cheers,
Alexandre


On Mar 7, 2013, at 1:46 PM, Chris Cunningham <[hidden email]> wrote:

> As stated in this bug:
> "(Sorry) to be explicit, "Circles" should be constrained to remain a circle when either dimension is changed."
>
> That's probably right.  However, I like the current behavior - I would like an ellipse that fit around my text.  Could we rename the current ROCircle to be ROEllipse (and add related code to handle this), and create a new ROCircle that maintained itself as a Circle for those who want that behavior?
>
> I'd be happy to take on doing this (or at least some of it) in the next few days; I just need to understand how to submit the changes (and if you want them).
>
> -Chris
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev